[teamleaderleo]

Fixes a false red in the webviews checks (fast gates and ci-web): vp fmt --check closes with Finished in 528ms on 2481 files using 4 threads.. When the base already has format findings and the pull request adds or removes any file, the merge and the base close on different file counts, and that closing line reads as the one finding the merge added.

Seen on

#24274's fast gates, twice, against two bases:

• run 39874062403 (base bb02624): 1 finding(s) this change adds over the base: Finished in 2057ms on 2461 files using 4 threads.
• run 39891007201 (base da65a72): 1 finding(s) this change adds over the base: Finished in 528ms on 2481 files using 4 threads.

Both runs say the other 3 vp fmt findings are on the base too, so the pull request added no format finding.

Fix

NOISE in scripts/ci/fast_gate_webviews_checks.py also matches Finished in … on N files, the same way it already skips the type check's Found N errors and N warnings summary. A file vp fmt names is still a finding.

Test

test_replay_of_24274_the_format_check_file_count_is_not_a_finding (huge-blue):

• At base code: fails with ['Finished in 528ms on 2481 files using 4 threads.'] != [].
• With the fix: passes. It also checks that a newly unformatted file is still charged.
• WebviewsChecksGate: all 22 tests pass.

risk:low. CI gate only; no app code.

Agent session: cosmic-gray

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes a false red in the webviews fast gates and CI-web: vp fmt --check's closing line (e.g. Finished in 528ms on 2481 files using 4 threads.) is no longer counted as a finding. When the base already has format findings and the pull request adds or removes any file, the merge and base close on different file counts, which previously read as the one finding the merge added (#24274).

• Treats only the whole closing file-count line as run noise, like the type check's Found N errors and N warnings summary; files the formatter actually names are still findings, including files whose names start like the summary.
• Adds a replay test covering cmux NEXT New Tab: the default project is the chat you last picked and started, never an agent's folder #24274's case, confirming the summary is not charged and that a newly unformatted file, or a file named like the summary, is still reported.

^{Written for commit 0350b54. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 0350b54: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24436 -f ref=composer-look-fmt-noise -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on a11c795 to compare; do not merge until green; see lane-rules

[teamleaderleo]

Owned by composer-look on cosmic-gray · session

[blacksmith-sh]

Found 9 test failures on Blacksmith runners:

Failures

Test	View Logs
/tmp/tmp7ohmv25w/summary-fail.json (live):/summary-fail.json (live):	View Logs
/tmp/tmpgun331mu/summary-missing.json (live):/summary-missing.json (live):	View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/ [new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows	View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames	View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/ [tabs] debug.tab_switch timed 0 of 40 switches	View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames	View Logs
test_base_passes (main.NoticesPairTests.test_base_passes)/ test_base_passes (main.NoticesPairTests.test_base_passes)	View Logs
test_targets_outside_the_app_go_to_the_mac_canary (main.SwiftCanaryFleetCoverage.te st_targets_outside_the_app_go_to_the_mac_canary)/ test_targets_outside_the_app_go_to_the_mac_canary (main.SwiftCanaryFleetCoverage.te st_targets_outside_the_app_go_to_the_mac_canary)	View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl ights_validate)/ test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl ights_validate)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[teamleaderleo]

cmux-next guards / nightly-guards / workflow-guard-tests / release-notary is red on 11 of 11 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

[teamleaderleo]

cmux-next / cmux-next checks (god files, concurrency, crash safety, l10n) › Checks job structure is red on 11 of 11 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

[teamleaderleo]

Bead cx-ecdcc created for this PR by the cmux coordinator.

[teamleaderleo]

Review (codex gpt-6.1-sol): BLOCK at 3440d8b

Blocking finding: scripts/ci/fast_gate_webviews_checks.py:54 — NOISE matches only a prefix (Finished in \S+ on \d+ files?\b) and does not require the formatter summary to end there. vp fmt --check reports an unformatted valid root-level file named Finished in 1ms on 2 files.ts as Finished in 1ms on 2 files.ts (1ms). The regex matches the Finished in 1ms on 2 files prefix, so findings() drops that real issue; against a base with an existing formatting error, added() returns no new finding and the PR can pass while adding the unformatted file.

Non-blocking findings: none.

Checked: fetched the exact base/head refs, reviewed both commits and all changed code/tests plus the CI callers, reproduced the parser result with the formatter output shape, and ran syntax/diff-whitespace checks; no app builds or test suites.

[teamleaderleo]

Review (codex gpt-6.1-sol): SHIP at 0350b54

Blocking findings: none.

Non-blocking findings: none.

Checked the merge-base diff, both parser call paths, the anchored formatter-summary and filename-prefix edge cases, and the focused test wiring; no macOS build or Swift suite was run.

[github-actions]

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.3991367032401 (b9c3d5aabc)
• cmux NEXT nightly 1.0.0-nightly.3991503232101 (cd84bc62d1)
• cmux NEXT nightly 1.0.0-nightly.3991575404801 (a62351daaa)