Repository navigation
crash-class: probe NSView firstBaselineOffsetFromTop into the selector table - #24417
Merged
Merged
Conversation
…r table HoverCardIconSlot and HoverCardRow (1231b9d) call super.firstBaselineOffsetFromTop on an NSView, a key the table did not know, so check-objc-selectors failed "probe needed" on every PR. Probed with --probe --write on macOS 27.0.1 (cosmic-gray, ctypes only, no build): NSView answers it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on e0ae6fa to compare; do not merge until green; see lane-rules |
Collaborator
Author
|
Owned by land-and-ci on huge-blue · session |
Collaborator
Author
|
Found 10 test failures on Blacksmith runners: Failures
|
Contributor
|
Shipped in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red:
cmux-next crash-class rulesfails on every PR (e.g. #24025, #24327) with "probe needed" forsuper.firstBaselineOffsetFromTopin HoverCardIconSlot.swift:27 and HoverCardRow.swift:278 (added by 1231b9d). The fix is the checker's own repair:check-objc-selectors.py --probe --writeon a Mac, then commit the table. NSView answers the selector on macOS 27.0.1; that is the one entry added.Changelog
none
Observed / Not run
python3 -I scripts/cmux-next/check-objc-selectors.pyat base 8fa7236: 2 failures, the ones above. With this table: 0 failures.Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
cmux-next crash-classcheck failing on every PR because the selector table had no entry forsuper.firstBaselineOffsetFromTop, used byHoverCardIconSlotandHoverCardRow. The checker now passes with 0 failures.NSView get:firstBaselineOffsetFromTop/0entry for macOS 27.0.1 only; the checker keys probes to the version they were run on.Written for commit 94347be. Summary will update on new commits.