Skip to content

ci(cmux-next guards): run test_ci_tip_test_compile.py on pull requests (tooling-tests base red) - #24397

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
deputy-2/tip-test-compile-pr-lane
Oct 22, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
deputy-2/tip-test-compile-pr-lane

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Base red on feat-cmux-next: cmux-next guards / tooling-tests, step "The Python test registry, and the tests no pull request runs", fails on every feat-cmux-next pull request (seen on #24136, run 39789311718, job 119860776563):

- tests/test_ci_tip_test_compile.py: linux-guard lane is not run by any workflow
warning: tests/test_ci_tip_test_compile.py: no job a pull request into feat-cmux-next runs executes it, so a change that breaks it lands green. Run it from a step of a job that runs on those pull requests (routed by the paths of the code it tests) ...

Origin: 77c3c5a ("ci(cmux-next): every feat-cmux-next push compiles the Swift test targets it can break…") registered tests/test_ci_tip_test_compile.py on the linux-guard lane in tests/test-execution.toml, but no workflow runs it; cmux-next-tip-test-compile.yml runs scripts/ci/tip-test-compile.sh only on feat-cmux-next pushes.

Change

One step in the tooling-tests job of .github/workflows/cmux-next-guards.yml (Linux, runs on every feat-cmux-next pull request and push, no path filter) runs python3 tests/test_ci_tip_test_compile.py, beside the other feat-cmux-next tooling tests and with the same if: ${{ !cancelled() }}. The test is stdlib Python driving the script against a fake cmux-ci client and a fake GitHub API: 9 tests, about 3 s. Nothing in cmux-next-tip-test-compile.yml or tip-test-compile.sh changes; this only makes the test run on pull requests, so a change that breaks the script no longer lands green.

Changelog

none

Observed / Not run

  • python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha cba27b07 (with PyYAML): at base cba27b07 it fails with tests/test_ci_tip_test_compile.py: linux-guard lane is not run by any workflow (exit 1); at this head it prints Python test execution registry valid: 455 tests (exit 0).
  • python3 -I tests/test_ci_tip_test_compile.py: Ran 9 tests ... OK (run on macOS; the script uses only bash, sed, grep and python3, and the test strips GITHUB_*/RUNNER_*).
  • actionlint .github/workflows/cmux-next-guards.yml: clean. scripts/cmux-next/prepush-gate.py: no new violations.
  • Not run: the job itself on Linux before this PR's CI.

Risk: low (CI wiring, one test step).

Agent session: cosmic-gray

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the red tooling-tests base check on feat-cmux-next pull requests so a change that breaks tip-test-compile.sh no longer lands green.

  • tooling-tests in cmux-next-guards.yml now also runs tests/test_ci_tip_test_compile.py, which previously only ran on pushes via cmux-next-tip-test-compile.yml.
  • tests/test_pr_lane_coverage.py now pins that test to the tooling-tests lane so the coverage check stays consistent.
  • The test uses a fake cmux-ci client and GitHub API, runs in about 3 seconds, and leaves push-time behavior unchanged.

Written for commit 29212b6. Summary will update on new commits.

View guided diff Turn on auto-fix

…(base red)

77c3c5a registered tests/test_ci_tip_test_compile.py on the linux-guard lane, but
no workflow runs it: cmux-next-tip-test-compile.yml runs the script only on
feat-cmux-next pushes. The registry check in tooling-tests has been red on every
feat-cmux-next pull request since ("linux-guard lane is not run by any workflow").
Run it in tooling-tests beside the other feat-cmux-next tooling tests; it is
stdlib Python with a fake cmux-ci client and GitHub API (9 tests, about 3 s).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1603a-6462-72f0-a4b0-6937eb58e4c3&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 29212b6: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24397 -f ref=deputy-2/tip-test-compile-pr-lane -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 22, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-6ek6t created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent subagent, correctness first): SHIP at 29212b6

  • With --pr-lanes feat-cmux-next --base-sha HEAD^1, scripts/ci/validate_test_execution_registry.py exits 0. That clears both the linux-guard error (tests/test_ci_tip_test_compile.py: linux-guard lane is not run by any workflow) and the pull-request lane check. tests/pr-lane-exemptions.json doesn't list the test, so there's no stale-exemption error.
  • tests/test_ci_tip_test_compile.py uses only stdlib Python with a fake cmux-ci client and a fake GitHub API: no network and nothing macOS-only. It passes 9/9 in about 3 s. The new step is placed like its sibling tooling-tests steps and has the same if: ${{ !cancelled() }}. cmux-next-tip-test-compile.yml and tip-test-compile.sh are untouched.
  • Delta in 29212b6: the test is now in in_tooling_tests in tests/test_pr_lane_coverage.py, so dropping the step later turns that test red. tests/test_pr_lane_coverage.py passes.
  • The CI on 6a6b4ce has tooling-tests green. The remaining reds fail on the same steps in feat-cmux-next push runs (23cc5a5, 3b01b70, d511296): release-notary's notices pair check, Guard status, and cmux-next checks' "Fail on any red check".

@teamleaderleo teamleaderleo added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Oct 22, 2026
@teamleaderleo
teamleaderleo merged commit 44fc3d3 into feat-cmux-next Oct 22, 2026
@teamleaderleo
teamleaderleo deleted the deputy-2/tip-test-compile-pr-lane branch October 22, 2026 15:00
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant