Repository navigation
ci(cmux-next guards): run test_ci_tip_test_compile.py on pull requests (tooling-tests base red) - #24397
Merged
Conversation
…(base red) 77c3c5a registered tests/test_ci_tip_test_compile.py on the linux-guard lane, but no workflow runs it: cmux-next-tip-test-compile.yml runs the script only on feat-cmux-next pushes. The registry check in tooling-tests has been red on every feat-cmux-next pull request since ("linux-guard lane is not run by any workflow"). Run it in tooling-tests beside the other feat-cmux-next tooling tests; it is stdlib Python with a fake cmux-ci client and GitHub API (9 tests, about 3 s). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1603a-6462-72f0-a4b0-6937eb58e4c3&host=cosmic-gray
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Collaborator
Author
|
Bead |
…est_compile.py Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1603a-6462-72f0-a4b0-6937eb58e4c3&host=cosmic-gray
Collaborator
Author
|
Review (independent subagent, correctness first): SHIP at 29212b6
|
Contributor
|
Shipped in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base red on
feat-cmux-next: cmux-next guards / tooling-tests, step "The Python test registry, and the tests no pull request runs", fails on every feat-cmux-next pull request (seen on #24136, run 39789311718, job 119860776563):Origin: 77c3c5a ("ci(cmux-next): every feat-cmux-next push compiles the Swift test targets it can break…") registered
tests/test_ci_tip_test_compile.pyon thelinux-guardlane intests/test-execution.toml, but no workflow runs it;cmux-next-tip-test-compile.ymlrunsscripts/ci/tip-test-compile.shonly on feat-cmux-next pushes.Change
One step in the
tooling-testsjob of.github/workflows/cmux-next-guards.yml(Linux, runs on every feat-cmux-next pull request and push, no path filter) runspython3 tests/test_ci_tip_test_compile.py, beside the other feat-cmux-next tooling tests and with the sameif: ${{ !cancelled() }}. The test is stdlib Python driving the script against a fakecmux-ciclient and a fake GitHub API: 9 tests, about 3 s. Nothing incmux-next-tip-test-compile.ymlortip-test-compile.shchanges; this only makes the test run on pull requests, so a change that breaks the script no longer lands green.Changelog
none
Observed / Not run
python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha cba27b07(with PyYAML): at basecba27b07it fails withtests/test_ci_tip_test_compile.py: linux-guard lane is not run by any workflow(exit 1); at this head it printsPython test execution registry valid: 455 tests(exit 0).python3 -I tests/test_ci_tip_test_compile.py:Ran 9 tests ... OK(run on macOS; the script uses only bash, sed, grep and python3, and the test stripsGITHUB_*/RUNNER_*).actionlint .github/workflows/cmux-next-guards.yml: clean.scripts/cmux-next/prepush-gate.py: no new violations.Risk: low (CI wiring, one test step).
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the red
tooling-testsbase check onfeat-cmux-nextpull requests so a change that breakstip-test-compile.shno longer lands green.tooling-testsincmux-next-guards.ymlnow also runstests/test_ci_tip_test_compile.py, which previously only ran on pushes viacmux-next-tip-test-compile.yml.tests/test_pr_lane_coverage.pynow pins that test to thetooling-testslane so the coverage check stays consistent.cmux-ciclient and GitHub API, runs in about 3 seconds, and leaves push-time behavior unchanged.Written for commit 29212b6. Summary will update on new commits.