Repository navigation
cmux NEXT tests: PaneMotionBench's argument list is nonisolated, so CmuxNextAppTests build again - #24377
Conversation
…sts build again `@Test(arguments: cases)` reads `cases` outside the main actor, but the suite is `@MainActor`, so 241f5ba left CmuxNextAppTests failing to compile ("main actor-isolated static property 'cases' cannot be accessed from outside of the actor", PaneMotionBench.swift:152). `Case` is Sendable and the list is a constant, so it is declared nonisolated. The bench itself is unchanged and still runs only with CMUX_PANE_BENCH=1. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=Air-Blue Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: |
|
Owned by orphan-sweep on air-blue · session |
|
Review (subagent, correctness first): SHIP at d3230f2 Fresh-context review subagent, code read only. |
|
Found 9 test failures on Blacksmith runners: Failures
|
|
Bead |
Brings in #24377 (CmuxNextAppTests build again), which the PR autofix's settings-export regeneration needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=Air-Blue
Picks up #24377 (CmuxNextAppTests compile again) so the fleet test run can build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Picks up #24377 (CmuxNextAppTests compile again) so the fleet test run can build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red that hides signal: since 241f5ba (PaneMotionBench, "bench, red") the CmuxNext test targets do not compile on feat-cmux-next, so the fast tier stops at "the tests do not build" and no CmuxNextAppTests run on any PR:
@Test(arguments: cases)evaluates the argument list outside the suite's@MainActor.Caseis alreadySendableand the list is a constant, socasesis nownonisolated static let. One word; the bench's logic, budgets and itsCMUX_PANE_BENCH=1gate are unchanged.Verification: fleet
package-test-lane.shat this head withTabMachineColorTests,PaneMotionBench(the bench compiles and stays disabled without the env var; TabMachineColorTests from #24159 has not been able to run since the break).No capture: test-only change, nothing on screen moves.
Agent session: Air-Blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the CmuxNext test target build so CmuxNextAppTests can run on feat-cmux-next again.
PaneMotionBench.caseswas main-actor isolated, but@Test(arguments: cases)evaluates its argument list outside the suite's@MainActor, which left the target uncompilable.Caseis alreadySendableand the list is a constant, socasesis nownonisolated static let. The bench's logic, budgets, andCMUX_PANE_BENCH=1gate are unchanged.Written for commit d3230f2. Summary will update on new commits.