Skip to content

cmux NEXT tests: PaneMotionBench's argument list is nonisolated, so CmuxNextAppTests build again - #24377

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/pane-bench-nonisolated-cases
Oct 22, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/pane-bench-nonisolated-cases

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Base red that hides signal: since 241f5ba (PaneMotionBench, "bench, red") the CmuxNext test targets do not compile on feat-cmux-next, so the fast tier stops at "the tests do not build" and no CmuxNextAppTests run on any PR:

PaneMotionBench.swift:152: main actor-isolated static property 'cases' cannot be accessed from outside of the actor

@Test(arguments: cases) evaluates the argument list outside the suite's @MainActor. Case is already Sendable and the list is a constant, so cases is now nonisolated static let. One word; the bench's logic, budgets and its CMUX_PANE_BENCH=1 gate are unchanged.

Verification: fleet package-test-lane.sh at this head with TabMachineColorTests,PaneMotionBench (the bench compiles and stays disabled without the env var; TabMachineColorTests from #24159 has not been able to run since the break).

No capture: test-only change, nothing on screen moves.

Agent session: Air-Blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the CmuxNext test target build so CmuxNextAppTests can run on feat-cmux-next again.

PaneMotionBench.cases was main-actor isolated, but @Test(arguments: cases) evaluates its argument list outside the suite's @MainActor, which left the target uncompilable. Case is already Sendable and the list is a constant, so cases is now nonisolated static let. The bench's logic, budgets, and CMUX_PANE_BENCH=1 gate are unchanged.

Written for commit d3230f2. Summary will update on new commits.

View guided diff Turn on auto-fix

…sts build again

`@Test(arguments: cases)` reads `cases` outside the main actor, but the suite
is `@MainActor`, so 241f5ba left CmuxNextAppTests failing to compile
("main actor-isolated static property 'cases' cannot be accessed from outside
of the actor", PaneMotionBench.swift:152). `Case` is Sendable and the list is
a constant, so it is declared nonisolated. The bench itself is unchanged and
still runs only with CMUX_PANE_BENCH=1.

Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=Air-Blue
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 22, 2026
@cursor

cursor Bot commented Oct 22, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review d3230f2: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24377 -f ref=fix/pane-bench-nonisolated-cases -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: red check: Checks job structure (+1 more) is not red on the base 5890201; do not merge until green; see lane-rules

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by orphan-sweep on air-blue · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, correctness first): SHIP at d3230f2

Fresh-context review subagent, code read only. nonisolated static let on a Sendable constant is allowed under the target's settings (Swift 6 mode, MainActor default isolation, InferIsolatedConformances), and it matches the existing pattern for @Test(arguments:) lists in CmuxNext tests: SidebarFooterAlignmentTests.swift:45-55 and SidebarPinnedRowWidthTests.swift:77-93 have exactly this shape, and about 40 other lists are declared the same way. No other error of this kind is in 241f5ba; the only other file it changed is a shell script. Optional, not done: mark struct Case nonisolated too, so the custom test names show when Swift Testing reads them off the main actor. The two existing Sidebar suites don't do that either.

@github-actions github-actions Bot added risk:low Risk tier (docs/ci/risk-tiers.md) and removed risk:normal Risk tier (docs/ci/risk-tiers.md) labels Oct 22, 2026
@blacksmith-sh

blacksmith-sh Bot commented Oct 22, 2026

Copy link
Copy Markdown

Found 9 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpfa784deh/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpy0ofg363/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
test_every_part_of_bun_run_check_runs_in_the_warn_branch (main.WebviewsWarnSplitCov
ersCheck.test_every_part_of_bun_run_check_runs_in_the_warn_branch)/
test_every_part_of_bun_run_check_runs_in_the_warn_branch (main.WebviewsWarnSplitCov
ersCheck.test_every_part_of_bun_run_check_runs_in_the_warn_branch)
View Logs
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse
dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo
dules)/
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse
dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo
dules)
View Logs
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse
dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo
dules) (job='web-bundles')/
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse
dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo
dules) (job='web-bundles')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-e5nw6 created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit f8aa944 into feat-cmux-next Oct 22, 2026
@teamleaderleo
teamleaderleo deleted the fix/pane-bench-nonisolated-cases branch October 22, 2026 09:47
teamleaderleo added a commit that referenced this pull request Oct 22, 2026
Brings in #24377 (CmuxNextAppTests build again), which the PR autofix's
settings-export regeneration needs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfc-663f-7650-b9f7-64d198c6b88b&host=Air-Blue
teamleaderleo added a commit that referenced this pull request Oct 22, 2026
Picks up #24377 (CmuxNextAppTests compile again) so the fleet test run can build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Oct 22, 2026
Picks up #24377 (CmuxNextAppTests compile again) so the fleet test run can build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — d3230f21 Deployed Oct 22, 2026 by teamleaderleo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant