Repository navigation
CmuxConversation iOS: the reply thread drops from under the quote's tail - #24208
Conversation
The inline reply's thread line started beside the quote at its middle: a hook stuck out of the quote's leading side and crossed the quote's tail. Messages drops the line from under the quoted bubble (its tail, or a group's avatar column) and turns it toward a reply on the other side, ending in a short level run short of it; a same-side reply gets a straight line that stops above it. The geometry lives in ConversationReplyThread (CmuxConversationGeometry) with tests. The row keeps room for the quote's tail. Same commits as #24202 on feat-cmux-next; the package stays byte-identical on both branches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Found 1 test failure on Blacksmith runners: Failure
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Probably yours: CI failed on
Matched log linesNot re-run automatically: Written by
Agents: |
…ame-side reply keeps room for its line The line ends in a short level run toward a reply on the other side. A reply on the quote's own side keeps room for a visible straight line, and the line meets the reply's first piece of content (a photo or file above the caption). Same commits as #24202. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review: the same correctness-first subagent review as #24202 (findings and fixes posted there: #24202 (comment)). This branch's package is byte-identical to #24202's head 3145bc8. CI: the reds are base findings, not from this change (it only touches |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Upstream copy of the CmuxConversation part of #24202 (feat-cmux-next), so
Packages/iOS/CmuxConversationstays byte-identical on both branches (the TestFlight builder checks for drift).Cause.
MessageCellLayoutstarted the thread line beside the quote at its middle, which drew a hook out of the quote's leading side through its tail (user report in Chief, 2026-10-21).Fix. The line comes from
ConversationReplyThread(CmuxConversationGeometry). It drops from under the quoted bubble's tail (or, in a group, the avatar column beside an incoming quote), turns toward a reply on the other side level with the reply's middle, and ends in a short level run before the reply. A same-side reply gets a straight line that stops above it. The row keeps room for the quote's tail. Before/after against Messages, in both directions and light and dark: see #24202.Tests.
swift test --filter ConversationReplyThreadTestson a fleet mini: 6 tests with 13 issues on the old geometry, all pass now. All 255 CmuxConversationGeometryTests pass.The macOS UI (
MacConversationRows) has its own thread layout and is unchanged.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the inline reply thread line in
CmuxConversationiOS so it no longer draws a hook out of the quote's leading side through its tail.ConversationReplyThreadgeometry drops the line from under the quote's tail (or a group's avatar column), turns it toward a reply on the other side level with the reply's middle, and ends in a short level run short of the reply; same-side replies get a straight line that stops above them.Packages/iOS/CmuxConversationbyte-identical with thefeat-cmux-nextbranch's cmux-next iPhone: reply thread line, single Chief push, swipe actions close before the sidebar #24202, so the TestFlight drift check passes.ConversationReplyThreadTests(6 tests, all failing on the old geometry) plus a new geometry suite (255 tests).Written for commit 9d4ba66. Summary will update on new commits.