Skip to content

Bump unit test CI runner to 8x to fix OOM - #2406

Closed
lawrencecchen wants to merge 1 commit into
mainfrom
ci-bigger-runner
Closed

lawrencecchen wants to merge 1 commit into
mainfrom
ci-bigger-runner

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Mar 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • The TerminalControllerSocketSecurityTests added in Map Shift+Enter to raw newline in Ghostty #2355 cause ghostty surface allocation to OOM on the 6-core WarpBuild runner (error.OutOfMemory), failing 3 socket tests that were previously passing.
  • Bumps the tests job runner from warp-macos-15-arm64-6x to warp-macos-15-arm64-8x for more memory headroom.

Test plan

  • CI on this PR should show the 3 TerminalControllerSocketSecurityTests passing (or at least no longer OOM-ing)

Summary by cubic

Bump CI unit test runner from warp-macos-15-arm64-6x to warp-macos-15-arm64-8x to stop OOM failures in TerminalControllerSocketSecurityTests. This adds memory headroom for ghostty surface allocation so the three socket tests no longer fail.

Written for commit a2647e6. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated CI infrastructure configuration to optimize test job execution environment.

Note: This is an internal infrastructure change with no impact on product features or functionality.

The TerminalControllerSocketSecurityTests added in #2355 cause ghostty
surface allocation to OOM on the 6-core runner, failing 3 tests with
"error initializing surface err=error.OutOfMemory". Bump to 8x for
more memory headroom.
@vercel

vercel Bot commented Mar 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Mar 31, 2026 4:54am

@coderabbitai

coderabbitai Bot commented Mar 31, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 49baeac3-50aa-453a-a02a-d2a1275692ad

📥 Commits

Reviewing files that changed from the base of the PR and between 112358e and a2647e6.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow's tests job runner is upgraded from warp-macos-15-arm64-6x to warp-macos-15-arm64-8x in the GitHub Actions configuration, providing access to a higher-tier WarpBuild macOS arm64 machine for test execution.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/ci.yml
Updated the tests job's runs-on runner label from warp-macos-15-arm64-6x to warp-macos-15-arm64-8x to use a higher-capacity WarpBuild macOS arm64 machine instance.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A rabbit hops with glee and cheer,
The runner now more mighty here!
From 6x to 8x, stronger still,
Tests shall race down CI's hill! ⚙️🏃

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: bumping the CI runner to an 8x machine to fix OOM failures.
Description check ✅ Passed The description covers the Summary and Test plan sections well, explaining the problem and the solution. However, Testing, Demo Video, Review Trigger, and Checklist sections are missing or incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-bigger-runner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@greptile-apps

greptile-apps Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the WarpBuild runner for the tests CI job from warp-macos-15-arm64-6x to warp-macos-15-arm64-8x to resolve error.OutOfMemory failures introduced by TerminalControllerSocketSecurityTests (PR #2355), which allocate Ghostty surfaces and exhaust memory on the 6-core runner.

  • The change is surgical — only the tests job is affected; tests-build-and-lag and ui-regressions remain on warp-macos-15-arm64-6x as they don't exhibit the same memory pressure.
  • No logic, configuration, or test code changes are involved.
  • The workflow-guard-tests job validates that WarpBuild self-hosted runners are used, but those guards check for runner presence rather than a specific label, so no guard script updates are needed.

Confidence Score: 5/5

Safe to merge — single-line runner label bump with no logic changes.

The change is minimal and targeted: one runner label substitution in one CI job. No code, test logic, or configuration beyond the runner size is altered. The other two macOS jobs that don't exhibit OOM are deliberately left on the smaller runner, which is correct. No P1/P0 issues found.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/ci.yml Single-line runner bump from warp-macos-15-arm64-6x to warp-macos-15-arm64-8x for the tests job only; other jobs (tests-build-and-lag, ui-regressions) remain on 6x as they are not affected by the OOM.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    PR[Pull Request / Push to main] --> WG[workflow-guard-tests\nubuntu-latest]
    PR --> RD[remote-daemon-tests\nubuntu-latest]
    PR --> WT[web-typecheck\nubuntu-latest]
    PR --> T[tests\nwarp-macos-15-arm64-8x BUMPED]
    PR --> TBL[tests-build-and-lag\nwarp-macos-15-arm64-6x]
    PR --> UI[ui-regressions\nwarp-macos-15-arm64-6x]

    T --> UT[Run unit tests\nTerminalControllerSocketSecurityTests\nno longer OOM]
    TBL --> LAG[Lag regression\nnot OOM-affected]
    UI --> UIR[UI regressions\nnot OOM-affected]
Loading

Reviews (1): Last reviewed commit: "Bump unit test CI runner to 8x to fix OO..." | Re-trigger Greptile

@lawrencecchen lawrencecchen added the stale-revisit Closed after 30+ days without activity; preserved for possible revisit or reopening. label Sep 23, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in cmux backlog Sep 23, 2026

This branch was successfully deployed

1 active deployment
Preview — a2647e6f Deployed Mar 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale-revisit Closed after 30+ days without activity; preserved for possible revisit or reopening.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants