Repository navigation
Bump unit test CI runner to 8x to fix OOM - #2406
lawrencecchen wants to merge 1 commit into
Conversation
The TerminalControllerSocketSecurityTests added in #2355 cause ghostty surface allocation to OOM on the 6-core runner, failing 3 tests with "error initializing surface err=error.OutOfMemory". Bump to 8x for more memory headroom.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR bumps the WarpBuild runner for the
Confidence Score: 5/5Safe to merge — single-line runner label bump with no logic changes. The change is minimal and targeted: one runner label substitution in one CI job. No code, test logic, or configuration beyond the runner size is altered. The other two macOS jobs that don't exhibit OOM are deliberately left on the smaller runner, which is correct. No P1/P0 issues found. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
PR[Pull Request / Push to main] --> WG[workflow-guard-tests\nubuntu-latest]
PR --> RD[remote-daemon-tests\nubuntu-latest]
PR --> WT[web-typecheck\nubuntu-latest]
PR --> T[tests\nwarp-macos-15-arm64-8x BUMPED]
PR --> TBL[tests-build-and-lag\nwarp-macos-15-arm64-6x]
PR --> UI[ui-regressions\nwarp-macos-15-arm64-6x]
T --> UT[Run unit tests\nTerminalControllerSocketSecurityTests\nno longer OOM]
TBL --> LAG[Lag regression\nnot OOM-affected]
UI --> UIR[UI regressions\nnot OOM-affected]
Reviews (1): Last reviewed commit: "Bump unit test CI runner to 8x to fix OO..." | Re-trigger Greptile |
Summary
TerminalControllerSocketSecurityTestsadded in Map Shift+Enter to raw newline in Ghostty #2355 cause ghostty surface allocation to OOM on the 6-core WarpBuild runner (error.OutOfMemory), failing 3 socket tests that were previously passing.testsjob runner fromwarp-macos-15-arm64-6xtowarp-macos-15-arm64-8xfor more memory headroom.Test plan
TerminalControllerSocketSecurityTestspassing (or at least no longer OOM-ing)Summary by cubic
Bump CI unit test runner from
warp-macos-15-arm64-6xtowarp-macos-15-arm64-8xto stop OOM failures in TerminalControllerSocketSecurityTests. This adds memory headroom for ghostty surface allocation so the three socket tests no longer fail.Written for commit a2647e6. Summary will update on new commits.
Summary by CodeRabbit
Note: This is an internal infrastructure change with no impact on product features or functionality.