Skip to content

cmux next: the Share cmux dialog is glass, solid only under Reduce Transparency - #24048

Merged
teamleaderleo merged 6 commits into
feat-cmux-nextfrom
glass-lens/share-dialog-glass
Oct 22, 2026
Merged

teamleaderleo merged 6 commits into
feat-cmux-nextfrom
glass-lens/share-dialog-glass

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Leo (2026-10-21): "glass is never opaque (the only exception is the Reduce Transparency fallback), and the accent is never orange."

The Share cmux dialog (app.shareCmux, from the Help menu and the palette) pinned its surface to .opaque. That pin dates from #19770 (2026-10-12), when every overlay with text used the solid popup surface. On 2026-10-18 the overlay panels went back to this Mac's material.

The dialog now builds its OverlaySurfaceView(interactive: true) with no pinned material. Like every overlay since #23801, it gets no card fill. It shows Liquid Glass (vibrancy before macOS 26, or in the Debug legacy-material mode). Only Reduce Transparency gets the solid popup surface.

PopupSurfaceCallersTests used to assert that the dialog keeps the solid surface. This PR changes existing behaviour, and Leo's words above are the reason.

Changelog

  • Changed: the Share cmux dialog is glass like the other overlays (solid under Reduce Transparency).

Test

PopupSurfaceCallersTests/theShareDialogIsGlassUnlessReduceTransparency, committed red first. It checks three things about the dialog's surface:

  • it pins no material;
  • it has no card fill;
  • its material is the one OverlayMaterial.select(liquidGlassAvailable: Glass.isLiquidGlassAvailable, reduceTransparency:) picks, the same selector PopupSurfaceTests uses.

Command: cmux-ci run --class light --script scripts/ci/package-test-lane.sh --arg suite --arg Packages/macOS/CmuxNext --arg PopupSurfaceCallersTests --ref <sha>

  • An earlier form of this test (a card, OverlayMaterial.current):
    • red at 88d62fe (fleet step e0d62ddb92148236ce23052f): materialOverride → .opaque, isCard → false, material → .opaque vs .liquidGlass;
    • green at cf90c44.
  • The current form: the red at 342412e (fleet step f414ac17) and the green at 793ef76 (below) are queued on the light pool, which has a backlog of about 300 jobs.

Observed / Not run

Observed:

  • The fleet red and green above, for the earlier form of the test.
  • cmux-ci compile-check --app passed at c39b598.
  • prepush-gate.py: no new violations.
  • An independent Codex (xhigh) review: it first returned BLOCK, because OverlayMaterial.current ignores the Debug legacy-material mode. 793ef76 fixed that, and the re-review returned SHIP.

Not run:

  • The current test form on the fleet (still queued).
  • A dogfood build.
  • Reduce Transparency, which I read in OverlayMaterial.select but did not drive.

No capture: cmux-ci capture needs a capture host that cmux16 can reach (cua-2 and cua-3: "SSH alias does not resolve here"), and cmux16 lacks the disk for a cmuxterm-hq checkout. The change removes one material pin, and the test above pins it.

Agent session: cmux16

🤖 Generated with Claude Code

@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 22, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by glass-lens on cmux16 · session

@blacksmith-sh

blacksmith-sh Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Found 11 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp9wadm_yi/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpsguyc1hf/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
nightly cmux-tui resolve/nightly cmux-tui resolve View Logs
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse
dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo
dules)/
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse
dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo
dules)
View Logs
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse
dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo
dules) (job='web-bundles')/
test_every_submodule_free_checkout_on_an_owned_runner_resets_submodules (main.Reuse
dWorkspaceSubmodules.test_every_submodule_free_checkout_on_an_owned_runner_resets_submo
dules) (job='web-bundles')
View Logs

...and 1 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 793ef76: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr24048 -f ref=glass-lens/share-dialog-glass -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 793ef76a7f; ci-status is green without them.

CI passes on 793ef76a7f (run 39742966519 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 1f4437e; does not block

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (claude-review-24048): SHIP at cf90c44

Base reds, not this PR's (it changes only ShareCmuxView.swift and its test): workflow-guard-tests (macOS job classes, media writers, determinism), the objc-selector rule at CEFFileDragRelay.swift:162, and the cmux-next checks aggregate (scroller and package-convention findings in other files).

@teamleaderleo
teamleaderleo marked this pull request as ready for review October 22, 2026 02:50
@cursor

cursor Bot commented Oct 22, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-1beek created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next crash-class rules / cmux-next crash-class rules is red on 13 of 13 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

teamleaderleo and others added 2 commits October 21, 2026 23:18
#23801 made every overlay glass with no card fill; the dialog's surface must not be a card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16
@cursor

cursor Bot commented Oct 22, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex xhigh via acpmux, correctness first): SHIP at 793ef76

The first pass found one blocker: the test compared against OverlayMaterial.current, which ignores the Debug legacy-material mode. 793ef76 fixed it by using the selector PopupSurfaceTests uses. The re-review found no other correctness, font, motion or namespace issues. The reviewer had no tools, so it built nothing, ran no tests and did not check legibility on screen.

@teamleaderleo
teamleaderleo merged commit cfe2165 into feat-cmux-next Oct 22, 2026
@teamleaderleo
teamleaderleo deleted the glass-lens/share-dialog-glass branch October 22, 2026 07:49
teamleaderleo added a commit that referenced this pull request Oct 22, 2026
…solid popup surface (#24309)

* test(next): Home's sheets and group info sheet are glass unless Reduce Transparency (red)

Leo, 2026-10-21: "glass is never opaque (the only exception is the Reduce
Transparency fallback)". The sheets still paint the solid popup surface.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16

* cmux next: Home's sheets and the group info sheet sit on overlay glass, not the solid popup surface

Leo, 2026-10-21: "glass is never opaque (the only exception is the Reduce
Transparency fallback)". New Message, Invite and New Chief (HomeSheetController)
and the group info sheet drew Palette.popupSurface under their content. Each now
puts an OverlaySurfaceView (this Mac's glass, no card fill, solid only under
Reduce Transparency) under its content, the same pattern as the Share dialog (#24048).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16

* cmux next: Home's sheet glass blurs the window behind the sheet on the vibrancy fallback

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 793ef76a Deployed Oct 22, 2026 by teamleaderleo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant