Repository navigation
cmux next: the Share cmux dialog is glass, solid only under Reduce Transparency - #24048
Conversation
… (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16
…ansparency Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16
|
Owned by glass-lens on cmux16 · session |
|
Found 11 test failures on Blacksmith runners: Failures
...and 1 more test failures. View all on Blacksmith
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 1f4437e; does not block |
|
Review (claude-review-24048): SHIP at cf90c44 Base reds, not this PR's (it changes only ShareCmuxView.swift and its test): workflow-guard-tests (macOS job classes, media writers, determinism), the objc-selector rule at CEFFileDragRelay.swift:162, and the cmux-next checks aggregate (scroller and package-convention findings in other files). |
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Bead |
|
|
#23801 made every overlay glass with no card fill; the dialog's surface must not be a card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16
…y overlay (#23801) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
…cts, legacy mode included Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16
|
Review (codex xhigh via acpmux, correctness first): SHIP at 793ef76 The first pass found one blocker: the test compared against |
…solid popup surface (#24309) * test(next): Home's sheets and group info sheet are glass unless Reduce Transparency (red) Leo, 2026-10-21: "glass is never opaque (the only exception is the Reduce Transparency fallback)". The sheets still paint the solid popup surface. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16 * cmux next: Home's sheets and the group info sheet sit on overlay glass, not the solid popup surface Leo, 2026-10-21: "glass is never opaque (the only exception is the Reduce Transparency fallback)". New Message, Invite and New Chief (HomeSheetController) and the group info sheet drew Palette.popupSurface under their content. Each now puts an OverlaySurfaceView (this Mac's glass, no card fill, solid only under Reduce Transparency) under its content, the same pattern as the Share dialog (#24048). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16 * cmux next: Home's sheet glass blurs the window behind the sheet on the vibrancy fallback Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c40-f08c-79b2-95af-689409622600&host=cmux16 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Shipped in:
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo (2026-10-21): "glass is never opaque (the only exception is the Reduce Transparency fallback), and the accent is never orange."
The Share cmux dialog (
app.shareCmux, from the Help menu and the palette) pinned its surface to.opaque. That pin dates from #19770 (2026-10-12), when every overlay with text used the solid popup surface. On 2026-10-18 the overlay panels went back to this Mac's material.The dialog now builds its
OverlaySurfaceView(interactive: true)with no pinned material. Like every overlay since #23801, it gets no card fill. It shows Liquid Glass (vibrancy before macOS 26, or in the Debug legacy-material mode). Only Reduce Transparency gets the solid popup surface.PopupSurfaceCallersTestsused to assert that the dialog keeps the solid surface. This PR changes existing behaviour, and Leo's words above are the reason.Changelog
Test
PopupSurfaceCallersTests/theShareDialogIsGlassUnlessReduceTransparency, committed red first. It checks three things about the dialog's surface:OverlayMaterial.select(liquidGlassAvailable: Glass.isLiquidGlassAvailable, reduceTransparency:)picks, the same selectorPopupSurfaceTestsuses.Command:
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --arg suite --arg Packages/macOS/CmuxNext --arg PopupSurfaceCallersTests --ref <sha>OverlayMaterial.current):materialOverride → .opaque,isCard → false,material → .opaquevs.liquidGlass;Observed / Not run
Observed:
cmux-ci compile-check --apppassed at c39b598.prepush-gate.py: no new violations.OverlayMaterial.currentignores the Debug legacy-material mode. 793ef76 fixed that, and the re-review returned SHIP.Not run:
OverlayMaterial.selectbut did not drive.No capture:
cmux-ci captureneeds a capture host that cmux16 can reach (cua-2 and cua-3: "SSH alias does not resolve here"), and cmux16 lacks the disk for a cmuxterm-hq checkout. The change removes one material pin, and the test above pins it.Agent session: cmux16
🤖 Generated with Claude Code