Repository navigation
fix(next): import cards never fall back to the system blue for their accent or focus ring - #23993
Conversation
…lue AccentColor The import suggestion cards (#22710) took AccentColor, the CSS system blue, as the last fallback for their accent, so an unthemed page drew a blue progress bar and a blue focus ring around a focused button. It also kept check-system-blue's "this checkout is within its baseline" test red on feat-cmux-next. The fallback is now the cards' own text ink. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16027-99fc-73f0-9482-5a4babfe1b0a&host=cosmic-gray Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 47ae435 to compare; do not merge until green; see lane-rules Tour of Gallery before/after for
States
Pick other states with a |
|
Owned by composer-look on cosmic-gray · session |
|
Found 9 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
|
Review (independent subagent, correctness first): SHIP at 11204bd
|
|
Shipped in:
|
Leo-ask: ask-901f6e99da
Leo-ask: ask-f8d7fe1c14 (the "blue focus ring constantly appearing" part)
Leo saw a blue ring pulse around a response and a blue ring that kept appearing in the agent pane. The response ring itself is already off by default on base: #22678 made an agent chat's pane ring in the notification blue when its turn ends, and #23754 (merged) made that ring opt-in (Debug
notifications.attention.agentTurnRing, default false) and a neutral hairline when it is on.The remaining system blue in this sweep is the import suggestion cards (#22710), shown on Home, New Tab and Settings. Root cause:
webviews/src/ui/importCards.css:8set--import-accent: var(--agent-accent, var(--cmux-accent, AccentColor)). On a page without theme tokens, that fell through toAccentColor, the CSS system blue. The card's progress bar and the focus outline on.import-card-button:focus-visible(line 184) then drew in system blue. The same line keptcheck-system-blue > this checkout is within its baselinered on feat-cmux-next. The fallback is now the cards' own text ink (--import-text). Themed pages are unchanged.Changelog
Test
cd webviews && CMUX_BROWSER_TESTS=1 bun test test/check-system-blue.test.ts test/no-system-blue.test.ts(huge-blue)check-system-blue > this checkout is within its baseline(webviews/src/ui/importCards.css: 1 system-accent or blue literals, baseline 0).bun run checkpasses.Observed / Not run
No capture: webview-only change; a gallery compare is not useful, because every gallery theme sets the accent tokens and this path is only reached without them.
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes import suggestion cards drawing blue accents on unthemed pages. The card's accent previously fell back to the CSS system color
AccentColorwhen no page theme tokens were present, so the progress bar and focus ring rendered in system blue; the fallback is now the cards' own text ink. Themed pages are unchanged.Written for commit 11204bd. Summary will update on new commits.