Repository navigation
Agent chat: link chips never grow when their title loads; tighter PR hover card with state pills - #23746
Conversation
…le loads (red) [#22896](…/pull/22896) grew inline into "#22896 · cmux-next updates: …" once the page title came in, reflowing the paragraph. These fail on the base: the chip's text and icon must not change after metadata arrives. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1602e-25ea-7611-8c79-d16df0c4058f&host=cosmic-gray
…irst draws A pull request chip no longer appends its title (cv-chip__title), and a bare address no longer swaps to the site's title and favicon once cmux learns them. Both now show only in the hover card, so a hover or a late lookup never widens the chip and reflows the reply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1602e-25ea-7611-8c79-d16df0c4058f&host=cosmic-gray
…base-red checks Leo: "the styling/layout/spacing could be a bit better". The card's head is one compact row: the favicon or GitHub mark inline beside the title (a pull request's own title, cut to two lines), then Open and Open in. A pull request card drops the github.com address footer; a web link keeps its masked address under the title. One 12px inset and 8px between rows. The state is a pill tinted in its colour (open green, merged purple, closed red). Checks whose failures all fail on the base branch read muted "N failing (base)"; some of them read "N failing, M on base". The pr.inspect answer gains an optional failingOnBase, which the host does not send yet. Gallery: merged-with-base-reds and closed pull request states. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1602e-25ea-7611-8c79-d16df0c4058f&host=cosmic-gray
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Unclear: CI failed on
Not re-run automatically: Written by red: web / Web status; base red: the same failure on the base cc945e2; does not block
Agents: Tour of |
|
Owned by inline-media on cosmic-gray · session |
|
Bead |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1602e-25ea-7611-8c79-d16df0c4058f&host=cosmic-gray
|
Found 3 test failures on Blacksmith runners: Failures
|
…act checks) Leo, on a #22826 card: no state word and no pill. The state is the pull request glyph's colour alone, as Claude draws it (open green, merged purple, closed red, draft grey); the word stays as the glyph's accessible name. Open and Open in are quiet borderless buttons with a hover background, the card is tighter (8px/10px inset, 6px rows, no divider), a web card's address sits under its title only when it says more than the host, and "+N −M" has no dotted underline. An open pull request's checks are a compact "✓ 90 ✗ 10" (◷ for running ones) with base's "(N already on base)" note, the ✗ muted when every red is also red on base; a finished pull request shows no checks line and no conflicts. The card stays on the tooltip's glass tokens. This also clears the agent-pane-no-capsules red: the 999px state pill is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1602e-25ea-7611-8c79-d16df0c4058f&host=cosmic-gray
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
# Conflicts: # webviews/src/agent-session/acpmux/chips/LinkHoverCard.tsx # webviews/src/agent-session/acpmux/styles.css
Base #23477 moved the link card onto .ui-glass, so the card rule sets no fill; the test now pins the ui-glass class and the glass token fallback instead of the old tooltip background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a1602e-25ea-7611-8c79-d16df0c4058f&host=cosmic-gray
|
Review (subagent, correctness first): SHIP at b8cddc9
|
Base redesigned the pull request card (#23746); the owner/repo#N link moves onto its new facts row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Two fixes to GitHub link chips and their hover card in agent replies, from Leo's review of the chat.
A chip never grows when its title loads. After Leo hovered
[#22896](…), the chip grew inline from#22896to#22896 · cmux-next updates: pulled-build banner (…)and reflowed the paragraph. A chip's text and icon are now fixed when it first draws. A PR chip no longer appends the title, and a bare address no longer swaps to the site's title and favicon once cmux has them. Titles and favicons live only in the hover card. Tests:link-cards.test.tsxhas four new cases. They fail on base (6 pass / 4 fail) and pass with the fix; one of them checks the chip's HTML is unchanged after the store gets the title.The hover card, per Leo's spec.
checks.failingOnBaseandcheckList[].onBase).+905 −50..ui-glass, from cmux NEXT: composer, messages, menus, cards and the Inspector are liquid glass #23477), never an opaque fill.Takes back #23644: Leo's card spec replaces the open PR's checks list with small ✓/✗ counts and hides checks on merged and closed PRs. #23644's base-red data (
checks.failingOnBase,checkList[].onBase) is kept and drives the muted ✗.Gallery:
url-chipvariantspull-request,pull-request-merged-base-redsandpull-request-closed.Observed / Not run
bun run checkpasses.cmux-ci compile-check --apppassed.pr-hover-card.test.tsxstill asserting the old tooltip background after cmux NEXT: composer, messages, menus, cards and the Inspector are liquid glass #23477 moved the card to.ui-glass. The test now pins theui-glassclass and the glass token fallback.No capture: webview-only UI; the gallery advisory run captures it.
Changelog
Changed: GitHub link chips in agent replies keep their size when titles load, and their hover card is quieter: state by glyph colour, borderless buttons, check counts only on open PRs.
🤖 Generated with Claude Code
Agent session: cosmic-gray