Skip to content

ci(owned-pool rescue): stop watching the shim and fuzz workflows - #23736

Merged
teamleaderleo merged 1 commit into
mainfrom
cmux/ci-side-paths-drop-moved
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
cmux/ci-side-paths-drop-moved

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Merged (4d404b3): part of the ci-linux-move lane, which takes CI jobs that don't need macOS off the Mac runners.

Summary

Removes two workflows from SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py. Neither takes an owned mini any more, so the rescue has nothing of theirs to move:

Since #23719, tests/test_ci_owned_pool_sources.py has printed a stale-entry warning for both. With this change the warnings go away.

Testing

Both pass against feat-cmux-next at 2b77cb0, with no stale-entry warning:

  • python3 tests/test_ci_owned_pool_rescue.py
  • python3 tests/test_ci_owned_pool_sources.py

Observed / Not run

  • Observed: the two tests above.
  • Not run: scripts/cmux-next/prepush-gate.py doesn't exist on main.

Changelog

none

Risk: low. CI-only: two entries removed from the rescue's list.

Agent session: cmux16

🤖 Generated with Claude Code

cmux-next-shim-cpp.yml runs on Blacksmith Linux since #23712, and
macos-matrix-fuzz.yml was retired in #23725, so neither takes an owned
mini any more.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16020-82b9-7501-8b24-24eafedababb&host=cmux16
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by ci-linux-move on cmux16 · session

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c92c8894-76f3-4d6c-9896-653ff84c00f8
📥 Commits

Reviewing files that changed from the base of the PR and between c8f69a0 and 6bfb1f4.

📒 Files selected for processing: 1
  • scripts/ci/owned_pool_rescue.py
💤 Files with no reviewable changes: 1
  • scripts/ci/owned_pool_rescue.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

SIDE_WORKFLOW_PATHS no longer includes .github/workflows/cmux-next-shim-cpp.yml or .github/workflows/macos-matrix-fuzz.yml. Other side-lane workflow entries remain.

Changes: Side-workflow paths

Layer / File(s) Summary
Update side-workflow entries
scripts/ci/owned_pool_rescue.py
SIDE_WORKFLOW_PATHS removes the entries for cmux-next-shim-cpp.yml and macos-matrix-fuzz.yml. Other entries remain.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 6bfb1

The change removes obsolete workflow entries without affecting workflows present at the reviewed head. It is ready to merge after normal checks.

Pre-merge checks: Passed 25
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: removing the shim and fuzz workflows from owned-pool rescue monitoring.
Description check Passed The description explains the problem, changed behavior, affected workflows, test commands, results, and unverified coverage. It includes Summary, Testing, Observed / Not run, and Changelog sections. I…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input Passed PASS: The pull request changes only two entries in SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py. It does not change Cloud terminal creation, cmux-tui transport, manual panes, input routi…
Cmux Swift Actor Isolation Passed The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI script. It removes two workflow-path entries and introduces no production Swift code or Swift actor-isolation behavior.
Cmux Swift Blocking Runtime Passed The pull request changes only scripts/ci/owned_pool_rescue.py, removing two workflow paths from a Python set. The reviewed diff contains no Swift or runtime synchronization changes.
Cmux Browser Automation Off-Main Passed The pull request changes only scripts/ci/owned_pool_rescue.py and removes two workflow-path entries. It does not change browser socket commands, ControlCommandExecutionPolicy, WebKit/AppKit access…
Cmux Expensive Synchronous Load Passed PASS: The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI file. The diff removes two workflow-path entries and adds no Swift code or synchronous agent-history load. The custom…
Cmux Cache Substitution Correctness Passed PASS: The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI script, and removes two workflow path entries. It does not change production Swift, TypeScript, or JavaScript code, a…
Cmux No Hacky Sleeps Passed PASS: The pull request only removes two workflow-path entries from SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py. The diff introduces no sleep, timer, polling, delayed dispatch, or wall-c…
Cmux Algorithmic Complexity Passed The PR only removes two string entries from SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py. It adds no loops, scans, sorting, filtering, joins, or other algorithmic work. The change does n…
Cmux Swift Concurrency Passed The pull request changes only scripts/ci/owned_pool_rescue.py. The diff removes two workflow-path entries and contains no Swift files or Swift concurrency APIs. Therefore, it does not introduce or e…
Cmux Swift @Concurrent Passed PASS: The pull request changes only scripts/ci/owned_pool_rescue.py and contains no Swift files or Swift code. The cmux Swift @concurrent criteria do not apply.
Cmux Swift Package Boundaries Passed The pull request changes only the Python CI file scripts/ci/owned_pool_rescue.py. It makes no production Swift changes, so the Swift package-boundaries rule does not apply.
Cmux Swiftpm Lockfiles Passed PASS: The PR changes only scripts/ci/owned_pool_rescue.py by removing two workflow-path strings from SIDE_WORKFLOW_PATHS. It does not change a .gitignore, Package.swift, Package.resolved, Xc…
Cmux Swift Logging Passed PASS. The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI script. It removes two workflow-path entries and adds or changes no Swift logging, file logging, or diagnostic output…
Cmux User-Facing Error Privacy Passed PASS: The PR changes only the internal CI rescue script by removing two workflow paths from SIDE_WORKFLOW_PATHS. The diff adds or changes no user-facing errors, alerts, command output, API bodies, o…
Cmux Full Internationalization Passed PASS: The PR changes only the CI rescue configuration in scripts/ci/owned_pool_rescue.py, removing two workflow path tokens. It introduces no user-facing Swift, web, metadata, API, markdown, changel…
Cmux Swiftui State Layout Passed The pull request changes only scripts/ci/owned_pool_rescue.py and removes two workflow-path entries. It contains no SwiftUI changes, so the SwiftUI state-layout failure conditions do not apply.
Cmux Architecture Rethink Passed PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. It removes two workflow paths from a Python frozenset; it does not change Swift code or introduce any listed architectural patt…
Cmux Swift Auxiliary Window Close Shortcuts Passed PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. It removes two workflow-path entries and contains no Swift changes or window declarations. The auxiliary-window close-shortcut ru…
Cmux Source Artifacts Passed The PR changes only scripts/ci/owned_pool_rescue.py, a hand-written CI source script. The diff removes two stale workflow-path entries and adds no logs, caches, generated output, scratch directories…
Cmux No Test Or Debug Seam In Production Source Passed PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. It introduces no Swift file changes under a production Sources/ path, so it cannot introduce a test or debug seam covered by th…
Full details: Description check

Explanation

The description explains the problem, changed behavior, affected workflows, test commands, results, and unverified coverage. It includes Summary, Testing, Observed / Not run, and Changelog sections. It omits the template's Proof and Checklist sections, but the description remains sufficiently complete for this CI-only change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Cmux Cloud Persistent Session And Early Input

Explanation

PASS: The pull request changes only two entries in SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py. It does not change Cloud terminal creation, cmux-tui transport, manual panes, input routing, readiness gates, or auth and lease handling.

Full details: Cmux Browser Automation Off-Main

Explanation

The pull request changes only scripts/ci/owned_pool_rescue.py and removes two workflow-path entries. It does not change browser socket commands, ControlCommandExecutionPolicy, WebKit/AppKit access, worker routing, or policy tests. The browser automation failure conditions are not applicable.

Full details: Cmux Expensive Synchronous Load

Explanation

PASS: The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI file. The diff removes two workflow-path entries and adds no Swift code or synchronous agent-history load. The custom check does not apply.

Full details: Cmux Cache Substitution Correctness

Explanation

PASS: The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI script, and removes two workflow path entries. It does not change production Swift, TypeScript, or JavaScript code, and it does not substitute a cached value for an authoritative read in a persistence, history, undo, or snapshot path.

Full details: Cmux No Hacky Sleeps

Explanation

PASS: The pull request only removes two workflow-path entries from SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py. The diff introduces no sleep, timer, polling, delayed dispatch, or wall-clock wait. Existing timing code is unchanged, so the custom check's failure condition is not introduced or worsened.

Full details: Cmux Algorithmic Complexity

Explanation

The PR only removes two string entries from SIDE_WORKFLOW_PATHS in scripts/ci/owned_pool_rescue.py. It adds no loops, scans, sorting, filtering, joins, or other algorithmic work. The change does not introduce or worsen any complexity condition in the rule.

Full details: Cmux Swift Concurrency

Explanation

The pull request changes only scripts/ci/owned_pool_rescue.py. The diff removes two workflow-path entries and contains no Swift files or Swift concurrency APIs. Therefore, it does not introduce or expand any legacy Swift async pattern.

Full details: Cmux Swiftpm Lockfiles

Explanation

PASS: The PR changes only scripts/ci/owned_pool_rescue.py by removing two workflow-path strings from SIDE_WORKFLOW_PATHS. It does not change a .gitignore, Package.swift, Package.resolved, Xcode project package references, or dependency files. Therefore, no SwiftPM lockfile rule failure condition is introduced.

Full details: Cmux Swift Logging

Explanation

PASS. The pull request changes only scripts/ci/owned_pool_rescue.py, a Python CI script. It removes two workflow-path entries and adds or changes no Swift logging, file logging, or diagnostic output.

Full details: Cmux User-Facing Error Privacy

Explanation

PASS: The PR changes only the internal CI rescue script by removing two workflow paths from SIDE_WORKFLOW_PATHS. The diff adds or changes no user-facing errors, alerts, command output, API bodies, or recovery copy, and it establishes no path to a cmux end user.

Full details: Cmux Full Internationalization

Explanation

PASS: The PR changes only the CI rescue configuration in scripts/ci/owned_pool_rescue.py, removing two workflow path tokens. It introduces no user-facing Swift, web, metadata, API, markdown, changelog, or locale content, so the full-internationalization rule does not apply.

Full details: Cmux Architecture Rethink

Explanation

PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. It removes two workflow paths from a Python frozenset; it does not change Swift code or introduce any listed architectural pattern.

Full details: Cmux Swift Auxiliary Window Close Shortcuts

Explanation

PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. It removes two workflow-path entries and contains no Swift changes or window declarations. The auxiliary-window close-shortcut rule does not apply.

Full details: Cmux Source Artifacts

Explanation

The PR changes only scripts/ci/owned_pool_rescue.py, a hand-written CI source script. The diff removes two stale workflow-path entries and adds no logs, caches, generated output, scratch directories, or other artifacts.

Full details: Cmux No Test Or Debug Seam In Production Source

Explanation

PASS: The pull request changes only scripts/ci/owned_pool_rescue.py. It introduces no Swift file changes under a production Sources/ path, so it cannot introduce a test or debug seam covered by this check.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Independent review of 6bfb1f4 by a claude subagent:

  • On feat-cmux-next, neither removed workflow can take an owned pool any more. macos-matrix-fuzz.yml is deleted (ci: retire the nightly macOS matrix fuzz with Tart #23725), and cmux-next-shim-cpp.yml runs only on Linux labels (ci(shim-cpp): run the CEF shim C++ tests on Blacksmith Linux #23712). Nothing else on main references either entry.
  • These pass on the head: test_ci_owned_pool_rescue (163), test_ci_owned_pool_sources (7, with no stale-entry warning), classify_failures, late_placement, simple_pool_picker, workflow_run_sources and test_run_e2e.
  • test_ci_change_areas.py (test_ci_script_only_change_skips_the_cli_lane_but_keeps_linux_guards) also fails on base origin/main, so it is a base red and not caused by this PR.

Review (claude subagent): SHIP at 6bfb1f4

@teamleaderleo
teamleaderleo merged commit 4d404b3 into main Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/ci-side-paths-drop-moved branch October 21, 2026 21:14
@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Merge receipt for 6bfb1f4c75, merged 2026-10-21 21:14:38 UTC

  • Not verified at merge: CI fast guards (in progress), guards (8) (in progress)
  • Verified: backend migrations applied, ci-status, CI timing, Fast static checks, GhosttyKit release check, merge freeze, plan, web-validation
  • Skipped by policy: apply-production, apply-staging, browser, Claude wrapper regressions, close lapsed freezes, Dogfood build #​${{ github.event.pull_request.number }}, linux-preflight, macos, macOS admission gate, remote-daemon, suite-coverage, ui-tests, and 4 more
  • Full suite: runs on main after merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant