Repository navigation
cmux NEXT: Pin or Unpin Chat reads Pin/Unpin Chat; the toggle-style test covers every action - #23722
Conversation
…le style (red) PaletteMenuVocabularyTests checked the X/Y toggle style only on palette actions, so the keyboard-only sidebar.chat.togglePin kept "Pin or Unpin Chat", which Keyboard Shortcuts settings shows. The toggle rule now covers every catalog action; red on that title. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bd2-60d2-70e1-8179-d3aa717c8828&host=cosmic-gray
…yle everywhere else sidebar.chat.togglePin (#22323) kept "Pin or Unpin Chat" while every other toggle reads X/Y; it is keyboard-only, so Keyboard Shortcuts settings showed it. All 21 locales follow their Pin/Unpin Chat in Priority… wording; the row's right-click menu still says Pin or Unpin by the chat's state. plans/cmux-next/action-surfaces.json is generated; PR autofix regenerates it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bd2-60d2-70e1-8179-d3aa717c8828&host=cosmic-gray
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by web and size checks: green |
|
Bead |
|
Owned by summary-panel on cosmic-gray · session |
|
Found 3 test failures on Blacksmith runners: Failures
|
Palette: Show or Hide Actions and Developer Tools: Start or Stop Performance Recording slipped past the start-anchored pattern. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bd2-60d2-70e1-8179-d3aa717c8828&host=huge-blue
…ding, the toggle style Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bd2-60d2-70e1-8179-d3aa717c8828&host=huge-blue
|
Review (subagent, correctness first): SHIP at dda71d6
|
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
sidebar.chat.togglePin, added in #22323, is still titled "Pin or Unpin Chat". Every other toggle reads X/Y ("Pin/Unpin"). The action is keyboard-only and the palette never shows it, soPaletteMenuVocabularyTestsdidn't check it. Its title does show in Keyboard Shortcuts settings.everyActionTitleUsesOneToggleStyleapplies the toggle rule to every catalog action on any surface: no "X or Y …", no "Toggle Group…". It is red on that title. TheClearandHiderules stay palette-only.plans/cmux-next/action-surfaces.jsonstill has the old title. PR autofix regenerates it, so it isn't hand-edited here.This goes with #23708 (the Priority row actions' chat picker). Both come from the follow-ups to #23527.
Testing
cmux-next swift testrunsPaletteMenuVocabularyTests.everyActionTitleUsesOneToggleStyle:sidebar.chat.togglePin Pin or Unpin Chat. The result will be added to this PR.A search of every action-title key in the sources finds no other "X or Y" title and no "Toggle Group" title.
Observed / Not run
prepush-gate.py, no new violations. The xcstrings catalog parses as JSON and only that one entry changed.Changelog
Changed: The Pin or Unpin Chat shortcut reads Pin/Unpin Chat in Keyboard Shortcuts settings, like the other toggles.
🤖 Generated with Claude Code
Agent session: cosmic-gray
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Retitles the cmux NEXT catalog's remaining old-style toggles to read X/Y instead of "X or Y", and widens the toggle-style test to catch titles that only surface in Keyboard Shortcuts settings or carry a prefix.
everyActionTitleUsesOneToggleStylenow covers every catalog action on any surface and matches after a title's prefix.sidebar.chat.togglePin(Pin/Unpin Chat), Palette: Show/Hide Actions, and Developer Tools: Start/Stop Performance Recording, in all 21 locales.plans/cmux-next/action-surfaces.jsonis regenerated by PR autofix.Written for commit dda71d6. Summary will update on new commits.