Skip to content

cmux NEXT: Pin or Unpin Chat reads Pin/Unpin Chat; the toggle-style test covers every action - #23722

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
cmux/toggle-title-everywhere
Oct 22, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
cmux/toggle-title-everywhere

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

sidebar.chat.togglePin, added in #22323, is still titled "Pin or Unpin Chat". Every other toggle reads X/Y ("Pin/Unpin"). The action is keyboard-only and the palette never shows it, so PaletteMenuVocabularyTests didn't check it. Its title does show in Keyboard Shortcuts settings.

  • Test, committed first: everyActionTitleUsesOneToggleStyle applies the toggle rule to every catalog action on any surface: no "X or Y …", no "Toggle Group…". It is red on that title. The Clear and Hide rules stay palette-only.
  • Fix: the title becomes "Pin/Unpin Chat". All 21 locales follow the wording each one already uses for "Pin/Unpin Chat in Priority…". The chat row's right-click menu still says Pin or Unpin, based on the chat's state.
  • Generated file: plans/cmux-next/action-surfaces.json still has the old title. PR autofix regenerates it, so it isn't hand-edited here.

This goes with #23708 (the Priority row actions' chat picker). Both come from the follow-ups to #23527.

Testing

cmux-next swift test runs PaletteMenuVocabularyTests.everyActionTitleUsesOneToggleStyle:

  • Base, plus the test commit e75c9ef: expected red on sidebar.chat.togglePin Pin or Unpin Chat. The result will be added to this PR.
  • The fix head: expected green. The result will be added to this PR.

A search of every action-title key in the sources finds no other "X or Y" title and no "Toggle Group" title.

Observed / Not run

  • Ran: prepush-gate.py, no new violations. The xcstrings catalog parses as JSON and only that one entry changed.
  • Not run locally: the Swift tests, which a hook blocks on this Mac. They run on this PR's CI.

Changelog

Changed: The Pin or Unpin Chat shortcut reads Pin/Unpin Chat in Keyboard Shortcuts settings, like the other toggles.

🤖 Generated with Claude Code

Agent session: cosmic-gray


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Retitles the cmux NEXT catalog's remaining old-style toggles to read X/Y instead of "X or Y", and widens the toggle-style test to catch titles that only surface in Keyboard Shortcuts settings or carry a prefix.

  • everyActionTitleUsesOneToggleStyle now covers every catalog action on any surface and matches after a title's prefix.
  • Fixes sidebar.chat.togglePin (Pin/Unpin Chat), Palette: Show/Hide Actions, and Developer Tools: Start/Stop Performance Recording, in all 21 locales.
  • The chat row's right-click menu still says Pin or Unpin, based on the chat's state.
  • plans/cmux-next/action-surfaces.json is regenerated by PR autofix.

Written for commit dda71d6. Summary will update on new commits.

View guided diff Turn on auto-fix

teamleaderleo and others added 2 commits October 21, 2026 13:36
…le style (red)

PaletteMenuVocabularyTests checked the X/Y toggle style only on palette
actions, so the keyboard-only sidebar.chat.togglePin kept "Pin or Unpin Chat",
which Keyboard Shortcuts settings shows. The toggle rule now covers every
catalog action; red on that title.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bd2-60d2-70e1-8179-d3aa717c8828&host=cosmic-gray
…yle everywhere else

sidebar.chat.togglePin (#22323) kept "Pin or Unpin Chat" while every other
toggle reads X/Y; it is keyboard-only, so Keyboard Shortcuts settings showed
it. All 21 locales follow their Pin/Unpin Chat in Priority… wording; the row's
right-click menu still says Pin or Unpin by the chat's state.
plans/cmux-next/action-surfaces.json is generated; PR autofix regenerates it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bd2-60d2-70e1-8179-d3aa717c8828&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review dda71d6: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23722 -f ref=cmux/toggle-title-everywhere -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on dda71d613c; ci-status is green without them.

CI passes on dda71d613c (run 39700213752 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

web and size checks: green

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-7lh4y created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by summary-panel on cosmic-gray · session

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
nightly cmux-tui resolve/nightly cmux-tui resolve View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs
test_the_tree_classifies_every_macos_job (main.RoutingTableTests.test_the_tree_clas
sifies_every_macos_job)/
test_the_tree_classifies_every_macos_job (main.RoutingTableTests.test_the_tree_clas
sifies_every_macos_job)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Palette: Show or Hide Actions and Developer Tools: Start or Stop Performance
Recording slipped past the start-anchored pattern.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bd2-60d2-70e1-8179-d3aa717c8828&host=huge-blue
@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Oct 22, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, correctness first): SHIP at dda71d6

  • A first review blocked because the start-anchored pattern let "Palette: Show or Hide Actions" and "Developer Tools: Start or Stop Performance Recording" through. Fixed: the pattern is now (?:^|: )\w+ or \w+ , and both titles are renamed in every locale. The re-review found no other action title matching, and no false match on "Palette: Clear or Close" or "Next Tab or Workspace".
  • Red: PaletteMenuVocabularyTests failed only everyActionTitleUsesOneToggleStyle at e75c9ef (fleet step fdf91e4222af8135d6e34546).
  • Fleet cmux-ci compile-check --app passed at dda71d6 (job 01289c849318b684d58b78f9).

@teamleaderleo
teamleaderleo merged commit fc8ddd0 into feat-cmux-next Oct 22, 2026
@teamleaderleo
teamleaderleo deleted the cmux/toggle-title-everywhere branch October 22, 2026 00:34
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — dda71d61 Deployed Oct 22, 2026 by teamleaderleo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant