Repository navigation
Hold Home on a first launch until its conversation is in - #23704
Conversation
A cold launch showed Home in pieces (the empty-workspace title, then the second column and cards, then the header, actions and message box over about 1.9 s). Adds the `.home` launch region (markAllReady covers it) and tests that a Home with no pane yet stays clear until its conversation's first page is in. Fails until the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Passes: CI passes on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 44fc3d3 to compare; do not merge until green; see lane-rules Tour of Path-selected interactions
Chief front page and settings (before): DEGRADED — 4 ok, 2 unavailable
Screenshots (5)1. Launch
Screenshots (5)1. Launch
Screenshots (15)1. Launch
Screenshots (15)1. Launch Tours are data in |
|
Owned by an agent session · session |
|
Bead |
|
|
A Home with no pane yet is still being made (its dock's page tab, then the Chief conversation, over several daemon replies). Its workspace content now stays clear until HomeHostView's first page is in, so a cold launch shows Home settled instead of the empty-workspace title, then the second column and cards, then the header and message box. A restored Home and other workspaces are not held; the launch deadline still caps the wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
Review of the fix: the 1.5 s launch deadline is armed by the first hold (the sidebar's, at the window) and releases every region, so a Home made at 3049 ms was already ready and its hold did nothing. Fails until Home gets a deadline of its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
The launch deadline is armed by the window's first hold and releases every region at once, so a Home held after it had fired was never released by it. LaunchRegion.hasOwnDeadline marks .home; its deadline runs from its own first hold, and markAllReady cancels it with the others. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
The first-page task marked .home ready even after its view was gone, so a Home torn down while its page was pending could reveal a new Home before that Home's own page arrived. The task now returns when the view is gone or the task was cancelled (deinit cancels it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
|
Found 7 test failures on Blacksmith runners: Failures
|
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Orphaned: no activity for 15 h, and no lane holds a lease on it. Adopted by the orphan sweep: merged |
|
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b3e7ee61a5723b96272a
|
|
A Home held alone restarts .home's deadline instead of joining the one a closed Home armed, and a torn-down workspace leaves the held views. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-b3e7ee61a5723b96272a
|
|
|
Review (codex gpt-6-astra xhigh): SHIP at a627c8a Independent different-model review (Codex gpt-6-astra, xhigh, read-only in a checkout of this head, on the PR's own three-dot diff). The review at e40e653 returned FIX FIRST: a Home that replaced a closed one joined the closed Home's Adopted from the gone window-focus-opacity lane. Earlier commits on this head: one clean merge of feat-cmux-next, and the missing |
|
base-red-watch: |
|
Shipped in:
|












































![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Part of Leo's never-blank first launch frame. A cold launch recording (DEV build of the feat tip, 60 fps) showed Home arriving in pieces: the home workspace's "Start something new" title at 3049 ms, then the second column and import cards, then the header, first-run actions and message box at about 4978 ms. Home is made over several daemon replies (
ensure_home, the dock's page tab, then the Chief conversation), and no launch region held it.Change
.home(Home's conversation's first page).markAllReadyand the 1.5 s deadline cover it like the others.WorkspaceContentControllerholds a Home that has no pane yet until.homeis ready. A Home restored with its dock is not held, nor is any other workspace.HomeHostViewmarks.homeready when its first page is in (the same point the first-run panel stops waiting). An offline or refused owner ends that wait too, so Home shows its notice instead of staying clear.Test
HomeLaunchRevealTests, red on the test-only head and green with the fix:.home, then draws;HomeHostViewmarks.homeready once its first page is in.No capture: this holds Home clear until its first page is in during a cold launch; a capture tour shows the settled Home, which looks the same before and after.
HomeLaunchRevealTestspins the hold and release.Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Holds a first-launch Home until its conversation's first page is in, so the launch frame no longer shows Home arriving in pieces (the empty-workspace title at ~3 s, then the header and message box at ~5 s).
.homelaunch region thatmarkAllReadycovers like the other regions.WorkspaceContentControllerholds a Home that has no pane yet until.homeis ready; other workspaces and a Home restored with its dock are not held.HomeHostViewmarks.homeready when its first page is in, or when an offline or refused owner ends the wait so Home shows its notice instead of staying clear. A Home released before its page came no longer marks.home, so it can't reveal the Home that replaced it..homewaits its own deadline from its first hold..homereveal timing.Tests
HomeLaunchRevealTestscovers a pane-less Home staying hidden until.home, a pane-less non-Home workspace not being held,HomeHostViewmarking.homeready on first page arrival, and a later-held Home waiting its own deadline.Written for commit 52ffa8c. Summary will update on new commits.