Repository navigation
cmux NEXT Chief Settings: this Mac's Chief stays local beside a hosted cloud Chief (tests) - #23689
Conversation
…ief (tests) Covers Leo's 2026-10-21 report that this Mac's Chief's card said "Runs in the cloud" and "The server with this Chief is not connected." with empty pickers: with a hosted and a placed cloud Chief in the cloud list, this Mac's Chief (and a named local Chief) keeps the local engine, the "Runs on this Mac" line and pickers filled from its engine.json. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba3-d09a-7940-9fd6-158e10477c0e&host=cosmic-gray
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Passes: CI passes on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 90037fe to compare; do not merge until green; see lane-rules |
|
Owned by claude-sr2/transcript-density on cosmic-gray · session |
|
Found 11 test failures on Blacksmith runners: Failures
...and 1 more test failures. View all on Blacksmith
|
The guard tests now list this Mac's Chief conversation (with agent_mux) and a named local Chief in the Home store as the local owner reports them, owned here and titled "Chief" like the hosted and placed cloud Chiefs, so a classification by name would turn them red. The store runs on its own temporary Chief home. Drops two checks the equality checks already cover. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ba3-d09a-7940-9fd6-158e10477c0e&host=cosmic-gray
|
Bead |
|
Review (independent review subagent, transcript-density lane): SHIP at 2e76420
|
|
Review (subagent, correctness first): SHIP at 68b6355 Independent re-review after the autolander's base merge: the merge (parents ef054f8, 90037fe) is clean with no hand-resolved hunks, the PR still changes only |
|
Shipped in:
|
|
Review (codex gpt-6.1-sol): SHIP at 68b6355 Blocking findings: none. Non-blocking findings: none. These are guard tests, as the body states; they do not reproduce the original popover failure or exercise conversation selection through HomeChiefName.select. Checked: all 124 added lines, fixture event replay and Chief-home resolution, local/hosted/remote engine selection, host-line construction, and settings-card reads against the production implementations; git diff --check passed. No builds or test suites run. Re-read the PR head before posting; it is unchanged. |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Leo reported that the Chief name-pill card on this Mac's Chief said "Runs in the cloud" and "The server with this Chief is not connected." and left the Harness, Model and Effort pickers empty. The only test for this Mac's Chief (
thisMacsChiefStaysLocal) ran with no cloud Chiefs listed, so it could not catch a local Chief being treated as a cloud one.These are guard tests, not a red-then-green repro. The base already passes them, and no product code changes. The text Leo saw matches what the card did before #22602 (merged 2026-10-21 03:19 UTC, 69b018a): it sent every cloud Chief, including the hosted one, through
HomeChiefRemoteEngine, and that engine says "The server with this Chief is not connected." when it has no server. When signed in, the Chief tab shows the hosted cloud Chief, which is also named "Chief" (HomeCloudChiefs.chiefTab), so the card Leo opened was probably that Chief's, on a build from before #22602. These tests lock in the local side, and #22602's tests cover the hosted side.Each new test in
HomeChiefHostedSettingsTestslists a hosted cloud Chief and a Chief placed on a server, both named "Chief". It also puts this Mac's Chief conversation (withagent_mux) and a named local Chief's conversation into the Home store the way the local owner reports them: owned locally and also titled "Chief". So a change that classified Chiefs by name would turn these tests red. The store runs on a temporary Chief home (CMUX_NEXT_CHIEF_HOME), so its cache never touches a real Chief's.thisMacsChiefStaysLocalBesideAHostedCloudChief: this Mac's Chief is not a cloud conversation and getsHomeChiefLocalEngineand the default brain home.chiefHost(of:)gives it no place line and no switch. The two cloud Chiefs still get the hosted and remote engines.aNamedLocalChiefStaysLocalBesideTheCloudChiefs: a named local Chief (chief-brains-v1) also stays local, on its ownc/<id>brain home.thisMacsChiefsCardRunsHereWithItsPickers: the card is built the wayHomeHostViewbuilds it (host line, thenuse(engineSource())). It shows "Runs on this Mac" with no switch and no error, the Harness row is visible, and the pickers are enabled and show this Mac'sengine.json(codex / gpt-5.5 / high).Testing
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --ref 2e764209837695e5a2e455c62ebfabb1dfeefc77 --arg=suite --arg=Packages/macOS/CmuxNext --arg=HomeChiefHostedSettingsTests --key chief-local-stays-local-tests-2e7642098376: step f4d36e5d0a877e438085e9e6 on aws-m4pro-5 passed, 12 of 12 tests including the 3 new ones.cmux-ci compile-check --ref 2e764209837695e5a2e455c62ebfabb1dfeefc77 --app: job 0d077af3b89555e030fb9ca3 passed.python3 scripts/cmux-next/prepush-gate.py: no new violations.Observed / Not run
Observed: the fleet suite run and the app compile above, both on the head. The first commit (9042aa1) also passed the suite, in step b3e7b6959704720251dd2ae1.
Not run:
HomeChiefName.selectreadsHomeService.conversations(the daemon list,private(set)). The tests can't put a conversation there, but nothing on the card's classification path reads it.Changelog
none
Proof
No capture: this PR only adds tests.
Agent session: cosmic-gray
🤖 Generated with Claude Code