Skip to content

cmux-next: fix the two Chief title reds from #23391 - #23636

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
chief-sidebar-2/chief-title-reds
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
chief-sidebar-2/chief-title-reds

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes two base reds that came in with #23391 (reported by chief-sidebar):

  • ChiefWorkspaceRowsTests.theTaskTitleDropsOnlyASubagentID: ChiefWorkspaceName.taskTitle trimmed blanks on both ends before looking for the aN · id, so "a3 · " became "a3 ·", the " · " match failed, and it returned "a3 ·" instead of nil. It now drops only the leading blanks before the match; the trailing ones still go after.
  • ChiefSidebarItemTests.dedupedSessionNamesKeepTheirRoleAndNumber: the test still expected the internal a3 / a10 ids as row titles. cmux-next sidebar: the Chief's workspaces read like any workspace (no aN id, no Chief line) #23391 hides those ids on purpose (Leo's ask), and an untitled lane reads "Subagent". The test now gives the lanes task titles and checks that they keep their subagent-number order.

Example failing run: https://github.com/manaflow-ai/cmux/actions/runs/39635743092/job/119347539209

No capture: a string helper and a test, with no visible change beyond the "a3 · " edge case.

Agent session: cosmic-gray

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes two Chief title test failures that came in with #23391.

  • ChiefWorkspaceName.taskTitle now drops only leading whitespace before matching the subagent id, so "a3 · " keeps its " · " marker and no longer returns "a3 ·" instead of nil.
  • The deduped-session test now gives lanes task titles and checks their subagent-number order, instead of expecting the internal a3/a10 ids as row titles.

Written for commit 8c9b083. Summary will update on new commits.

View guided diff Turn on auto-fix

taskTitle trimmed trailing blanks before looking for the id, so "a3 · "
lost its " · " and came back as "a3 ·"; it now drops only the leading
blanks first. The deduped-session test still expected the internal a3 /
a10 ids as row titles; it now gives the lanes task titles and checks
their order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-9c97-76c3-88d7-6d0422d2fadc&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 8c9b083: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23636 -f ref=chief-sidebar-2/chief-title-reds -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 8c9b0834f2; ci-status is green without them.

CI passes on 8c9b0834f2 (run 39656483087 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c7626f2 to compare; do not merge until green; see lane-rules

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by chief-sidebar-2 on cosmic-gray · session

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 9 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpf4rsoynj/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpo7bjrf8u/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)/
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)
View Logs
test_a_shared_module_selects_its_dependents (main.PullRequestTiers.test_a_shared_mo
dule_selects_its_dependents)/
test_a_shared_module_selects_its_dependents (main.PullRequestTiers.test_a_shared_mo
dule_selects_its_dependents)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-ncjbo created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent, correctness first): SHIP at 8c9b083. Reds are not this PR's: cmux-next checks is red on base pushes too (crash-safety ratchet, tier routing), and crash-class rules flags HomeSidebarSplitView+Drop.swift:11, a base file this PR does not touch.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was successfully deployed

2 inactive deployments
artifacts — 8c9b0834 Deployed Oct 21, 2026 by teamleaderleo
sentry-dsyms — 8c9b0834 Deployed Oct 21, 2026 by teamleaderleo
ci-routing-agent — 8c9b0834 Deployed Oct 21, 2026 by teamleaderleo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant