Repository navigation
cmux-next: fix the two Chief title reds from #23391 - #23636
Conversation
taskTitle trimmed trailing blanks before looking for the id, so "a3 · " lost its " · " and came back as "a3 ·"; it now drops only the leading blanks first. The deduped-session test still expected the internal a3 / a10 ids as row titles; it now gives the lanes task titles and checks their order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-9c97-76c3-88d7-6d0422d2fadc&host=cosmic-gray
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c7626f2 to compare; do not merge until green; see lane-rules |
|
Owned by chief-sidebar-2 on cosmic-gray · session |
|
Found 9 test failures on Blacksmith runners: Failures
|
|
Bead |
|
Review (subagent, correctness first): SHIP at 8c9b083. Reds are not this PR's: cmux-next checks is red on base pushes too (crash-safety ratchet, tier routing), and crash-class rules flags HomeSidebarSplitView+Drop.swift:11, a base file this PR does not touch. |
|
Shipped in:
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes two base reds that came in with #23391 (reported by chief-sidebar):
ChiefWorkspaceRowsTests.theTaskTitleDropsOnlyASubagentID:ChiefWorkspaceName.taskTitletrimmed blanks on both ends before looking for theaN ·id, so"a3 · "became"a3 ·", the" · "match failed, and it returned"a3 ·"instead of nil. It now drops only the leading blanks before the match; the trailing ones still go after.ChiefSidebarItemTests.dedupedSessionNamesKeepTheirRoleAndNumber: the test still expected the internala3/a10ids as row titles. cmux-next sidebar: the Chief's workspaces read like any workspace (no aN id, no Chief line) #23391 hides those ids on purpose (Leo's ask), and an untitled lane reads "Subagent". The test now gives the lanes task titles and checks that they keep their subagent-number order.Example failing run: https://github.com/manaflow-ai/cmux/actions/runs/39635743092/job/119347539209
No capture: a string helper and a test, with no visible change beyond the "a3 · " edge case.
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes two Chief title test failures that came in with #23391.
ChiefWorkspaceName.taskTitlenow drops only leading whitespace before matching the subagent id, so"a3 · "keeps its" · "marker and no longer returns"a3 ·"instead of nil.a3/a10ids as row titles.Written for commit 8c9b083. Summary will update on new commits.