Skip to content

Chief views: "Terminal" is the de, es and fr word too (localization ratchet base red) - #23629

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/l10n-terminal-invariant
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/l10n-terminal-invariant

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the cmux-next localization debt ratchet red on feat-cmux-next.

#22683 (Chief view gallery) landed ten minutes before the ratchet (#23463), after its baseline was recorded. It added chiefViews.terminal.untitled with "Terminal" in de, es and fr, which the parity check counts as copied English: ChiefViews.xcstrings: identical 0 -> 3. "Terminal" is the standard word in all three, so this documents it in scripts/localization-allowed-omissions.json, in the same form as argument.appStore.tab. It doesn't raise the baseline, which only goes down.

python3 scripts/localization_catalog.py check

  • base c425696: exit 1, "localization debt grew past localization-debt-baseline.json … ChiefViews.xcstrings: identical 0 -> 3"
  • this head: exit 0, "131 catalogs, 9 locales: 42457 parity errors, within the debt baseline"

Observed / Not run

  • Ran: the check above at base and head, tests/test_localization_catalog.py, tests/test_localize_changes.py.
  • Not run: nothing else; this only adds a metadata entry.

Changelog

none

Agent session: huge-blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the localization debt ratchet red on feat-cmux-next by recording chiefViews.terminal.untitled as an allowed omission. The Chief views gallery added "Terminal" as the German, Spanish, and French translation, which the parity check counted as copied English. "Terminal" is the standard UI word in all three locales, so it's documented in scripts/localization-allowed-omissions.json as an invariant instead of raising the debt baseline, which only goes down.

Written for commit 9b65d85. Summary will update on new commits.

View guided diff Turn on auto-fix

…atchet base red)

#22683 added chiefViews.terminal.untitled with "Terminal" in de, es and fr, which the
parity check reads as copied English. It is the standard word in all three, so it is
documented as an invariant beside argument.appStore.tab instead of raising the debt
baseline (#23463), which only goes down.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d72-348e-7bd1-9c4e-4c3519d0f0fc&host=huge-blue
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by omnibox-auto-2 on huge-blue · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by omnibox-auto-2 on huge-blue · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent-subagent): SHIP at 9b65d85

  • Diff against feat-cmux-next is only the new chiefViews.terminal.untitled entry in scripts/localization-allowed-omissions.json, and the file still parses as JSON.
  • The entry has the same shape as argument.appStore.tab. source is "Terminal", which matches the English value in ChiefViews.xcstrings. identityLocales gives de, es and fr each a non-empty reason string, which is what identity_allowed in scripts/localization_catalog.py needs.
  • The word is right. "Terminal" is the standard term in German (das Terminal), Spanish (el terminal) and French (le terminal), and Apple ships Terminal.app under that name in all three locales. Several other locales in the catalog (da, nb, pl, pt-BR, tr, bs) use the same word.
  • python3 scripts/localization_catalog.py check exits 0 ("within the debt baseline"; it prints only needs_review notes for the Feed and Home catalogs, which this PR doesn't touch). python3 tests/test_localization_catalog.py: 39 tests OK.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-he9vo created for this PR by the cmux coordinator.

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 9b65d85: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23629 -f ref=cmux/l10n-terminal-invariant -f platform=macos -f backend_mode=local

@teamleaderleo
teamleaderleo merged commit c7626f2 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/l10n-terminal-invariant branch October 21, 2026 18:51
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant