Repository navigation
Chief views: "Terminal" is the de, es and fr word too (localization ratchet base red) - #23629
Merged
Merged
Conversation
…atchet base red) #22683 added chiefViews.terminal.untitled with "Terminal" in de, es and fr, which the parity check reads as copied English. It is the standard word in all three, so it is documented as an invariant beside argument.appStore.tab instead of raising the debt baseline (#23463), which only goes down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d72-348e-7bd1-9c4e-4c3519d0f0fc&host=huge-blue
Collaborator
Author
|
Owned by omnibox-auto-2 on huge-blue · session |
Collaborator
Author
|
Owned by omnibox-auto-2 on huge-blue · session |
Collaborator
Author
|
Review (independent-subagent): SHIP at 9b65d85
|
Collaborator
Author
|
Bead |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Contributor
|
Shipped in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
cmux-next localization debt ratchetred on feat-cmux-next.#22683 (Chief view gallery) landed ten minutes before the ratchet (#23463), after its baseline was recorded. It added
chiefViews.terminal.untitledwith "Terminal" in de, es and fr, which the parity check counts as copied English:ChiefViews.xcstrings: identical 0 -> 3. "Terminal" is the standard word in all three, so this documents it inscripts/localization-allowed-omissions.json, in the same form asargument.appStore.tab. It doesn't raise the baseline, which only goes down.python3 scripts/localization_catalog.py checkObserved / Not run
tests/test_localization_catalog.py,tests/test_localize_changes.py.Changelog
none
Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the localization debt ratchet red on
feat-cmux-nextby recordingchiefViews.terminal.untitledas an allowed omission. The Chief views gallery added "Terminal" as the German, Spanish, and French translation, which the parity check counted as copied English. "Terminal" is the standard UI word in all three locales, so it's documented inscripts/localization-allowed-omissions.jsonas an invariant instead of raising the debt baseline, which only goes down.Written for commit 9b65d85. Summary will update on new commits.