Skip to content

webviews: frame-paced waits in stream-jitter, minimap-feel and new-tab-composer-still - #23602

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
scroll-jitter-2/fixed-waits-scroll
Oct 21, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
scroll-jitter-2/fixed-waits-scroll

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Takes the agent-pane scroll and motion tests I own off fixed waits, onto painted frames and DOM conditions:

  • agent-pane-stream-jitter (8 → 0): after a turn ends the tests wait for its footer to be the chat's last row (ended) and for the view to rest (rest, 6 painted frames with scrollTop held and nothing gliding) instead of sleeping 600–800 ms. The deleted-queued-prompt tests now time, from the first painted frame without the queue card, how long until the last row rests over the stack again (watchGap), against the same deadlines: under 300 ms when idle, and under 600 ms plus the 180 ms glide while a tool runs (the old 600 ms sleep followed by gapAbove, which waits out the glide). Dropped a stale fixed-wait comment on open().
  • thread-minimap-feel (1 → 0): the band test wheels once per painted frame instead of every 8 ms.
  • new-tab-composer-still (5 → 0): after each state the walk waits for the page to hold still (settled, 10 painted frames with no DOM change and nothing animating, setting aside the Now Playing player's progress, which ticks every second).

The three rows leave fixed-waits-baseline.tsv. None of these files is touched by #23584, #23585 or #23586.

Runs on cmux16 (each run covers every engine the file runs in):

  • agent-pane-stream-jitter, chromium + webkit: 5/5 at 83f9449 and 5/5 at the merged head 62c5ff9 (18 tests each)
  • thread-minimap-feel, chromium: 5/5 (4 tests each)
  • new-tab-composer-still, chromium + webkit: 5/5 (10 tests each)

Neither of these two files changed after the review fix, and base didn't touch either one.

Agent session: cmux16

🤖 Generated with Claude Code

…b-composer-still

The agent pane's stream-jitter tests wait for the turn's footer and a
resting view instead of fixed sleeps, and the deleted-prompt tests time
how long after the card leaves the last row rests over the stack again,
against the same deadlines. thread-minimap-feel wheels once per painted
frame; new-tab-composer-still waits for the page to hold still after
each state. The fixed-waits baseline drops all three files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-f5e3-77e3-a3e6-159012f35d5f&host=cmux16
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by scroll-jitter-2 on cmux16 · session

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review bb7e8e7: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23602 -f ref=scroll-jitter-2/fixed-waits-scroll -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base d0119cd; does not block

Tour of bb7e8e76cc (run): no media. The tour did not run: only webview code changed (4 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-lkyjm created for this PR by the cmux coordinator.

@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 9 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpm9lah2k7/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpyqypdcbx/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)/
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)
View Logs
test_a_shared_module_selects_its_dependents (main.PullRequestTiers.test_a_shared_mo
dule_selects_its_dependents)/
test_a_shared_module_selects_its_dependents (main.PullRequestTiers.test_a_shared_mo
dule_selects_its_dependents)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next guards / cmux-next localization debt ratchet is red on 15 of 16 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

…er-2/fixed-waits-scroll

# Conflicts:
#	webviews/scripts/fixed-waits-baseline.tsv
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent subagent review, scroll-jitter-2 on cmux16): SHIP at bb7e8e7. I re-reviewed after both base merges, including the fixed-waits baseline conflict resolution (base's file minus the three converted rows). Local runs at this head, cmux16: stream-jitter 5/5 (chromium + webkit), thread-minimap-feel 5/5 (chromium), new-tab-composer-still 5/5 (chromium + webkit). The only reds are the localization debt ratchet (ChiefViews.xcstrings, which came in with base) and its aggregator.

@teamleaderleo
teamleaderleo merged commit a5d932d into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the scroll-jitter-2/fixed-waits-scroll branch October 21, 2026 19:07
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant