[teamleaderleo]

Summary

A file the person drops into a chat is saved by name under acpmux's uploads folder (_acpmux/file_put, #23324). On Windows, a name such as CON, nul.txt, COM1.log, CONIN$, or one ending in a dot or a space, does not name a file in that folder: it opens a device, or the name is silently changed. is_file_name now refuses these names on Windows, the same way it already refused \ and : there.

• The stem is the part before the first dot, with trailing spaces trimmed and compared case-insensitively. A stem of CON, PRN, AUX, NUL, CONIN$ or CONOUT$ is refused.
• COM or LPT followed by exactly one of 1-9, ¹, ² or ³ is refused.
• A name ending in . or is refused.
• Names that only look similar are kept: CONSOLE.txt, COM10, COM0, nullable.rs, aux_data.csv, LPT.

Other platforms are unchanged. The check sits behind is_file_name_for(name, windows), so the Windows rules can be tested on Linux.

Testing

Focused command: cmux-tui.yml dispatch, mode=focused. The new test is hub::file_uploads::tests::a_windows_device_name_is_no_file_name_on_windows.

• Red at c13a48c, the test commit (run 39633604233, filter windows_device_name): it fails to compile because is_file_name_for doesn't exist yet. The test calls the Windows rules directly, so before this change there was nothing to call.
• Green at 59b868b (run 39633616267, filter file): all four file_uploads tests pass, the new one included.
• cargo check --target x86_64-pc-windows-gnu passes (run 39633630080).

Observed / Not run

• Observed: the red and green runs above. In the green run, the only other reds are already red on base and unrelated to this change:
  • clippy redundant clone in cmux-tui-core;
  • MSRV could not fetch the cmux-codex-acp git dependency;
  • cli::tests::action_surface_parity::pane_open_files_and_find_as_run_their_actions_with_a_path, which the file filter picked up.
• Not run: a real Windows file save. Only the name check is tested.

Changelog

Fixed: a file dropped into a chat on Windows can no longer be saved under a device name such as CON or NUL.

No capture: daemon-only change with no UI.

Agent session: cosmic-gray

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes acpmux file saving on Windows so names like CON, NUL, COM1, or names ending in a dot or space are rejected, instead of opening a device or getting silently renamed.

• Adds a Windows-only device-name check covering CON, PRN, AUX, NUL, COM1-9, LPT1-9, CONIN$, and CONOUT$ with any extension, plus trailing-dot and trailing-space names.
• Refactors the name check into is_file_name_for(name, windows) so the Windows rules can be tested on any platform. Other platforms are unchanged.

^{Written for commit 59b868b. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 59b868b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23562 -f ref=acpmux-file-put-device-names -f platform=macos -f backend_mode=local

[teamleaderleo]

Owned by attachments-matrix on cosmic-gray · session

[teamleaderleo]

Owned by attachments-matrix on cosmic-gray · session

[teamleaderleo]

Bead cx-cl4pq created for this PR by the cmux coordinator.

[teamleaderleo]

Review (independent subagent, correctness first): SHIP at 59b868b

• The Win32 rules match Windows' behavior, the same rules as Python 3.13's os.path.isreserved. Other platforms are unchanged, and the Swift pre-check needs no change.
• Nits not taken: refusing COM0/LPT0 as well (Windows opens them as ordinary files), and to_ascii_uppercase.
• Checks at this head: no failures. The cancelled runs are superseded attempts. Release compile is still queued on the Mac runners; this PR touches no Swift.

[github-actions]

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.3964654862801 (06af62206e)
• cmux NEXT nightly 1.0.0-nightly.3964891628801 (3e20ec6b96)
• cmux NEXT nightly 1.0.0-nightly.3965027402001 (6bc437994c)
• cmux NEXT nightly 1.0.0-nightly.3965153006601 (a10158f013)