Repository navigation
cmux NEXT tests: resting in the hover slot needs no timer to show no card (base red) - #23550
Conversation
…card The slot beside a workspace row starts no hover card any more (the row's hover stops short of the sidebar's margin), so restingInTheSlotShowsNoCard failed on waitForSleeper before it could check that no card shows. It waits out the delay only when a card is pending. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ce6-07ef-7c43-8bd7-9f20d4c93180&host=cosmic-gray
|
Owned by browser-pip on cosmic-gray · session |
|
Bead |
|
Review (subagent, correctness first): SHIP at 4cba4a7
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by Tour of |
|
Shipped in:
|
Base red:
SidebarHoverCardEscapeTests/restingInTheSlotShowsNoCardfails onfeat-cmux-next. The error is atSidebarHoverCardEscapeTests.swift:133:Caught error: no timer went to sleep on the manual clock within 2.5 s.The test rests the pointer in the empty slot beside a workspace row. It expects no hover card to show after the hover delay. The test came from #22473, when that point still started a hover timer: the sidebar margin hit-tested as the row, and the slot logic refused the card when the timer fired. Since then the row's hover stops short of the margin, so the slot starts no card and no timer at all. That is the behaviour the test wants. But the test called
clock.waitForSleeper()first, and that throws when no timer sleeps. So it failed before it could check that no card shows.The fix is in the test only. It waits out the delay only when a card is pending (
coordinator.machine.activeTarget != nil), and checks that no card shows either way.Changelog
none
Testing
Focused command:
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --ref <sha> --label ci-steps --label suites --arg suite --arg Packages/macOS/CmuxNext --arg SidebarHoverCardEscapeTestsrestingInTheSlotShowsNoCardfails at :133 with the error above; the other 6 tests pass.There is no separate failing-test commit: the red is the existing test on base.
Observed / Not run
GroupHeaderNewWorkspaceTestspasses at e9590e0, after c6bb043, so it is not part of this PR.No capture: test-only change, no UI changes.
🤖 Generated with Claude Code
Agent session: cosmic-gray
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes
SidebarHoverCardEscapeTests.restingInTheSlotShowsNoCardonfeat-cmux-next, which failed because it calledclock.waitForSleeper()when the slot now starts no hover timer at all. The test now waits out the hover delay only when a card is pending (coordinator.machine.activeTarget != nil) and checks that no card shows either way.Testing
e9590e04: the test fails withno timer went to sleep on the manual clock; the other 6 tests pass.4cba4a75: all 7 tests pass.Written for commit 4cba4a7. Summary will update on new commits.