Skip to content

cmux NEXT sidebar: the Chief item wears the chosen pet character - #23547

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
cmux/chief-sidebar-avatar
Oct 21, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
cmux/chief-sidebar-avatar

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

The sidebar's Chief item (the optional chief built-in, Add to Sidebar) drew the generic sparkles glyph. It now draws the Chief's avatar: the picture of the pet character picked in home.chiefPetMascot, the same whole-character avatar the Home header wears for a Chief with no picture of its own. An unknown or unset id draws the orb, as Home does.

How: SidebarBridge.itemInfo sets the Chief item's favicon to that picture (ChiefSidebarPicture, one cached image per character so the same pick compares equal and does not redraw the row). favicon is the field every sidebar look already draws untinted in the glyph's place (row, inline chip, tile, icon-only), so the sidebar view code is unchanged. The sections observation in SidebarBridge.observeSections now also reads settings.snapshot.homeChiefPetMascot, so picking another character in Settings > Chief or the Chief Settings popover redraws the item live.

Observed / Not run

  • Red then green on the fleet (ChiefSidebarItemTests.theChiefItemWearsTheChosenPetCharacter): red at the test commit 102d9f7 (fleet step d224f42f2e103cdeb974fecb: failed with 3 issues, the favicon was nil), green at the fix commit cfe3af6 (fleet step 83591676e3e704698f4a2d5f, 8/8 passed).
  • prepush-gate.py: no new violations. crash_ratchet.py reports cmux-tui-core: expect 283 -> 285, which is the same on base 90b5da8 (Rust only; this PR changes none).
  • Release compile (fleet-compile-check run 39633812303): success.
  • Overlap: cmux-next sidebar: the Chief's workspaces read like any workspace (no aN id, no Chief line) #23391 shares only the test file ChiefSidebarItemTests.swift (different tests). cmux-next sidebar: the Chief's workspaces are one collapsible Chief group #23546 (Chief workspaces group) edits SidebarLayout.swift, SidebarListView+Reuse.swift, SidebarRowIndex.swift and ChiefWorkspaceName.swift; this PR touches none of them nor the Chief workspace rows.
  • Not run: a full local build (no Swift builds on this machine); CI compiles it.

Proof: the capture below adds the Chief to the sidebar, then sets home.chiefPetMascot to fox and then moon-blue while the app runs; the final stills show the sidebar's Chief item wearing moon-blue, the same character as the Home header (no relaunch).

Capture steps-d7fe8c8990 at cfe3af61de48 (fleet build, capture mini, text checked for private data)

Light Dark
light dark

Agent session: cosmic-gray

🤖 Generated with Claude Code

teamleaderleo and others added 2 commits October 21, 2026 09:09
The Chief built-in drew the generic sparkles glyph. It now draws the picture of the
character picked in home.chiefPetMascot (the same avatar the Home header wears for a
Chief with none of its own), as the item's untinted glyph in every look, and the
sidebar's sections observation follows the setting so a new pick redraws it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a45c-7f43-a883-a2389c4766e5&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by chief-pet-avatars on cosmic-gray · session

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review c09f07f: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23547 -f ref=cmux/chief-sidebar-avatar -f platform=macos -f backend_mode=local

Pending: CI is running on c09f07fe5f (run); the result below was for cfe3af61de and no longer applies.

Last result: Not verified: macOS jobs did not run: compile and app tests were skipped on cfe3af61de; ci-status is green without them.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); it is rewritten when this head's CI completes.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on a95a5d2 to compare; do not merge until green; see lane-rules

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-n5742 created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 9 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpkeog52c4/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpmhk2kb5z/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)/
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)
View Logs
test_a_shared_module_selects_its_dependents (main.PullRequestTiers.test_a_shared_mo
dule_selects_its_dependents)/
test_a_shared_module_selects_its_dependents (main.PullRequestTiers.test_a_shared_mo
dule_selects_its_dependents)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39694828930 at 5a17c63 failed: cmux-next fast tier.
Those jobs last passed at 3cd9d4f. This pull request is one of 4 merged since: #23824, #23805, #23790, #23547.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

This branch was previously deployed

1 inactive deployment
ci-routing-agent — c09f07fe Deployed Oct 21, 2026 by teamleaderleo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant