Repository navigation
cmux NEXT sidebar: the Chief item wears the chosen pet character - #23547
Conversation
…aracter Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a45c-7f43-a883-a2389c4766e5&host=cosmic-gray
The Chief built-in drew the generic sparkles glyph. It now draws the picture of the character picked in home.chiefPetMascot (the same avatar the Home header wears for a Chief with none of its own), as the item's untinted glyph in every look, and the sidebar's sections observation follows the setting so a new pick redraws it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a45c-7f43-a883-a2389c4766e5&host=cosmic-gray
|
Owned by chief-pet-avatars on cosmic-gray · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Pending: CI is running on Last result: Not verified: macOS jobs did not run: compile and app tests were skipped on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on a95a5d2 to compare; do not merge until green; see lane-rules |
|
Bead |
…ef-sidebar-avatar
|
Found 9 test failures on Blacksmith runners: Failures
|
|
The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39694828930 at 5a17c63 failed: cmux-next fast tier. |
|
Shipped in:
|
The sidebar's Chief item (the optional
chiefbuilt-in, Add to Sidebar) drew the generic sparkles glyph. It now draws the Chief's avatar: the picture of the pet character picked inhome.chiefPetMascot, the same whole-character avatar the Home header wears for a Chief with no picture of its own. An unknown or unset id draws the orb, as Home does.How:
SidebarBridge.itemInfosets the Chief item'sfaviconto that picture (ChiefSidebarPicture, one cached image per character so the same pick compares equal and does not redraw the row).faviconis the field every sidebar look already draws untinted in the glyph's place (row, inline chip, tile, icon-only), so the sidebar view code is unchanged. The sections observation inSidebarBridge.observeSectionsnow also readssettings.snapshot.homeChiefPetMascot, so picking another character in Settings > Chief or the Chief Settings popover redraws the item live.Observed / Not run
ChiefSidebarItemTests.theChiefItemWearsTheChosenPetCharacter): red at the test commit 102d9f7 (fleet step d224f42f2e103cdeb974fecb: failed with 3 issues, the favicon was nil), green at the fix commit cfe3af6 (fleet step 83591676e3e704698f4a2d5f, 8/8 passed).prepush-gate.py: no new violations.crash_ratchet.pyreportscmux-tui-core: expect 283 -> 285, which is the same on base 90b5da8 (Rust only; this PR changes none).Proof: the capture below adds the Chief to the sidebar, then sets
home.chiefPetMascotto fox and then moon-blue while the app runs; the final stills show the sidebar's Chief item wearing moon-blue, the same character as the Home header (no relaunch).Capture
steps-d7fe8c8990atcfe3af61de48(fleet build, capture mini, text checked for private data)Agent session: cosmic-gray
🤖 Generated with Claude Code