Repository navigation
test(webviews): dock gutters covers the running-work tray, not the agents pill - #23526
Merged
Merged
Conversation
…ents pill #23104 replaced the agents pill with the tray of running work (on by default) after #23243 landed this file, so the file's setup waited for a pill that never shows and hit the runner's 120 s limit on every run. The file now waits for the tray, expects it in the stack's order, and checks it as the dictation notice: the stack's gutter beside it passes through and scrolls the transcript, the tray takes the pointer and the wheel over it scrolls nothing. The pill's own list test goes with the pill. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
Collaborator
Author
|
Owned by composer-scroll on cosmic-gray · session |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Tour of |
Contributor
|
Shipped in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-pane-dock-gutters.test.ts(added by #23243) timed out on every run at the base tip. #23104 replaced the agents pill with the tray of running work (on by default) and landed after #23243, so the file's setup waited for.acpmux-agents-pill, which never shows, until the runner's 120 s limit.The file now covers the tray instead:
.acpmux-running-trayand expects it in the stack's order.agentPane.debug.subagentTrayoff.Test-only; no product code changes.
Changelog
none
Testing
Command:
scripts/ci/run-webviews-tests.shwithCMUX_WEB_TEST_FILES=test/agent-pane-dock-gutters.test.ts, as a fleet step (cmux-ci run --class light).agent-pane-wheel-pass-through.test.ts, on the same papercut fixture, passes (step 85ac2bfb8591ab761bb94c9d).Observed / Not run
scripts/web-lint.sh,bun scripts/check-fixed-waits.tsandprepush-gate.pypass locally.Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes
agent-pane-dock-gutters.test.tstiming out on every run by covering the running-work tray instead of the agents pill..acpmux-agents-pill, which no longer appears since the tray replaced the pill (on by default), so every run hit the 120 s limit..acpmux-running-tray, expects it in the stack's order, and checks the tray's gutter pass-through and no-scroll behavior like the dictation notice.agentPane.debug.subagentTrayoff.Test-only; no product code changes.
Written for commit efb2f6c. Summary will update on new commits.