Skip to content

test(webviews): dock gutters covers the running-work tray, not the agents pill - #23526

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/dock-gutters-tray
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/dock-gutters-tray

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

agent-pane-dock-gutters.test.ts (added by #23243) timed out on every run at the base tip. #23104 replaced the agents pill with the tray of running work (on by default) and landed after #23243, so the file's setup waited for .acpmux-agents-pill, which never shows, until the runner's 120 s limit.

The file now covers the tray instead:

  • It waits for .acpmux-running-tray and expects it in the stack's order.
  • It checks the tray like the dictation notice. The tray is its own box inset by its margin, so the stack's gutter beside it passes the pointer through and the wheel there scrolls the transcript. The tray takes the pointer, and the wheel over it scrolls nothing.
  • The pill's own list test goes with the pill. The pill shows only with Debug Settings agentPane.debug.subagentTray off.

Test-only; no product code changes.

Changelog

none

Testing

Command: scripts/ci/run-webviews-tests.sh with CMUX_WEB_TEST_FILES=test/agent-pane-dock-gutters.test.ts, as a fleet step (cmux-ci run --class light).

  • Base tip 2dff5e5: 10 of 10 runs TIMEOUT (limit 120s), retries alone included, with no test finished (for example step 378d613c08e4c1b1e1a2fd27). The first CI sighting was acpmux: agent-to-agent messages show their sender; sub-sessions show in the transcript and summary #22827's shard 2, which timed out the same way.
  • Control at the same tip: agent-pane-wheel-pass-through.test.ts, on the same papercut fixture, passes (step 85ac2bfb8591ab761bb94c9d).
  • Head efb2f6c: PASS in 4 of 4 finished fleet runs (steps ccab26ef6c6068fc6aeac1a8, da38e4c71f1d273af0b4cb57, d26724cc895f9583339d4e5e, a22252f6c50c0550b331973b); a fifth was still queued at merge.

Observed / Not run

Agent session: cosmic-gray

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes agent-pane-dock-gutters.test.ts timing out on every run by covering the running-work tray instead of the agents pill.

  • The setup waited for .acpmux-agents-pill, which no longer appears since the tray replaced the pill (on by default), so every run hit the 120 s limit.
  • Waits for .acpmux-running-tray, expects it in the stack's order, and checks the tray's gutter pass-through and no-scroll behavior like the dictation notice.
  • Removes the pill's list test, as the pill now shows only with agentPane.debug.subagentTray off.

Test-only; no product code changes.

Written for commit efb2f6c. Summary will update on new commits.

View guided diff

…ents pill

#23104 replaced the agents pill with the tray of running work (on by default) after #23243 landed
this file, so the file's setup waited for a pill that never shows and hit the runner's 120 s
limit on every run. The file now waits for the tray, expects it in the stack's order, and checks
it as the dictation notice: the stack's gutter beside it passes through and scrolls the
transcript, the tray takes the pointer and the wheel over it scrolls nothing. The pill's own
list test goes with the pill.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15bf1-fdc7-79b0-b869-8ac78b0edd90&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by composer-scroll on cosmic-gray · session

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review efb2f6c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23526 -f ref=cmux/dock-gutters-tray -f platform=macos -f backend_mode=local

Tour of efb2f6c0b1 (run): no media. The tour did not run: only webview code changed (1 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo
teamleaderleo merged commit 5214602 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/dock-gutters-tray branch October 21, 2026 15:46
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant