Skip to content

fix(cmux-next): the Files rename field draws no focus ring (base red check:text-focus) - #23466

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/file-explorer-focus-ring
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/file-explorer-focus-ring

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

check:text-focus fails on base (webviews/ bun run check, and so scripts/web-lint.sh on every PR). It flags FileExplorerCell.swift:65. 56488d6 made the Files row's name label editable and selectable for Rename but didn't set focusRingType = .none, so the rename field draws a focus ring. The rule says a text field shows focus through its caret instead.

The fix adds name.focusRingType = .none in the cell's init. python3 scripts/cmux-next/check-text-focus-rings.py failed before the change and passes after it ("no focus ring on a text field"). pr-overlap --rev HEAD found no open PR that touches this file. The Swift compile and tests run on CI; I didn't build the Mac app here.

No capture: the only visible change is that no focus ring is drawn around the Files row's inline Rename field. No capture scene or tour puts a row into Rename, and the line copies what AddressBarView.swift and SidebarItemRowView.swift already set on their editable fields.

Agent session: huge-blue

🤖 Generated with Claude Code

56488d6 made the name label editable for Rename without focusRingType = .none,
so check:text-focus fails on base.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 83f497e: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23466 -f ref=fix/file-explorer-focus-ring -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 83f497e654; ci-status is green without them.

CI passes on 83f497e654 (run 39617315836 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

Tour of 83f497e654 (run): no media. The tour job failed before the tour ran (build or setup); the run log has the output.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-ue9ki created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next guards / defaults-snapshot is red on 20 of 21 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by window-focus-opacity on huge-blue · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent): SHIP at 83f497e. CI: check:text-focus passes, the Swift canary compiled the change, and the capture check passes with a No-capture reason. Not this PR's: defaults-snapshot (base), and Release compile / Swift canary (build fleet), which were cancelled on every attempt rather than failing.

@teamleaderleo
teamleaderleo merged commit f6f2b45 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the fix/file-explorer-focus-ring branch October 21, 2026 15:39
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant