Repository navigation
fix(cmux-next): the Files rename field draws no focus ring (base red check:text-focus) - #23466
Conversation
56488d6 made the name label editable for Rename without focusRingType = .none, so check:text-focus fails on base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by Tour of |
|
Bead |
|
|
|
Owned by window-focus-opacity on huge-blue · session |
|
Review (subagent): SHIP at 83f497e. CI: check:text-focus passes, the Swift canary compiled the change, and the capture check passes with a No-capture reason. Not this PR's: defaults-snapshot (base), and Release compile / Swift canary (build fleet), which were cancelled on every attempt rather than failing. |
|
Shipped in:
|
check:text-focusfails on base (webviews/bun run check, and soscripts/web-lint.shon every PR). It flagsFileExplorerCell.swift:65. 56488d6 made the Files row's name label editable and selectable for Rename but didn't setfocusRingType = .none, so the rename field draws a focus ring. The rule says a text field shows focus through its caret instead.The fix adds
name.focusRingType = .nonein the cell's init.python3 scripts/cmux-next/check-text-focus-rings.pyfailed before the change and passes after it ("no focus ring on a text field").pr-overlap --rev HEADfound no open PR that touches this file. The Swift compile and tests run on CI; I didn't build the Mac app here.No capture: the only visible change is that no focus ring is drawn around the Files row's inline Rename field. No capture scene or tour puts a row into Rename, and the line copies what
AddressBarView.swiftandSidebarItemRowView.swiftalready set on their editable fields.Agent session: huge-blue
🤖 Generated with Claude Code