Skip to content

test(webviews): mark the two 3 s frame-watch windows as fixed waits (base red) - #23414

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fixed-waits/base-red
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fixed-waits/base-red

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

feat-cmux-next is over the fixed-wait baseline. #23374 merged after the ratchet (#23365) had run its CI, and it added a 3 s waitForTimeout to agent-pane-stream-jitter.test.ts and to agent-pane-history-paging.test.ts. Every PR's webviews check now fails on check:fixed-waits.

Both waits are observation windows. Each test records every painted frame for 3 s after the chat opens, then asserts that nothing jumped. The fixed time is what the test measures, so each wait gets a // fixed-wait: marker and the baseline stays where it is.

Verified with bun run check:fixed-waits (992 on the baseline) and scripts/web-lint.sh. The change is comments only.

Agent session: huge-blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Marks the two 3-second frame-watch windows in the webviews tests as fixed waits so check:fixed-waits passes again on the baseline.

#23374 added the waits after the fixed-wait ratchet (#23365) had run CI, putting feat-cmux-next over its baseline. Both waits are observation windows: each test records painted frames for 3 s after the chat opens and asserts no jumps, so the fixed time is what the test measures. The change adds // fixed-wait: markers to both waits and is comments only.

Written for commit 93771bc. Summary will update on new commits.

View guided diff Turn on auto-fix

#23374 merged after the fixed-wait ratchet (#23365) ran CI, and it added a
3 s waitForTimeout in two tests, which puts feat-cmux-next over its baseline.
Both waits are observation windows: the test records every painted frame for
3 s after the chat opens and asserts none jumped, so the time is the test.
They carry a fixed-wait marker instead of a raised baseline.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 93771bc: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23414 -f ref=fixed-waits/base-red -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check (3) failed: no known signature; failed step: Test webviews. This PR merged before its CI finished: fix forward on main.

CI failed on 93771bc620 (run 39603314798 attempt 1): 2 unknown.

Job Verdict Why
web / react-apps-check (3) unknown no known signature; failed step: Test webviews
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Not re-run automatically: web / react-apps-check (3), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; NEW: green on the base 0b1a93e; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 0b1a93e to compare; do not merge until green; see lane-rules
red: web / react-apps-check (3); no finished base run on 0b1a93e to compare; do not merge until green; see lane-rules

Tour of 93771bc620 (run): no media. The tour did not run: only webview code changed (2 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-pzugj created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next guards / defaults-snapshot is red on 18 of 21 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent): SHIP at 93771bc

Reds are not this PR's (it only adds two // fixed-wait: comments in two test files):

  • react-apps-check (4) / shard check: TIMEOUT test/composer-type-scale.test.ts (known flaky timeout, also on other PRs).
  • defaults-snapshot: check-menu-actions flags FileExplorerSectionView.swift, a file this PR doesn't touch (base).
  • fast-gates post: GitHub installation API rate limit when posting the status; the gates themselves were success.

@teamleaderleo
teamleaderleo merged commit 1c852c0 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the fixed-waits/base-red branch October 21, 2026 13:06
teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…#23450)

* webviews: composer-type-scale reads its variants four pages at a time

The file checks 41 gallery states one after another. Each one opens a
fresh page that loads ~700 dev-server modules (~2.2 s), after a ~30 s
cold warm-up, so the file ran 122-173 s alone on Huge Blue and 134 s
next to five other browser test files: past the runner's 120 s file
limit (react-apps-check timed it out on #23414). Four pages now read
variants at once, each variant still in its own page, and each test
awaits its own result. 73-84 s alone and under the same load, 41 pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d90-e8f9-7e11-bdf0-cba6a4790d6a&host=huge-blue

* Format composer-type-scale test with vp

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d90-e8f9-7e11-bdf0-cba6a4790d6a&host=huge-blue

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant