Skip to content

fix: preserve horizontal tab bar in fullscreen with minimal mode #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
solssak wants to merge 1 commit into from
Closed

fix: preserve horizontal tab bar in fullscreen with minimal mode #2341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2378,6 +2378,7 @@ struct ContentView: View {
workspace: tab,
isWorkspaceVisible: presentation.isPanelVisible,
isWorkspaceInputActive: isInputActive,
isFullScreen: isFullScreen,
workspacePortalPriority: portalPriority,
onThemeRefreshRequest: { reason, eventId, source, payloadHex in
scheduleTitlebarThemeRefreshFromWorkspace(
Expand Down
3 changes: 2 additions & 1 deletion Sources/WorkspaceContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ struct WorkspaceContentView: View {
@ObservedObject var workspace: Workspace
let isWorkspaceVisible: Bool
let isWorkspaceInputActive: Bool
let isFullScreen: Bool
let workspacePortalPriority: Int
let onThemeRefreshRequest: ((
_ reason: String,
Expand Down Expand Up @@ -377,7 +378,7 @@ struct WorkspaceContentView: View {
}

Group {
if isMinimalMode {
if isMinimalMode && !isFullScreen {
bonsplitView
.ignoresSafeArea(.container, edges: .top)
Comment thread
solssak marked this conversation as resolved.
} else {
Expand Down