Skip to content

cmux-next: motion follow-ups to #22795 (suggestion-lists-float opens its own entries; pane motion help) - #23357

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/motion-followups
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fix/motion-followups

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Two follow-ups to #22795 (directional motion), now merged.

What changes

Changelog

none

No capture: the only native change is a Debug tunable's help text in Settings; no layout or motion changes.

Observed / Not run

  • Observed: bun scripts/check-browser-test-lanes.ts passes ("Browser test lane imports checked."); scripts/web-lint.sh passes; prepush-gate.py reports no new violations.
  • Not run: the browser test itself (it runs only in CI or on a Freestyle VM); CI's webview shard runs it.

Agent session: huge-blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes two follow-ups to the directional motion changes from #22795.

  • The suggestion-lists-float test now loads and warms only its own gallery entries (agent-pane.composer and agent-pane.new-tab) via galleryFrame and warmGalleryFrame, instead of loading /gallery/frame.html with every entry. Its lane no longer waits in EVERY_ENTRY_PENDING.
  • Updates the motion.pane.variant Debug help to reflect that content keeps the larger of its starting and final size until the spring lands, not just its final size.

Written for commit 5ad602b. Summary will update on new commits.

View guided diff Turn on auto-fix

…ts own gallery entries; the pane motion help names the content hold

suggestion-lists-float opened /gallery/frame.html without entryPath and waited
in EVERY_ENTRY_PENDING for #22795, which changed it; it now loads and warms only
agent-pane.composer and agent-pane.new-tab. The motion.pane.variant help said
content keeps its final size; since #22795 it keeps the larger of its starting
and final size until the spring lands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cc2-04ea-7352-837a-21905d44c199&host=huge-blue
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by directional-motion on huge-blue · session

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 5ad602b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23357 -f ref=fix/motion-followups -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards.

CI failed on 5ad602b8b7 (run 39594289011 attempt 1): 2 code, 1 unknown.
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped.

Job Verdict Why
web / react-apps-check (2) code a web test failed
web / react-apps-check (3) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs agent-pane-scrollbar-full-height.test.ts a composer that grows and shrinks keeps a followed view at its end on every frame: failed (job)
  • seen on other PRs secret-card.test.ts the card takes the value privately and Provide sends it to acpmux only: failed (job)
Matched log lines
web / react-apps-check (2): (fail) a composer that grows and shrinks keeps a followed view at its end on every frame [3411.80ms]
web / react-apps-check (3): (fail) the card takes the value privately and Provide sends it to acpmux only [2124.68ms]

Not re-run automatically: web / react-apps-check (2), web / react-apps-check (3), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 0a42055 to compare; do not merge until green; see lane-rules
red: web / Web status; NEW: green on the base 0a42055; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 0a42055 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on 0a42055 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (3); no finished base run on 0a42055 to compare; do not merge until green; see lane-rules

CI fast guards failed on 5ad602b8b7 (https://github.com/manaflow-ai/cmux/actions/runs/39594289011). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-lht3o created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 9 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp1r83bojc/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpth002x6g/summary-fail.json (live):/summary-fail.json (live): View Logs
test/agent-pane-scrollbar-full-height.test.ts/agent-pane-scrollbar-full-height.test View Logs
test/agent-pane-scrollbar-full-height.test.ts/agent-pane-scrollbar-full-height.test View Logs
test/secret-card.test.ts/secret-card.test View Logs
test/secret-card.test.ts/secret-card.test View Logs
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett
ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_
inputs_still_rewrites_them) (job='autofix')/
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett
ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_
inputs_still_rewrites_them) (job='autofix')
View Logs
test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave
sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='autofix'
)/
test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave
sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='autofix'
)
View Logs
test_settings_exports_alone (main.SettingsOnlyArtifactLeavesTheActionFollowers.test
_settings_exports_alone) (job='autofix')/
test_settings_exports_alone (main.SettingsOnlyArtifactLeavesTheActionFollowers.test
_settings_exports_alone) (job='autofix')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo
teamleaderleo merged commit 74c3877 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the fix/motion-followups branch October 21, 2026 12:46
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant