Repository navigation
test: run the base Repair step with its real base-autofix-repair.sh - #23355
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
#23315 moved the base autofix's Repair step into scripts/cmux-next/base-autofix-repair.sh, which the step calls by relative path and which reads the Mac exports from EXPORTS_DIR. The settings-artifact test ran that step in a scratch tree holding only the base-autofix.sh stub and no EXPORTS_DIR, so its three base subtests failed with exit 127 (Companion workflows red). The tree now holds the real repair script beside the stub, with the step's EXPORTS_DIR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ce6-07ef-7c43-8bd7-9f20d4c93180&host=cosmic-gray
Collaborator
Author
|
Owned by browser-pip on cosmic-gray · session |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
Companion workflowsred incmux-next checkson feat-cmux-next.What broke
#23315 (95a43f8) moved the base autofix's Repair step into
scripts/cmux-next/base-autofix-repair.sh. The step now calls that script by relative path, and the script reads the Mac exports fromEXPORTS_DIR.tests/test_cmux_next_pr_autofix_settings.pyruns that step in a scratch tree that holds only abase-autofix.shstub and sets noEXPORTS_DIR. Its threeSettingsOnlyArtifactLeavesTheActionFollowersbase subtests (job='autofix') failed atrepair_args, line 109:The fix
The scratch tree now holds the real
base-autofix-repair.shnext to the stub, and the test sets the step'sEXPORTS_DIR($RUNNER_TEMP/action-exports, as the workflow does). The base subtests now run the repair script itself, which had no other test. The PR-autofix subtests are unchanged.The pre-commit hook also registered
tests/test_crash_class_fast_gate.py(added unregistered by #23331) intests/test-execution.toml. An unregistered test file is a base red of its own, and the hook adds it to every commit.Changelog
none
Observed / Not run
cmux-next checksat 5a721f6 failsCompanion workflowswith the three failures above.prepush-gate.pyreports no new violations.Companion workflowsstep of this PR'scmux-next checksruns it; its result is recorded below once it reports.🤖 Generated with Claude Code
Agent session: cosmic-gray
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
Companion workflowstest failures incmux-next checksafter #23315 moved the base autofix Repair step intoscripts/cmux-next/base-autofix-repair.sh.The settings-artifact test now runs the real repair script in its scratch tree (instead of a stub) and sets the step's
EXPORTS_DIR, so the three base subtests no longer fail with exit 127. Also registerstests/test_crash_class_fast_gate.pyintests/test-execution.toml, which was previously added unregistered.Written for commit 6f45b72. Summary will update on new commits.