Skip to content

test: run the base Repair step with its real base-autofix-repair.sh - #23355

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
fix-next-companion-workflows
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
fix-next-companion-workflows

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the Companion workflows red in cmux-next checks on feat-cmux-next.

What broke

#23315 (95a43f8) moved the base autofix's Repair step into scripts/cmux-next/base-autofix-repair.sh. The step now calls that script by relative path, and the script reads the Mac exports from EXPORTS_DIR. tests/test_cmux_next_pr_autofix_settings.py runs that step in a scratch tree that holds only a base-autofix.sh stub and sets no EXPORTS_DIR. Its three SettingsOnlyArtifactLeavesTheActionFollowers base subtests (job='autofix') failed at repair_args, line 109:

AssertionError: 127 != 0 : bash: line 2: scripts/cmux-next/base-autofix-repair.sh: No such file or directory

The fix

The scratch tree now holds the real base-autofix-repair.sh next to the stub, and the test sets the step's EXPORTS_DIR ($RUNNER_TEMP/action-exports, as the workflow does). The base subtests now run the repair script itself, which had no other test. The PR-autofix subtests are unchanged.

The pre-commit hook also registered tests/test_crash_class_fast_gate.py (added unregistered by #23331) in tests/test-execution.toml. An unregistered test file is a base red of its own, and the hook adds it to every commit.

Changelog

none

Observed / Not run

  • Observed (base, CI): cmux-next checks at 5a721f6 fails Companion workflows with the three failures above.
  • Observed: prepush-gate.py reports no new violations.
  • Not run locally: the test itself (no test runs on this Mac). The Companion workflows step of this PR's cmux-next checks runs it; its result is recorded below once it reports.

🤖 Generated with Claude Code
Agent session: cosmic-gray


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the Companion workflows test failures in cmux-next checks after #23315 moved the base autofix Repair step into scripts/cmux-next/base-autofix-repair.sh.

The settings-artifact test now runs the real repair script in its scratch tree (instead of a stub) and sets the step's EXPORTS_DIR, so the three base subtests no longer fail with exit 127. Also registers tests/test_crash_class_fast_gate.py in tests/test-execution.toml, which was previously added unregistered.

Written for commit 6f45b72. Summary will update on new commits.

View guided diff Turn on auto-fix

#23315 moved the base autofix's Repair step into scripts/cmux-next/base-autofix-repair.sh,
which the step calls by relative path and which reads the Mac exports from EXPORTS_DIR. The
settings-artifact test ran that step in a scratch tree holding only the base-autofix.sh stub
and no EXPORTS_DIR, so its three base subtests failed with exit 127 (Companion workflows red).
The tree now holds the real repair script beside the stub, with the step's EXPORTS_DIR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15ce6-07ef-7c43-8bd7-9f20d4c93180&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by browser-pip on cosmic-gray · session

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 6f45b72: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23355 -f ref=fix-next-companion-workflows -f platform=macos -f backend_mode=local

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Duplicate of #23352 (51e1cea), same fix.

@teamleaderleo
teamleaderleo deleted the fix-next-companion-workflows branch October 21, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant