Skip to content

tests: register test_guard_hooks_from_base.py (base registry red) - #23349

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/register-guard-hooks-from-base-test
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/register-guard-hooks-from-base-test

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

#23316 added tests/test_guard_hooks_from_base.py without a tests/test-execution.toml entry. The registry check flags it on feat-cmux-next, and every branch's pre-commit hook adds the entry on its own, so open PRs keep conflicting with each other on the registry.

This adds only that entry, lane linux-guard: the test needs only Python, git and bash, and cmux-next.yml already runs it on Ubuntu in the checks job. Its sibling guard tests use the same lane, and it is the lane the validator suggests.

Tests

  • scripts/ci/validate_test_execution_registry.py on this commit: the unregistered-test warning is gone.
  • Unrelated, already on base: tests/test_media_auto_tour.py is registered twice. CI only warns about a duplicate that is already on base, and this PR leaves it alone.

No capture: test registry only.

Agent session: cosmic-gray

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Registers tests/test_guard_hooks_from_base.py in the test execution registry under the linux-guard lane so the unregistered-test check passes on feat-cmux-next.

#23316 added the test file without a tests/test-execution.toml entry. Since every branch's pre-commit hook adds its own entry, open PRs kept conflicting on the registry. This adds only that entry, matching the sibling guard tests and the lane the registry validator suggests; the cmux-next.yml checks job already runs the test on Ubuntu.

Written for commit 2c0d2c2. Summary will update on new commits.

View guided diff Turn on auto-fix

#23316 added tests/test_guard_hooks_from_base.py without a
tests/test-execution.toml entry. The registry check fails on
feat-cmux-next, and every branch's pre-commit hook adds the entry on its
own, so open PRs conflict with each other on the registry. Its lane is
linux-guard, as the hook registers it and like the other guard tests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-aabc-7850-af29-f0655b1d2a1a&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by subsession-visibility-2 on cosmic-gray · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (independent Claude subagent, subsession-visibility-2): SHIP at 2c0d2c2

The test exists on feat-cmux-next and has no entry there; this adds exactly one. The lane is linux-guard: the test uses only the stdlib, git and bash, cmux-next.yml runs it with python3 on Ubuntu, and the validator suggests the same block. Nothing else lists it. The validator's unregistered warning is gone. The test_media_auto_tour.py duplicate is already on base and untouched here.

Agent session: cosmic-gray

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 2c0d2c2: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23349 -f ref=cmux/register-guard-hooks-from-base-test -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 4a6ef5b to compare; do not merge until green; see lane-rules

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp6i_u4wrg/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpxge8u7kq/summary-fail.json (live):/summary-fail.json (live): View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett
ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_
inputs_still_rewrites_them) (job='autofix')/
test_a_pull_request_that_changes_the_shortcut_inputs_still_rewrites_them (main.Sett
ingsOnlyArtifactLeavesTheActionFollowers.test_a_pull_request_that_changes_the_shortcut_
inputs_still_rewrites_them) (job='autofix')
View Logs
test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave
sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='autofix'
)/
test_regenerated_action_exports_bring_the_followers (main.SettingsOnlyArtifactLeave
sTheActionFollowers.test_regenerated_action_exports_bring_the_followers) (job='autofix'
)
View Logs
test_settings_exports_alone (main.SettingsOnlyArtifactLeavesTheActionFollowers.test
_settings_exports_alone) (job='autofix')/
test_settings_exports_alone (main.SettingsOnlyArtifactLeavesTheActionFollowers.test
_settings_exports_alone) (job='autofix')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-kzu1x created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit 5c4e212 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/register-guard-hooks-from-base-test branch October 21, 2026 11:41
teamleaderleo added a commit that referenced this pull request Oct 21, 2026
Base registered tests/test_guard_hooks_from_base.py too (#23349), so the
merge kept it twice and the registry validator refused it. Also point the
backgroundSection doc at the callers that still exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…e the composer; a finished subagent leaves one line (#23104)

* cmux NEXT: running subagents sit in one tray above the composer; a finished one leaves one line

Leo: "put the subagent situation at the bottom of the chat and anchor". A running
subagent drew a "1 subagent running" card mid-transcript where it started, a
separate "1 agent" chip sat by the composer, and the summary popover used a
third style.

Now every running subagent and background command is a line in one tray in the
bottom stack, right above the composer (name, what it does now, elapsed,
state, theme-accent icon, stop button). Several get a header; past three they
fold. The transcript keeps no running card: an ended subagent leaves one line
where it ended, "Subagent finished: <name> · 1m 20s", a failure in the danger
color. The tray's line is the summary card's row (AgentLine). The chip is gone.

Debug Settings agentPane.debug.subagentTray (default on, sent with the theme)
keeps the old group card and pill when off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* cmux NEXT: the subagent end lines' translations are reviewed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* cmux NEXT: the tray is the one place running background work shows

The tray above the composer now lists background commands from
summary/backgroundWork.ts (acpmux's process registry merged with the
transcript's tasks) and the chats the agent started, in a turn and
between turns. Between turns its header says "Running in background ·
1 agent · 2 commands · 1 session". A registry command shows whenever the
registry says it runs, with Stop. A command only the transcript knows
shows only while a turn runs, so a peer's chat whose task end never
arrived no longer keeps it up between turns.

The transcript's "Running in background" row (BackgroundWorkRow.tsx)
is gone, and with the tray on the running line counts nothing. With
Debug Settings agentPane.debug.subagentTray off, the line keeps its
counts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* cmux NEXT: the running tray's clock rests while the pane is hidden

useNow (the tray's, the group card's and the summary rows' one-second
clock) stops ticking while the page is hidden and catches up the moment
it shows. In a short pane the tray gives up its height and scrolls in
place, like the other parts of the bottom stack.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* Tray highlight: shorter summary and a docs link

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* test(webviews): the tray clock test moves time by hand instead of waiting

The hidden-pane clock test recorded a 1.3 s real wait. It now records
the clock's interval instead of running it and sets the time with
setSystemTime, so it checks the same rest and catch-up with no wait.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* cmux NEXT: the tray's header time is its own; a quiet chat lists no processes

The tray header's elapsed time carried the lines' time class, so a tray
with two lines counted three line times (agent-pane-agents-pill.test.ts).
It now has its own class, acpmux-running-tray__time.

Reading acpmux's process registry whenever the tray was on sent
_acpmux/process/list from every chat, a method the host's pane policy
does not allow (agent-pane-session-pages.test.ts). The registry is read
again only while the summary card shows, a turn runs or a command is
known to run, as before. The tray still shows a registry command between
turns while the registry reports it running.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* Expect "Working for" on the running line with the tray on

Base #23164 made the running line read the turn's time; the read in flight has its own tool row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* Drop the duplicate test registration from the base merge

Base registered tests/test_guard_hooks_from_base.py too (#23349), so the
merge kept it twice and the registry validator refused it. Also point the
backgroundSection doc at the callers that still exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* test(subagent tray): wait for the tray to detach, not a 100 ms poll

Base's fixed-wait ratchet (#23365) counts agent-pane-agents-pill.test.ts at
its baseline again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

* gallery(subagent tray): several-running shows three open lines

Four items start folded (TRAY_OPEN_MAX = 3), so the play's wait for four
lines never held and gallery health reported the state broken. Two running
subagents and a command keep it open; many-folded covers the fold.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d1f-ca00-7e31-b882-4d3c03033ee2&host=cosmic-gray

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant