Repository navigation
cmux-next: remove the dead SessionSidebar (not shipped since #17504) - #23339
Merged
Merged
Conversation
The agent pane stopped rendering SessionSidebar in #17504; its only users were its gallery entry, the dev-only sidebar prototype and tests, so lanes kept fixing code nobody runs. - Delete SessionSidebar.tsx, its gallery entry and the tests that only rendered it (chats-sidebar-empty, session-sidebar-preview, sidebar-rail-css, the sidebar case of chat-rows-open-on-press, the two gallery-agent-pane-entries cases, the row-focus / selected-row-accent / subtle-elevation session-row and sidebar cases). - The prototype's History drawer draws its own plain list (title, an "Open" mark for sessions in a tab, aria-current for the selected one). - Drop what only the sidebar used: sessionList's sidebarSections, groupByProject, filterSessions, sortByRecency, visibleSessions, groupMark, GROUP_ROWS and SessionGroup (and session-list-grouping.test), 72 styles.css rules for the sidebar, rail, account, session rows and previews, and cardState's measure of a sidebar that is never rendered. - Lower the layers and type-scale baselines the deleted CSS frees. sidebarPreview.ts stays for now: the native agentPane.debug.sidebarPreviewVariant Debug setting and layout.sidebarPreviewVariant still write it, but nothing reads it any more. Removing the setting, the page event and the module is a follow-up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Pending: CI is running on Last result: Yours to fix: Written by web and size checks: green
Tour of |
Collaborator
Author
|
Owned by chief-pet-default-off on huge-blue · session |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Bead |
styles.css conflict: base only restyled a removed sidebar rule; kept the removal, and dropped the sidebar enter rule #22795 added (nothing renders .acpmux-sidebar). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
teamleaderleo
added a commit
that referenced
this pull request
Oct 21, 2026
…aseline row passes #22975 merged two unmarked polls in agent-pane-queued-images (CI ran before the fixed-wait guard); they now wait on the client's snapshots. #23339 deleted session-sidebar-preview.test.tsx while it still had a baseline row, so the check failed every PR; a row whose file is gone now passes and drops on --update-baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
This was referenced Oct 21, 2026
teamleaderleo
added a commit
that referenced
this pull request
Oct 21, 2026
…ger exist (#23473) artifact-panel#html/#markdown/#versions, composer-pickers#fast-mode and composer-row#fast-off/#fast-on reach their states on base 5506b88 (3 tries with the trusted input driver; their plays report only quality findings). session-sidebar#rail-keyboard and #view-switching-animation-audit name an entry #23339 deleted. Also trims a styles.css comment that still described the removed sidebar drawer. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Oct 21, 2026
* test(webviews): base passes the fixed-wait ratchet again #23094 merged after the guard (#23365) with 9 new fixed waits, so check:fixed-waits fails on base and on every PR into feat-cmux-next. - snapshot-save-throttle: the 250 ms save timer runs on bun's fake timers; nothing is written at 249 ms, one write at 250 ms. (The old 300 ms sleep passed with any delay under 300 ms.) - streaming-text harness and frames test: the reveal drain and the settle window are sampled, so the windows are the test; the 500 ms before sampling has no start-up-done signal. Marked fixed-wait. - RevealedMarkdown: the 20 ms in afterEach is teardown with no assert after it. Marked fixed-wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue * test(webviews): reveal-message runs its row wait on the fake clock #22967 added three fixed waits after the guard: the wait for a revealed row to be drawn polls on setTimeout, so the three tests that watch it now run on bun's fake timers and advance the clock instead of sleeping. Breaking the poll, the stale-chat check or the cancel of an earlier mark each fails its test. Also: the frames test's start-up comment no longer guesses the cause. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue * test(webviews): queued-images waits for snapshots; a deleted test's baseline row passes #22975 merged two unmarked polls in agent-pane-queued-images (CI ran before the fixed-wait guard); they now wait on the client's snapshots. #23339 deleted session-sidebar-preview.test.tsx while it still had a baseline row, so the check failed every PR; a row whose file is gone now passes and drops on --update-baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue * test(webviews): drop the deleted test's baseline row; queued-images' wait fails before bun's timeout Review nits on #23452: the stale session-sidebar-preview row would have let a new file at that path keep 6 waits, and a 5 s condition timeout lost its message to bun's 5 s test timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Shipped in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionSidebarhas not shipped since #17504 (2026-10-06): no product code imports it. Only its gallery entry, its tests and the dev-only prototype page (prototype/WorkspaceShell.tsx,/agent-pane/prototype.html) used it, yet lanes kept fixing it (#23002, #23012, gallery plays). The coordinator decided to delete it, so lanes stop fixing dead code.Removed:
SessionSidebar.tsxandSessionSidebar.gallery.tsxchats-sidebar-empty,session-sidebar-preview,sidebar-rail-css,session-list-grouping, and its cases inchat-rows-open-on-press,row-focus,selected-row-accent,subtle-elevationandgallery-agent-pane-entriessessionList.tshelpers only it used:sidebarSections,groupByProject,filterSessions,sortByRecency,visibleSessions,groupMarkstyles.cssrules whose classes nothing renders any more:scope>.acpmux-sidebarlookup insummary/cardState.ts(nothing renders that class)ui-rules.pending.jsonline; the layers and type-scale baselines are lowered to matchThe prototype stays. Its History drawer is now a plain list of the history chats: an "Open" mark for chats already in a tab, the selected chat marked current, and a click opens that chat.
Changelog
none
Test
This removes code with no user-visible change, so there is no red-first test.
vp check --no-fmt: clean.check-layers.shandcheck-type-scale.sh: pass.row-focus,selected-row-accent,subtle-elevation,chat-rows-open-on-press): 56 pass.prototype-stack-switch-motion: pass.gallery-agent-pane-entries: 11 pass.prototype.html?historyin Chromium: 20 rows, the Open marks and the current marker show, a click opens the chat and closes the drawer, and there are no page errors.Observed / Not run
webviews/, the Swift app andcmux-tui/frontends/web, and passed it.scripts/web-lint.shandprepush-gate.pypass.sidebarPreview.ts. The native Debug settingagentPane.debug.sidebarPreviewVariantandlayout.sidebarPreviewVariantstill write it, but nothing reads it any more. Removing it means removing the Swift tunable, the page event and the module together. 21sidebar.*strings are now unreferenced; the catalogs are untouched.No capture: dead code removal; the shipped app has no visible change.
Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Removes
SessionSidebar, which has not shipped since #17504. No product code renders it; only its gallery entry, tests, and the dev-only prototype did.chats-sidebar-empty,session-sidebar-preview,sidebar-rail-css,session-list-grouping, and the sidebar cases inchat-rows-open-on-press,row-focus,selected-row-accent,subtle-elevation,gallery-agent-pane-entries).sessionListhelpers only it used (sidebarSections,groupByProject,filterSessions,sortByRecency,visibleSessions,groupMark), 72 unusedstyles.cssrules (including its entrance transition), the dead sidebar lookup insummary/cardState.ts, and itsui-rules.pending.jsonentry; the layers and type-scale baselines are lowered to match.sidebarPreview.tsstays because the native Debug setting still writes it; removing it is left as a follow-up.Written for commit 6224fa5. Summary will update on new commits.