Repository navigation
cmux NEXT Chief pet: notices stay glass (the toasts' veil), not the opaque card fill - #23318
Conversation
…paque card Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cf2-7984-7a60-b6ee-6eef758aed01&host=cosmic-gray
…eil, not the card fill #23000 laid the CardMaterial (the popup fill at 0.9+ alpha) on the notice's glass to stop page text showing through it. Glass is never made opaque (Leo 2026-10-20). The capsule now takes the shared toast glass (FloatingGlassStyle.toast: a gray veil and rim over Liquid Glass), the look every toast uses, which keeps the text legible and the capsule glass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cf2-7984-7a60-b6ee-6eef758aed01&host=cosmic-gray
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
Owned by floating-toast on cosmic-gray · session |
|
Bead |
|
Shipped in:
|
Summary
#23000 fixed the Chief pet's see-through notice by laying
CardMaterial(the popup fill, at 0.9 alpha or more) over its glass. That made a glass surface effectively opaque, and glass is never made opaque (Leo, 2026-10-20: "we want the glass... don't make it opaque... I hate opaque").The capsule now uses the shared toast glass,
Glass.makeOverlayPanel(tone: .neutralGlass(.toast)). That is the gray veil and rim over Liquid Glass that every cmux toast and dialog uses (FloatingGlassStyle.toast, 0.42 veil on dark and 0.55 on light). The text stays legible over a busy page, and the capsule stays glass, with no card fill. It keeps its capsule shape from the references, and Reduce Transparency still draws the solid surface.Takes back #23000: the opaque card material on the notice. The rest of #23000 (shows over cmux only, folds away, the text) stays.
Testing
CmuxNextFloatingTests/ChiefPetTests/noticeCapsuleIsTheToastsGlassNeverOpaquechecks that the capsule's tone is the toast style and that it is not a card.No capture: the pet's panels set
sharingType = .none, so a screen capture never shows them.Observed / Not run
scripts/cmux-next/prepush-gate.py: no new violations..neutralGlass(.toast)the surface is not a card (noCardMaterial), draws the veil and rim, keeps the capsule radius, and keeps the Reduce Transparency fallback. The reply box and the rail are already bare glass (solid only under Reduce Transparency), so they don't change.PageEnginePolicyTests.swift:43, from e59fdc3; fix(next): the CmuxNext package compiles again — three one-line breaks on base #23281 fixes it). This PR's Release compile covers the source change.Changelog
Fixed: The Chief pet's notices stay glass while staying legible over any page.
Agent session: cosmic-gray