Skip to content

cmux NEXT Chief pet: notices stay glass (the toasts' veil), not the opaque card fill - #23318

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
chief-pet-glass
Oct 21, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
chief-pet-glass

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

#23000 fixed the Chief pet's see-through notice by laying CardMaterial (the popup fill, at 0.9 alpha or more) over its glass. That made a glass surface effectively opaque, and glass is never made opaque (Leo, 2026-10-20: "we want the glass... don't make it opaque... I hate opaque").

The capsule now uses the shared toast glass, Glass.makeOverlayPanel(tone: .neutralGlass(.toast)). That is the gray veil and rim over Liquid Glass that every cmux toast and dialog uses (FloatingGlassStyle.toast, 0.42 veil on dark and 0.55 on light). The text stays legible over a busy page, and the capsule stays glass, with no card fill. It keeps its capsule shape from the references, and Reduce Transparency still draws the solid surface.

Takes back #23000: the opaque card material on the notice. The rest of #23000 (shows over cmux only, folds away, the text) stays.

Testing

CmuxNextFloatingTests/ChiefPetTests/noticeCapsuleIsTheToastsGlassNeverOpaque checks that the capsule's tone is the toast style and that it is not a card.

No capture: the pet's panels set sharingType = .none, so a screen capture never shows them.

Observed / Not run

  • Ran scripts/cmux-next/prepush-gate.py: no new violations.
  • Independent review subagent: PASS. With .neutralGlass(.toast) the surface is not a card (no CardMaterial), draws the veil and rim, keeps the capsule radius, and keeps the Reduce Transparency fallback. The reply box and the rail are already bare glass (solid only under Reduce Transparency), so they don't change.
  • Fleet run of the ChiefPet suites on be70784 (step a67880f2ef18): did not reach the tests. The package's test target doesn't compile on base (PageEnginePolicyTests.swift:43, from e59fdc3; fix(next): the CmuxNext package compiles again — three one-line breaks on base #23281 fixes it). This PR's Release compile covers the source change.
  • test(next): the accent is never orange and glass is never opaque #23133 (the open "glass is never opaque" guard, another lane's) scans only webview CSS, so it could not have caught this native change. This PR's test guards this surface.

Changelog

Fixed: The Chief pet's notices stay glass while staying legible over any page.

Agent session: cosmic-gray

teamleaderleo and others added 2 commits October 21, 2026 03:51
…eil, not the card fill

#23000 laid the CardMaterial (the popup fill at 0.9+ alpha) on the notice's
glass to stop page text showing through it. Glass is never made opaque (Leo
2026-10-20). The capsule now takes the shared toast glass
(FloatingGlassStyle.toast: a gray veil and rim over Liquid Glass), the
look every toast uses, which keeps the text legible and the capsule glass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cf2-7984-7a60-b6ee-6eef758aed01&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review be70784: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23318 -f ref=chief-pet-glass -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on be70784f26; ci-status is green without them.

CI passes on be70784f26 (run 39589175252 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by floating-toast on cosmic-gray · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-g5alp created for this PR by the cmux coordinator.

@teamleaderleo
teamleaderleo merged commit 2136cb9 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the chief-pet-glass branch October 21, 2026 12:47
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant