Skip to content

cmux-next tests: SidebarRowGutterTests expects the sidebar pill's trailing trim from #22733 - #23304

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
cmux/fix-sidebar-gutter-trim
Oct 21, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
cmux/fix-sidebar-gutter-trim

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

SidebarRowGutterTests has been red on feat-cmux-next since #22733 (0d62303, "row pills stop short of the edge"). That PR made every sidebar row end SidebarStyle.rowTrailingTrim (Metrics.space4, 8 pt) before the list's right inset, so the pill never reaches the sidebar's edge (Leo 2026-10-20: "trim the pill's right side"). It did not update this suite, which still expected the pill to end exactly at the inset and at the divider's right edge.

The change was deliberate, so the test is what's out of date and this PR is test-only:

  • selectedAndUnselectedRowsHaveEqualLeadingAndTrailingInsets: the pill's right inset is horizontalInset + rowTrailingTrim. The checks that the content's leading and trailing insets inside the pill are equal, and that the pill's left inset is the gutter, stay the same.
  • thePillAlignsWithTheSectionHeaderAndTheDivider: the pill ends rowTrailingTrim before the divider's right edge. Its left edge still lines up with the header and the divider.

No product code changes.

Evidence

  • Command: cmux-ci run --class light --script scripts/ci/package-test-lane.sh --arg=suite --arg=Packages/macOS/CmuxNext --arg=SidebarRowGutterTests --env CMUX_CI_XCODE_APP=/Applications/Xcode_26.6.app
  • Red on base 27ed896: fleet step 0675fe8cc69e7a258abc3dd8. At :69 the trailing inset is not the gutter, and at :81 pill.maxX 226 != aboveLine.frame.maxX 234 (exactly the 8 pt trim).
  • Green on head 21785c0: fleet step 3167c900cb816a8856eed142, 3/3 tests passed.

Observed / Not run

  • Observed: the base red step above and the head green step (Xcode 26.6, package-test-lane). The prepush gate is clean.
  • Not run: other suites. Builds on a newer tip (d483541) currently fail to compile in CmuxNextPagesTests/PageEnginePolicyTests.swift:43, a separate base red. That is why this branch is based on 27ed896, the tip the red step ran on.

Changelog

none

Agent session: cosmic-gray

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Updates SidebarRowGutterTests to match #22733's deliberate trim, which now ends each sidebar pill SidebarStyle.rowTrailingTrim (8 pt) short of the sidebar's right edge. The suite has been red on feat-cmux-next since that change; this PR is test-only with no product code changes.

  • The pill's right inset is now horizontalInset + rowTrailingTrim; its left inset and the equal content insets inside the pill are unchanged.
  • The pill now ends rowTrailingTrim before the divider's right edge instead of exactly at it.

Written for commit 3820e82. Summary will update on new commits.

View guided diff Turn on auto-fix

…from #22733

#22733 (Leo 2026-10-20) ends every sidebar row SidebarStyle.rowTrailingTrim
(Metrics.space4, 8 pt) short of the list's right inset, so the pill never runs
to the sidebar's edge. SidebarRowGutterTests still required the pill to end at
the inset and at the divider's right edge, so it has been red on
feat-cmux-next since then. The content insets inside the pill stay equal;
only the pill's right edge moves in by the trim.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a42d-7970-a4a7-2f0ac203c940&host=cosmic-gray
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 3820e82: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23304 -f ref=cmux/fix-sidebar-gutter-trim -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 3820e82638; ci-status is green without them.

CI passes on 3820e82638 (run 39600691965 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

web and size checks: green

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by update-survival on cosmic-gray · session

@blacksmith-sh

This comment has been minimized.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-bbys3 created for this PR by the cmux coordinator.

@blacksmith-sh

This comment has been minimized.

@teamleaderleo
teamleaderleo merged commit a91d210 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/fix-sidebar-gutter-trim branch October 21, 2026 13:02
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

teamleaderleo added a commit that referenced this pull request Oct 21, 2026
…#23478)

* test(next sidebar): pinned rows end at the group header's trimmed edge (failing)

SidebarPinnedRowWidthTests still wanted the group header to end at the
list's right inset; since #22733 every list row ends rowTrailingTrim
short of it, as SidebarRowGutterTests learned in #23304. The pinned Home
and App Store pills must end at the same place, and do not yet: they run
8 pt past the header at every density and width.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-aabc-7850-af29-f0655b1d2a1a&host=cosmic-gray

* fix(next sidebar): pinned rows in the list take the row trim

#22733 ends every list row SidebarStyle.rowTrailingTrim short of the
right inset, but a block row (the pinned Home and App Store) lays out
its own items across the full row, so their pills ran 8 pt past the
group header and the workspace rows. SidebarRegionMetrics gets a
trailingTrim (0 by default), which the list's blocks set to the row
trim; a block's list rows end that much short. The fixed bands outside
the list keep their full width.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-aabc-7850-af29-f0655b1d2a1a&host=cosmic-gray

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant