Repository navigation
cmux-next tests: SidebarRowGutterTests expects the sidebar pill's trailing trim from #22733 - #23304
Conversation
…from #22733 #22733 (Leo 2026-10-20) ends every sidebar row SidebarStyle.rowTrailingTrim (Metrics.space4, 8 pt) short of the list's right inset, so the pill never runs to the sidebar's edge. SidebarRowGutterTests still required the pill to end at the inset and at the divider's right edge, so it has been red on feat-cmux-next since then. The content insets inside the pill stay equal; only the pill's right edge moves in by the trim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c01-a42d-7970-a4a7-2f0ac203c940&host=cosmic-gray
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by web and size checks: green |
|
Owned by update-survival on cosmic-gray · session |
This comment has been minimized.
This comment has been minimized.
|
Bead |
This comment has been minimized.
This comment has been minimized.
|
Shipped in:
|
…#23478) * test(next sidebar): pinned rows end at the group header's trimmed edge (failing) SidebarPinnedRowWidthTests still wanted the group header to end at the list's right inset; since #22733 every list row ends rowTrailingTrim short of it, as SidebarRowGutterTests learned in #23304. The pinned Home and App Store pills must end at the same place, and do not yet: they run 8 pt past the header at every density and width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-aabc-7850-af29-f0655b1d2a1a&host=cosmic-gray * fix(next sidebar): pinned rows in the list take the row trim #22733 ends every list row SidebarStyle.rowTrailingTrim short of the right inset, but a block row (the pinned Home and App Store) lays out its own items across the full row, so their pills ran 8 pt past the group header and the workspace rows. SidebarRegionMetrics gets a trailingTrim (0 by default), which the list's blocks set to the row trim; a block's list rows end that much short. The fixed bands outside the list keep their full width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-aabc-7850-af29-f0655b1d2a1a&host=cosmic-gray --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
SidebarRowGutterTestshas been red onfeat-cmux-nextsince #22733 (0d62303, "row pills stop short of the edge"). That PR made every sidebar row endSidebarStyle.rowTrailingTrim(Metrics.space4, 8 pt) before the list's right inset, so the pill never reaches the sidebar's edge (Leo 2026-10-20: "trim the pill's right side"). It did not update this suite, which still expected the pill to end exactly at the inset and at the divider's right edge.The change was deliberate, so the test is what's out of date and this PR is test-only:
selectedAndUnselectedRowsHaveEqualLeadingAndTrailingInsets: the pill's right inset ishorizontalInset + rowTrailingTrim. The checks that the content's leading and trailing insets inside the pill are equal, and that the pill's left inset is the gutter, stay the same.thePillAlignsWithTheSectionHeaderAndTheDivider: the pill endsrowTrailingTrimbefore the divider's right edge. Its left edge still lines up with the header and the divider.No product code changes.
Evidence
cmux-ci run --class light --script scripts/ci/package-test-lane.sh --arg=suite --arg=Packages/macOS/CmuxNext --arg=SidebarRowGutterTests --env CMUX_CI_XCODE_APP=/Applications/Xcode_26.6.app0675fe8cc69e7a258abc3dd8. At :69 the trailing inset is not the gutter, and at :81pill.maxX 226 != aboveLine.frame.maxX 234(exactly the 8 pt trim).3167c900cb816a8856eed142, 3/3 tests passed.Observed / Not run
CmuxNextPagesTests/PageEnginePolicyTests.swift:43, a separate base red. That is why this branch is based on 27ed896, the tip the red step ran on.Changelog
none
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Updates
SidebarRowGutterTeststo match #22733's deliberate trim, which now ends each sidebar pillSidebarStyle.rowTrailingTrim(8 pt) short of the sidebar's right edge. The suite has been red onfeat-cmux-nextsince that change; this PR is test-only with no product code changes.horizontalInset + rowTrailingTrim; its left inset and the equal content insets inside the pill are unchanged.rowTrailingTrimbefore the divider's right edge instead of exactly at it.Written for commit 3820e82. Summary will update on new commits.