Skip to content

webviews: the run board's timeline rings only its checkbox (base text-focus lint red) - #23300

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/run-board-checkbox-focus
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/run-board-checkbox-focus

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Base lint red: check-text-focus-rings (part of bun run check, so the web lint (fast) job) fails on feat-cmux-next since #22408 (802f9b7):

webviews/src/agent-session/acpmux/run-board/variants/timeline/timeline.css:14: `.timeline-board input:focus-visible` sets `outline: 2px solid var(--page-text-3)` on a focused text field

Change

The timeline board's only <input> is the "I reviewed this attempt" checkbox (TimelineRunBoard.tsx:546). The ring rule now names it, .timeline-board input[type="checkbox"]:focus-visible. The check still refuses rings on text fields, and the checkbox keeps its keyboard ring exactly as before.

Changelog

none

Observed / Not run

  • Red on base c874b3e (local): python3 scripts/cmux-next/check-text-focus-rings.py (from webviews/) reports the line above.
  • Green on this head: the check prints "no focus ring on a text field", and scripts/web-lint.sh passes (webviews).
  • Not run: a visual check of the board's checkbox ring; the rule's declarations are unchanged and only its selector narrowed to the element it already applied to.

Agent session: huge-blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the check-text-focus-rings lint failure on the run board timeline by narrowing the focus-ring selector to the checkbox instead of all inputs. The timeline board's only input is the "I reviewed this attempt" checkbox, so the keyboard ring is unchanged while web lint (fast) passes.

Written for commit 0806af9. Summary will update on new commits.

View guided diff Turn on auto-fix

…d focus (base text-focus red)

#22408's timeline.css put an outline on '.timeline-board input:focus-visible',
which check-text-focus-rings reads as a ring on a text field and fails the
base 'web lint (fast)' job. The board's only input is the review checkbox;
the selector now says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 0806af9: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23300 -f ref=cmux/run-board-checkbox-focus -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on 0806af989e (run 39582946973 attempt 1): 4 code, 1 unknown.

Job Verdict Why
web / react-apps-check (3) code a web test failed
web / react-apps-check (2) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check (4) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs pane-english.test.ts agent pane strings > no user-visible English is written in the pane's sources: failed (job)
  • seen on other PRs agent-pane-math.test.tsx each delimiter typesets once math appears: failed (job)
  • seen on other PRs agent-pane-scrollbar-full-height.test.ts a composer that grows and shrinks leaves the rows a reader reads where they were on every frame: failed (job)
  • seen on other PRs agent-pane-scrollbar-full-height.test.ts a composer that grows and shrinks keeps a followed view at its end on every frame: failed (job)
  • seen on other PRs new-tab-add-project-layer.test.ts the Add project dialog is solid over the New Tab composer: failed (job)
  • seen on other PRs agent-pane-stream-jitter.test.ts webkit: a queued prompt sent as the next turn moves the view up only: failed (job)
Matched log lines
web / react-apps-check (3): (fail) agent pane strings > no user-visible English is written in the pane's sources [806.03ms]
web / react-apps-check (2): (fail) each delimiter typesets once math appears [68.04ms]
web / react-apps-check (1): (fail) a composer that grows and shrinks leaves the rows a reader reads where they were on every frame [4233.10ms]
web / react-apps-check (4): (fail) webkit: a queued prompt sent as the next turn moves the view up only [4947.66ms]

Not re-run automatically: web / react-apps-check (3), web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check (4), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 807f34f; does not block
red: web / Web status; base red: the same failure on the base 807f34f; does not block
red: web / react-apps-check; base red: the same failure on the base 807f34f; does not block
red: web / react-apps-check (1); NEW: at /home/runner/_work/cmux/cmux/webviews/test/new-tab-add-project-layer.test.ts:45:16 (+1 more) is not red on the base 807f34f; do not merge until green; see lane-rules
red: web / react-apps-check (2); NEW: { "source": "Area is $\pi r^2$ here.", - "tex": [ - "\pi r^2", - ], + "tex": [], } - Expected - 3 + Received + 1 at <anonymous> (/home/runner/_work/cmux/cmux/we is not red on the base 807f34f; do not merge until green; see lane-rules
red: web / react-apps-check (3); NEW: - [] + [ + "run-board/runAttach.ts:30 "This worker terminal endpoint has expired. Request a fresh attach ticket."", + "run-board/runAttach.ts:37 "This worker do is not red on the base 807f34f; do not merge until green; see lane-rules
red: web / react-apps-check (4); NEW: green on the base 807f34f; do not merge until green; see lane-rules

Tour of 0806af989e (run): no media. The tour did not run: only webview code changed (1 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent): SHIP at 0806af9. The checkbox is the board's only input; the selector now names it, so the checker is not loosened and the ring is unchanged (the global rule supplies it). Local: check-text-focus-rings green, scripts/web-lint.sh passes.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp3t8dgzv2/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpxiw9zrhu/summary-missing.json (live):/summary-missing.json (live): View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)/
test_a_file_a_test_reads_selects_that_test (main.PullRequestTiers.test_a_file_a_tes
t_reads_selects_that_test)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant