Repository navigation
webviews: the run board's timeline rings only its checkbox (base text-focus lint red) - #23300
Conversation
…d focus (base text-focus red) #22408's timeline.css put an outline on '.timeline-board input:focus-visible', which check-text-focus-rings reads as a ring on a text field and fails the base 'web lint (fast)' job. The board's only input is the review checkbox; the selector now says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c78-27ca-7140-a6c7-95f0db83b18c&host=huge-blue
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 807f34f; does not block Tour of |
|
Review (subagent): SHIP at 0806af9. The checkbox is the board's only input; the selector now names it, so the checker is not loosened and the ring is unchanged (the global rule supplies it). Local: check-text-focus-rings green, scripts/web-lint.sh passes. |
|
Found 4 test failures on Blacksmith runners: Failures
|
|
Shipped in:
|
Base lint red:
check-text-focus-rings(part ofbun run check, so theweb lint (fast)job) fails on feat-cmux-next since #22408 (802f9b7):Change
The timeline board's only
<input>is the "I reviewed this attempt" checkbox (TimelineRunBoard.tsx:546). The ring rule now names it,.timeline-board input[type="checkbox"]:focus-visible. The check still refuses rings on text fields, and the checkbox keeps its keyboard ring exactly as before.Changelog
none
Observed / Not run
python3 scripts/cmux-next/check-text-focus-rings.py(fromwebviews/) reports the line above.scripts/web-lint.shpasses (webviews).Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
check-text-focus-ringslint failure on the run board timeline by narrowing the focus-ring selector to the checkbox instead of all inputs. The timeline board's only input is the "I reviewed this attempt" checkbox, so the keyboard ring is unchanged whileweb lint (fast)passes.Written for commit 0806af9. Summary will update on new commits.