Repository navigation
cmux NEXT: minimap rail and Apps chips keep the shared scroller (fixes the check-scrollbars base red) - #23285
Conversation
check-scrollbars (SCROLLBARS-THIN) fails cmux-next checks on feat-cmux-next: the thread minimap's list (#22879) and the Apps Discover chips hid their scrollbars with scrollbar-width and ::-webkit-scrollbar, which turn WebKit's overlay scroller into a custom one. They now keep the shared thin overlay scroller, hidden until the user scrolls. That takes the check from 13 hits to 10, back under its ceiling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-aabc-7850-af29-f0655b1d2a1a&host=cosmic-gray
|
Owned by subsession-visibility-2 on cosmic-gray · session |
|
Review (independent Claude subagent, subsession-visibility-2): SHIP at 3ca83c7 check-scrollbars passes (10 Swift ratchet-debt warnings, no hard failure). Both pages install the shared scroller CSS (pages/shared/desktop → installScrollers), so the rule removal is the fix the check asks for, not an exception. No test, gallery or snapshot depends on the hidden scrollbars (headless Chromium hides scrollbars anyway). Follow-up, not blocking: with macOS "Show scroll bars: Always", a compact minimap rail that overflows draws an 8px legacy scroller over the right end of its 36px ticks, covering the bookmark dot's hit area. Overlay mode (the default) is unaffected. A follow-up can widen the rail by --cmux-scroller-size under data-scrollers="legacy". Agent session: cosmic-gray |
|
Found 15 test failures on Blacksmith runners: Failures
...and 5 more test failures. View all on Blacksmith: run 39580790764, run 39580781911
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 0e51a06; does not block
Agents: Tour of |
|
Bead |
|
codex-review: SHIP at 3ca83c7
|
|
Shipped in:
|
…e left edge) (#23735) * test(webviews): the agent chat ships with no thread minimap (red) The default arm of thread-minimap-layout is full since #22784, so every agent chat draws the full-height ScrollMap (a dash per message and a view box) down the transcript's left edge, and the compact rail's list shows a second scroller since #23285. These tests fail until the default is off and the list stops scrolling on its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16027-a80b-79c0-ab31-500e58883d27&host=cosmic-gray * fix(webviews): the agent chat draws no thread minimap by default Leo on the nightly (2026-10-21): a column of dashes and a thumb box down the left edge of the chat, and a second scroller. That is the full-height ScrollMap, the default arm since #22784 (lit band #22879), and the compact rail's own list, which shows a scroller since #23285 dropped its hiding. - thread-minimap-layout gets an off arm, and off is the default: no map, no rail, nothing at the left edge. Previous and Next Turn and the bookmarked-prompt steps still work. full and compact stay selectable from cmux.experiments for dogfood. - The compact rail's list is overflow: hidden: it still scrolls from script and focus (band follow, scrub, Tab) but never draws a scroller, so the transcript keeps its one shared thin scroller (SCROLLBARS-THIN). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a16027-a80b-79c0-ab31-500e58883d27&host=cosmic-gray * style(webviews): format the minimap experiment and its test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
cmux-next checksfails on feat-cmux-next at check-scrollbars: 13 hits over its ceiling of 10. Three are web rules hiding a scrollbar, which SCROLLBARS-THIN forbids (scrollbar-widthand::-webkit-scrollbarturn WebKit's overlay scroller into a custom one):threadMinimap.css: the minimap list (cmux-next agent pane: the minimap lights where you are and the message it previews #22879) setscrollbar-width: noneand::-webkit-scrollbar { display: none }.pages/apps/styles.css: the narrow Discover chips strip setscrollbar-width: none.Both now keep the shared thin overlay scroller, hidden until the user scrolls. The minimap keeps its edge fades and
overscroll-behavior: contain. Removing only the minimap's two would leave 11, still over the ceiling, so the chips line goes too. The check is now at 10 (warnings only; the rest are Swift ratchet debt).Tests
SCROLLBARS_WARN_MAX=10 scripts/cmux-next/check-scrollbars.shon this branch: passes (10 warnings), and on feat-cmux-next it fails (13 hits).No capture: webview CSS only; a scroller that shows only while scrolling, no change at rest.
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
cmux-nextcheck-scrollbarsfailure (13 hits over its ceiling of 10) by stopping the minimap rail and Apps Discover chips from hiding their scrollbars.Both hid them with
scrollbar-width: noneand, for the minimap,::-webkit-scrollbar { display: none }— rules that turn WebKit's overlay scroller into a custom one, whichSCROLLBARS-THINforbids. They now keep the shared thin overlay scroller, hidden until the user scrolls, so there's no visual change at rest. The minimap keeps its edge fades andoverscroll-behavior: contain; the check drops to 10 warnings.Tests
SCROLLBARS_WARN_MAX=10 scripts/cmux-next/check-scrollbars.shpasses on this branch and fails onfeat-cmux-next(13 hits).Written for commit 3ca83c7. Summary will update on new commits.