Skip to content

test(acpmux): bare-pr-refs gives the code block's highlighter customElements, so it never fails on a slow runner #23251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 3 commits into from
Oct 21, 2026
Merged

test(acpmux): bare-pr-refs gives the code block's highlighter customElements, so it never fails on a slow runner #23251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2815682
test(acpmux): bare-pr-refs loads the code block's highlighter inside …
teamleaderleo Oct 21, 2026
5a94733
test(acpmux): bare-pr-refs' DOM gives the code block's highlighter cu…
teamleaderleo Oct 21, 2026
32e07ce
test(acpmux): bare-pr-refs reads the code block from its highlighted …
teamleaderleo Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions webviews/test/bare-pr-refs.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,19 @@ const keys = [
"Node",
"MutationObserver",
"ResizeObserver",
"customElements",
"getComputedStyle",
"localStorage",
"requestAnimationFrame",
"cancelAnimationFrame",
"IS_REACT_ACT_ENVIRONMENT",
] as const;
const saved = keys.map((key) => [key, key in scope, scope[key]] as const);
// The code block's highlighted card (@pierre/diffs) defines its web component on import and builds
// its lines with the DOM's constructors (as in render-fence.test.tsx).
const domConstructors = Object.getOwnPropertyNames(dom.window).filter(
(key) => /^(HTML|SVG|CSS|Shadow|Document)/.test(key) && !(key in scope) && !(keys as readonly string[]).includes(key),
);
const saved = [...keys, ...domConstructors].map((key) => [key, key in scope, scope[key]] as const);
beforeAll(() => {
Object.assign(scope, {
window: dom.window,
Expand All @@ -33,6 +39,8 @@ beforeAll(() => {
Element: dom.window.Element,
Node: dom.window.Node,
MutationObserver: dom.window.MutationObserver,
customElements: dom.window.customElements,
...Object.fromEntries(domConstructors.map((key) => [key, (dom.window as unknown as Record<string, unknown>)[key]])),
ResizeObserver: class {
observe() {}
unobserve() {}
Expand Down Expand Up @@ -131,10 +139,20 @@ test("a bare #N in a reply links to the pull request and opens its card", async

test("a reference in a code span or a code block is not a link", async () => {
const view = await render("Prose #634, code `#635` and `a/b#636`.\n\n```\n#637 a/b#638\n```\n", REPO);
// The code block's highlighted card loads after the first frame (CodeBlock.tsx): load it here, so
// it always lands inside this test, not whenever the import settles (on a slow runner, mid-test),
// and read the code where the card draws it, in its shadow root.
const { act } = await import("react");
const { loadHighlightedCode } = await import("../src/agent-session/acpmux/conversation/CodeBlock");
await act(async () => {
await loadHighlightedCode();
});
const code = view.element.querySelector("diffs-container")?.shadowRoot;
const chips = [...view.element.querySelectorAll<HTMLAnchorElement>("a.cv-chip")];
expect(chips.map((chip) => chip.getAttribute("href"))).toEqual([URL]);
expect(view.element.textContent).toContain("#635");
expect(view.element.textContent).toContain("#637 a/b#638");
expect(code?.querySelector("[data-content]")?.textContent).toBe("#637 a/b#638");
expect(code?.querySelectorAll("a")).toHaveLength(0);
});

test("without the folder's remote, a bare #N takes the repository the transcript mentioned last", async () => {
Expand Down