Repository navigation
Revert "base autofix: finish each run and land it on the newest tip" - #23227
Closed
teamleaderleo wants to merge 1 commit into
Closed
teamleaderleo wants to merge 1 commit into
teamleaderleo wants to merge 1 commit into
Conversation
Collaborator
Author
|
Bead |
|
Found 4 test failures on Blacksmith runners: Failures
|
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 9aa00c6; does not block |
Collaborator
Author
|
codex-review: SHIP at cf707d9\n\nReviewed the deliberate base-autofix workflow revert and its shell/Python coverage; no additional correctness issue found. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Takes back #22004: it merged at 9f1ec6a without no SHIP review receipt on the head.
Opened by merge-audit (leo-workspace tools/merge_audit.py), which never merges it. To keep #22004 instead, add the missing evidence for 9f1ec6a on #22004 (an independent review's
Review (subagent, correctness first): SHIP at <head>comment, a green compile, a risk tier; for a compile the router skipped,land-nowfrom a maintainer); the next audit pass then closes this PR. Otherwise review and land it.Changelog
none
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Reverts #22004, which landed without a SHIP review on its head commit. This restores the previous base autofix behavior: the run re-applies its repair onto the newest
feat-cmux-nexttip instead of pushing throughscripts/cmux-next/base-autofix-push.sh.base-autofix-push.shand its shell test.cmux-next-base-autofix.ymljob gets back the inline reapply-and-retry loop, andtests/test_cmux_next_base_autofix_finishes.pytests that loop directly instead of the script.To keep #22004 instead, add the missing review evidence to it (an independent SHIP comment and green compile); the next audit pass then closes this PR.
Written for commit cf707d9. Summary will update on new commits.