Skip to content

Revert "base autofix: finish each run and land it on the newest tip" - #23227

Closed
teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
revert/pr-22004
Closed

teamleaderleo wants to merge 1 commit into
feat-cmux-nextfrom
revert/pr-22004

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Takes back #22004: it merged at 9f1ec6a without no SHIP review receipt on the head.

Opened by merge-audit (leo-workspace tools/merge_audit.py), which never merges it. To keep #22004 instead, add the missing evidence for 9f1ec6a on #22004 (an independent review's Review (subagent, correctness first): SHIP at <head> comment, a green compile, a risk tier; for a compile the router skipped, land-now from a maintainer); the next audit pass then closes this PR. Otherwise review and land it.

Changelog

none


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Reverts #22004, which landed without a SHIP review on its head commit. This restores the previous base autofix behavior: the run re-applies its repair onto the newest feat-cmux-next tip instead of pushing through scripts/cmux-next/base-autofix-push.sh.

  • Removes base-autofix-push.sh and its shell test.
  • The cmux-next-base-autofix.yml job gets back the inline reapply-and-retry loop, and tests/test_cmux_next_base_autofix_finishes.py tests that loop directly instead of the script.

To keep #22004 instead, add the missing review evidence to it (an independent SHIP comment and green compile); the next audit pass then closes this PR.

Written for commit cf707d9. Summary will update on new commits.

View guided diff Turn on auto-fix

@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-12h3z created for this PR by the cmux coordinator.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp2cm228nc/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpar93mcbw/summary-missing.json (live):/summary-missing.json (live): View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextHomeEngineTests')/
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextHomeEngineTests')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 9aa00c6; does not block

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

codex-review: SHIP at cf707d9\n\nReviewed the deliberate base-autofix workflow revert and its shell/Python coverage; no additional correctness issue found.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Not needed: #22004 now has its evidence. It has an independent review receipt (Review (subagent, correctness first): SHIP at 9f1ec6a4e00f7fefd105d4575ca19d0446d957c4), a green compile and a risk tier. Closing this revert.

Agent session: huge-blue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant