Skip to content

Gallery: a subagent's own pane, read only (covers SubagentPaneFooter; fixes gallery-coverage on base) - #23218

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/subagent-pane-footer-gallery
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/subagent-pane-footer-gallery

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

gallery-coverage fails on feat-cmux-next for every PR that touches webviews: #22986 added subagents/SubagentPaneFooter.tsx#SubagentPaneFooter without a gallery entry.

  • subagents.gallery.ts covers it and adds an own-pane variant: the pane gets a subagent: reveal (as when the app opens a subagent's pane), shows that subagent's view under the Subagent of pill, and draws the read-only footer line naming the chat instead of the composer. The play fails if the composer is drawn.

Agent session: cosmic-gray

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes gallery-coverage on feat-cmux-next by covering SubagentPaneFooter, which #22986 added without a gallery entry.

Adds an own-pane variant to the subagents gallery that opens a subagent's view read-only via a subagent: reveal, verifies the footer line naming the chat appears in place of the composer, and fails if the composer is drawn.

Written for commit ef1f447. Summary will update on new commits.

View guided diff Turn on auto-fix

…s SubagentPaneFooter)

#22986 added SubagentPaneFooter without a gallery entry, so gallery-coverage
fails on feat-cmux-next. The subagents entry gets an own-pane variant: a
subagent: reveal opens the child's view read only, the footer in place of the
composer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15d18-aabc-7850-af29-f0655b1d2a1a&host=cosmic-gray
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review ef1f447: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23218 -f ref=cmux/subagent-pane-footer-gallery -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. CI was cancelled before it finished.

CI stopped on ef1f447375 (run 39571734361 attempt 1): 2 code, 1 unknown.

Job Verdict Why
web / react-apps-check (2) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs composer-claude-split.test.ts chromium: + is its glyph, named Add with no tooltip: failed (job)
  • seen on other PRs composer-claude-split.test.ts webkit: + is its glyph, named Add with no tooltip: failed (job)
  • seen on other PRs diff-toolbar-narrow.test.ts at 460 px the base picker's label stays in its chip, clear of jump-to-file: failed (job)
Matched log lines
web / react-apps-check (2): (fail) chromium: + is its glyph, named Add with no tooltip [2080.76ms]
web / react-apps-check (1): (fail) at 460 px the base picker's label stays in its chip, clear of jump-to-file [241.27ms]

Not re-run automatically: web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on eac59b5 to compare; do not merge until green; see lane-rules
red: web / Web status; NEW: green on the base eac59b5; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on eac59b5 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (1); no finished base run on eac59b5 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on eac59b5 to compare; do not merge until green; see lane-rules

Tour of ef1f447375 (run): no media. The tour did not run: only webview code changed (1 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by subsession-visibility-2 on cosmic-gray · session

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 8 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp_1fvdtnj/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpg8ux21_o/summary-missing.json (live):/summary-missing.json (live): View Logs
convention violations found (ERROR lines above)./
convention violations found (ERROR lines above).
View Logs
test/composer-claude-split.test.ts/composer-claude-split.test View Logs
test/composer-claude-split.test.ts/composer-claude-split.test View Logs
test/diff-toolbar-narrow.test.ts/diff-toolbar-narrow.test View Logs
test/diff-toolbar-narrow.test.ts/diff-toolbar-narrow.test View Logs
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextHomeEngineTests')/
test_every_source_and_test_directory_is_a_target (main.GraphCoversThePackage.test_e
very_source_and_test_directory_is_a_target) (directory='CmuxNextHomeEngineTests')
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-w96ax created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next / cmux-next checks (god files, concurrency, crash safety, l10n) › Tier routing is red on 7 of 10 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@teamleaderleo
teamleaderleo merged commit 29c6727 into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/subagent-pane-footer-gallery branch October 21, 2026 09:20
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

codex-review: SHIP at ef1f447\n\nReviewed the gallery-only subagent pane coverage change; no correctness bug found.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant