cmux-next Chief: Subagents menu rows run chief.openSubagent, not an inline selector by teamleaderleo · Pull Request #23073 · manaflow-ai/cmux

teamleaderleo · 2026-10-21T06:38:40Z

check-menu-actions.py (the "Menu rows run registered actions, not inline selectors" step of cmux-next guards) fails on feat-cmux-next because the Chief pane's Subagents menu built its rows with an inline #selector(openSubagent(_:)). This PR makes each row run a new registered action, chief.openSubagent, so that check passes. The rows behave the same as before.

New action: chief.openSubagent ("Open Chief Subagent") goes in SidebarSectionActionCatalog. Its target is the subagent row's sidebar item (sidebar-item:<id>). It is exempt from the palette and CLI verb as focusMove, like home.openConversation. Its title is translated into the catalog's 21 languages.
Binding: ChiefSidebar.bind binds it to the existing activate(LayoutItemID(target.id), registry:) path, the same path a click on the sidebar row takes.
Menu rows: ChiefPaneTools.subagentsMenu() builds each row through registry.makeContextMenu, then sets the subagent's own title and status tooltip, with no icon and no key. The @objc openSubagent selector is gone.
Behavior: a row is now enabled only while the action is bound and allowed by policy. In the app it is always bound, so nothing visible changes.
Generated files: the action exports (plans/cmux-next/action-surfaces.json, actions.md) are regenerated by PR autofix on a Mac runner, not by hand.

Testing

Red, on base 92d14b2: python3 scripts/cmux-next/check-menu-actions.py fails on ChiefPaneTools.swift, the same failure as the base red.
Green, on head: the same command passes with "38 inline menu rows in 29 baselined files, none new".
New test: HomeDockTabRowToolsTests.eachSubagentRowOpensItsSessionThroughTheRegisteredAction (commit 1). It checks through ActionRegistry.menuRun(of:) that each row runs chief.openSubagent on its own sidebar-item:<row id> with no arguments, and that each row keeps its title and tooltip.

Observed / Not run

Observed: check-menu-actions.py passes, prepush-gate.py reports no new violations and check-no-godfiles.sh passes on the changed files. localization_catalog.py check fails exactly as it does on base, with no error in the files changed here.
Not run: no Swift compile or tests locally (Mac compiles run on CI). The new test, ActionSurfaceParityTests and ActionContractTests run on CI.

Changelog

none

Agent session: huge-blue

🤖 Generated with Claude Code

^{Need help on this PR? Tag @codesmith-bot with what you need.}

Summary by cubic

The Chief pane's Subagents menu rows now run the registered chief.openSubagent action through the action registry, instead of an inline selector, so the check-menu-actions.py guard passes. Rows behave identically to before.

New chief.openSubagent action binds to the same activation path as a click on the sidebar row; its target is the row's sidebar-item:<id>, and it is exempt from the palette and CLI verb as focusMove.
Menu rows are rebuilt from the registry, then retitled with the subagent's own title and status tooltip, with no icon or key.
Added tests asserting each row runs the action on its own row's sidebar item with no arguments, and that the action is not a palette row.
A row is enabled only while the action is bound and allowed by policy; in the app it is always bound, so nothing visible changes.

^{Written for commit 2b76082. Summary will update on new commits.}

…ubagent The Chief pane's Subagents menu (#22852) builds its rows with an inline selector, which scripts/cmux-next/check-menu-actions.py rejects: ChiefPaneTools.swift: 1 inline menu row(s), 0 allowed This test pins the shape the fix gives the rows: each runs the registered chief.openSubagent action on its row's sidebar item, titled and described like its sidebar row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

…nline selector check-menu-actions.py was red on base: #22852's ChiefPaneTools.subagentsMenu built each row with its own #selector(openSubagent(_:)), a menu-only path beside the registry. Each row now comes from ActionRegistry.makeContextMenu(for: .sidebarItem, target:, entries:) and runs the new chief.openSubagent action on the row's sidebar item (target sidebar-item:<row id>), retitled to the subagent as menuRun's callers do. ChiefSidebar binds the action to the same activate path a click on the sidebar row runs: reveal the subagent's tab, else open a workspace on it. Title and tooltip are unchanged; the row has no icon and no key equivalent. Palette, CLI verb and right-click are exempt as focusMove (it shows an existing subagent; `cmux action run chief.openSubagent --target sidebar-item:<id>` reaches it). Generated action exports are left to the autofix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

teamleaderleo · 2026-10-21T06:38:57Z

Owned by land-and-ci-a8 on huge-blue · session

github-actions · 2026-10-21T06:39:08Z

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 2b76082: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23073 -f ref=cmux/chief-subagents-menu-action -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on 2b76082600; ci-status is green without them.

CI passes on 2b76082600 (run 39557241522 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

teamleaderleo · 2026-10-21T06:40:48Z

Bead cx-2dwnn created for this PR by the cmux coordinator.

…te row Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

github-actions · 2026-10-21T07:06:14Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39558816819 at c7ce585 failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at 233cc81. This pull request is one of 4 merged since: #23065, #23050, #23073, #22992.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

github-actions · 2026-10-21T07:11:29Z

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/39559424526 at 240de48 failed: cmux-next Release compile (Xcode 26).
Those jobs last passed at 233cc81. This pull request is one of 5 merged since: #23065, #23050, #23073, #22992, #23062.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

… no target Follow-ups to #23073. Open Chief Subagent shows a subagent's tab or opens a workspace on it, so it joins ActionCatalog.focusActionIDs and action.list reports it as focusing. A run with no target (its shortcut, `cmux action run` without --target) now refuses through ActionRegistry.refuse, as other handlers do: a keyboard run shows the reason in the refusal HUD, and the palette and the control socket get it back. A target that is not a subagent row refuses as not found. The reason is localized in the 21 locales of the CmuxNextAgentLanes catalog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

… no target (#23108) * test: chief.openSubagent focuses, and a run with no subagent refuses visibly Two follow-ups to #23073. Open Chief Subagent shows a subagent's tab or opens a workspace on it, so action.list should report it as focusing; it does not (ActionCatalog.focusActionIDs lacks it). And a run with no target (its shortcut, `cmux action run chief.openSubagent` without --target) returns from the handler without a word: no notice for a keyboard run, no reason for a caller. These tests pin both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue * cmux-next Chief: chief.openSubagent focuses, and refuses visibly with no target Follow-ups to #23073. Open Chief Subagent shows a subagent's tab or opens a workspace on it, so it joins ActionCatalog.focusActionIDs and action.list reports it as focusing. A run with no target (its shortcut, `cmux action run` without --target) now refuses through ActionRegistry.refuse, as other handlers do: a keyboard run shows the reason in the refusal HUD, and the palette and the control socket get it back. A target that is not a subagent row refuses as not found. The reason is localized in the 21 locales of the CmuxNextAgentLanes catalog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

github-actions · 2026-10-21T11:24:44Z

Shipped in:

cmux NEXT nightly 1.0.0-nightly.3958372135301 (bc661dae0e)

teamleaderleo and others added 2 commits October 21, 2026 06:33

teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026

test: Open Chief Subagent is a row of the Subagents menu, not a palet…

2b76082

…te row Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue

teamleaderleo merged commit 988c5bb into feat-cmux-next Oct 21, 2026

teamleaderleo deleted the cmux/chief-subagents-menu-action branch October 21, 2026 06:58

This was referenced Oct 21, 2026

cmux NEXT menus: downloads, reload, history and device menus take the glass highlight and icons #23106

Merged

cmux-next Chief: chief.openSubagent focuses, and refuses visibly with no target #23108

Merged

This was referenced Oct 21, 2026

cmux-next: chat header tools sit on a tight 24px pitch, like macOS and Codex toolbars #23065

Merged

cmux NEXT browser: Downloads popup under its toolbar button, draggable rows; Chromium's bubble off #23050

Merged

github-actions Bot mentioned this pull request Oct 21, 2026

cmux-next: restyle the Extensions menu (site-access groups, two-line rows, accent pin, store link) #22992

Merged

github-actions Bot mentioned this pull request Oct 21, 2026

Agent chat: the WebKit scroll-up test reads the offset after the wheel glide settles (base red) #23062

Merged

This was referenced Oct 21, 2026

cmux-next bookmarks: the manager's more menu draws the shared ⋮ glyph #23049

Merged

cmux NEXT: a torn-off chat's window takes the chat's name, not workspace-N #22130

Merged

Navigation Menu

Repository navigation

cmux-next Chief: Subagents menu rows run chief.openSubagent, not an inline selector - #23073

cmux-next Chief: Subagents menu rows run chief.openSubagent, not an inline selector#23073
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
cmux/chief-subagents-menu-action

teamleaderleo commented Oct 21, 2026 •

edited by cubic-dev-ai Bot

Loading

Uh oh!

teamleaderleo commented Oct 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

teamleaderleo commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

teamleaderleo commented Oct 21, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing

Observed / Not run

Changelog

Summary by cubic

Uh oh!

teamleaderleo commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teamleaderleo commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

teamleaderleo commented Oct 21, 2026 •

edited by cubic-dev-ai Bot

Loading

teamleaderleo commented Oct 21, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading