Repository navigation
webviews: the Options chip truncates only when its row is full (chip-fixed-width, agent-pane-no-capsules base reds) - #23068
teamleaderleo wants to merge 2 commits into
Conversation
…akes its row's pill shape (two base reds) fe0e57b added the composer's Options chip with a 180px cap on its face and the access chip's 999px radius. chip-fixed-width (Leo 2026-10-20: chips truncate only when the row is full) and agent-pane-no-capsules (pills only for the composer's chip family) went red on base. The face now shrinks with the row and ellipsizes there; the chip is listed with the model, effort and access chips it sits beside, whose pill is the Claude app's (#22107). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfb-0392-7f93-b611-98366b6dc130&host=cosmic-gray
|
Owned by projects-c6 on cosmic-gray · session |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; base red: the same failure on the base 1f14051; does not block
Agents: |
|
|
|
Bead |
…ves up text, and the chip keeps a floor Review of #23068: as the row's only shrinking item, the Options chip took the whole shortfall first, hid the overflow from composerRowFit (so no label stepped down) and could shrink to nothing. The row now counts the face's whole width (data-fit-natural), and the chip stops at the New Tab model chip's 56px floor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15cfb-0392-7f93-b611-98366b6dc130&host=cosmic-gray
|
Found 20 test failures on Blacksmith runners: Failures
...and 10 more test failures. View all on Blacksmith
|
|
Superseded by 1e71433 on feat-cmux-next, which fixed the same two base reds (chip-fixed-width, agent-pane-no-capsules) another way: the Options chip became a small-radius rect with no 180px cap. This PR now conflicts with it. At f957397 both tests pass on Linux Chromium/WebKit with Unifont and with default fonts, so neither red comes from the font. What this PR adds beyond that (composerRowFit counting the face's full width, so the row hides its labels before the Options face ellipsizes) does not fix a red. It is not carried forward here. |
Two webview tests have been red on feat-cmux-next since fe0e57b (pushed directly to base) added the composer's Options chip. This PR fixes both. Neither has the font or metrics cause that compaction-rows is fixing; both are stylesheet rules the tests read.
chip-fixed-widthcomposerControls.css .acpmux-options-text => 180pxflex: 0 1 auto; min-width: 0, buttonmax-width: 100%) and ellipsizes only when the row is full, as #22731 did for the other chips. In the chat bar a more specific rule wins over the bar's> span { overflow: visible }so the face still ellipsizes.agent-pane-no-capsules.acpmux-options .acpmux-picker-button (radius 999px, height 28px)Changelog
Observed / Not run
scripts/web-lint.sh: clean on these files (the one warning is base'sHistoryPage.tsxjsx-a11y).prepush-gate.py: no new violations.Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes two webview tests that went red when the composer's Options chip was added to base.
data-fit-naturalmarker) so label steps occur before the chip gives up any text, and the chip keeps a 56px floor.agent-pane-no-capsulespill list alongside the model, effort, and access chips, since it deliberately takes the access chip's shape.Written for commit 6204e92. Summary will update on new commits.