Repository navigation
cmux NEXT settings: Priority view's summary fits 60 characters in every language (react-apps-check red) - #23028
Merged
Conversation
… fr, it, pl and pt-BR rowSummary.test.tsx is red on base ac7cf07: the summary #22778 added ran 61-75 characters in five languages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
Collaborator
Author
|
Owned by land-and-ci-60 on huge-blue · session |
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
Collaborator
Author
|
Bead |
teamleaderleo
added a commit
that referenced
this pull request
Oct 21, 2026
…made it stale (defaults-snapshot base red) (#23056) * test: check-stamp fails a pull request only for the settings sources it changed Red: defaults-snapshot fails every pull request and base push while the base autofix catches up (base 6143f81: stale for Localizable.xcstrings, NotificationModes.swift, NotificationPreferences.swift and SettingsSchema+Appearance.swift, none of them changed by those PRs), and the message points at a REPAIR.md row this repository does not have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue * cmux-next guards: a stale settings export fails only the event that changed its source defaults-snapshot ran check-stamp on the whole tree, so once a merge landed a settings source without its exports (d986b17, #22678, #23028; none changed a default), every pull request and every base push was red until the base autofix caught up, which merges minutes apart kept from happening for hours. check-stamp --base now fails only for sources changed since the base (the merge commit's base tip, or a push's parent) and prints the inherited ones as a warning. The stale message names the PR autofix and regenerate-settings-exports.sh instead of a REPAIR.md row this repository does not have. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue * cmux-next generated files: inherited stale settings exports warn here too; #22275 follow-ups The generated-files job's check-stamp failed every pull request on the base's stale exports the same way; it now passes --base HEAD^1 as defaults-snapshot does. #22275's review follow-ups: autofix-areas.sh, regenerate-settings- exports.sh and the generated-files comments still described check-fresh and the snapshot, and the fork hint's `git commit -am` left files the patch adds unstaged (now `git apply --index`). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue * test: check-stamp --base fails a head's own stamp edit and passes past 20 inherited sources Red (review of #23056): a head that takes an old stamp passes as stale on the base, and with over 20 stale sources the "and N more" line fails every head. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue * defaults guard: check-stamp --base judges each stale source before the list is cut The inherited split ran on the printed lines: a head whose own stamp entry differs from the base's passed as stale on the base, and past 20 sources the "and N more" line failed every head. stamp_freshness now splits the full list and needs both the source bytes and the stamp entry to be the base's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Shipped in:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a base red in react-apps-check:
webviews/src/pages/settings/rowSummary.test.tsxfails two tests onfeat-cmux-nextbecause the Priority view summary that #22778 added (settings.sidebar.priorityView.enabled.summary) runs over the 60-character limit in five languages.Only the source catalog changes. If the settings exports' source stamp drifts, the base autofix regenerates it.
The command is
bun test src/pages/settings/rowSummary.test.tsx, run fromwebviews/with bun 1.4.2. On base ac7cf07 it fails 2 tests ("no description line on any Settings page is over 60 characters, in any language" and "every schema summary fits 60 characters in every language"). On this head it passes all 3.Observed / Not run
prepush-gate.pyreports no new violations.Changelog
none
Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the red
react-apps-checkonfeat-cmux-nextby shortening the Priority view's summary translations in Spanish, French, Italian, Polish, and Brazilian Portuguese so they fit the 60-character limit enforced byrowSummary.test.tsx.Only the source catalog changes in
Packages/macOS/CmuxNext/Sources/CmuxNextSettings/Localizable.xcstrings; if the settings exports' source stamp drifts, the base autofix regenerates it.Written for commit 3526c15. Summary will update on new commits.