Repository navigation
Agent chat: an edit of several files reads "Edit 2 files", not its first file; adopted tool-calls test follows #22658 - #23011
Conversation
…-file patch row names both (red) #22658 stopped folding an ended turn's run under one summary line, so the test no longer clicks "Edited files, ran commands" or the already open commands group. With no diff, the patch-only edit keeps its own row, and that row must not name only its first file. Red on base: it reads "Edit CHANGELOG.md" for an edit of CHANGELOG.md and Cargo.toml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
…f naming the first file A lone edit with no diff keeps its own row (#22658 lists each call under Worked for). toolLabel put the action before the edit's first path, so a patch of CHANGELOG.md and Cargo.toml read "Edit CHANGELOG.md". An edit naming more than one path now keeps the harness's title, "Edit 2 files"; an edit of one file still reads "Edit <its path>". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
|
owner: 01a15c2c-32f4-7bb3-97e5-4c17864ff52e on huge-blue |
|
owner: 01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d on huge-blue |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base ac7cf07; does not block Tour of |
…first file (red) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
… first file's name Review of #23011: a bare "Edit" or "patch" title over two files lost its file name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
|
Bead |
|
Shipped in:
|
agent-pane-adopted-tool-calls.test.tshas been red on feat-cmux-next since at least 03:03Z. It's in the base react-apps-check failure list for run 39549244554. It covers two problems:toolLabel(toolPaths.ts) built the row as the action plus the edit's first path. A patch ofCHANGELOG.mdandCargo.tomlread "Edit CHANGELOG.md", as if it edited one file. Now an edit that names more than one path keeps the harness's own title ("Edit 2 files"), and an edit of one file still reads "Edit ".This is not the duplicated live status row (WorkingFor.tsx /
row.doing) that activity-indicators is fixing. I told that lane this PR touches only this test andtoolLabel.Testing
CMUX_BROWSER_TESTS=1 bun test test/agent-pane-adopted-tool-calls.test.tsinwebviews/(Linux, bun 1.4.2):29ffea7f8e9: 0 pass, 2 fail (both time out on the missing "Edited files, ran commands" button).8ca9b496c2d46b24018116f7c4822a1e257b050c(red): 1 pass, 1 fail,Expected: "Edit 2 files",Received: "Edit CHANGELOG.md".Also run:
test/transcript-density.test.tsx, the other browser test that reads tool row labels: 4 pass.bun test src/agent-session/acpmux: the same 28 failures with and without the fix (base, environment-dependent), so no new ones.prepush-gate.pyis clean.scripts/web-lint.shhas one finding outside this PR: ajsx-a11y(prefer-tag-over-role)warning atwebviews/src/pages/history/HistoryPage.tsx:177, red on base29ffea7f8e9. I pushed withCMUX_WEB_LINT_SKIP_REASONnaming it.Observed / Not run
Observed: everything above. Not run: CI on this head. Other callers of
toolLabel(turns.ts, the running line and find text) now show "Edit 2 files" for multi-file edits that have a title. I didn't capture that in the app.Changelog
Agent session: huge-blue
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes agent chat so an edit naming multiple files reads "Edit 2 files" instead of naming only the first file, and updates the adopted tool-calls test to follow #22658's open groups layout.
A title that says only its verb ("Edit", "patch") over several files still names the first file; the new
tool-label-several-files.test.tscovers both cases.Written for commit 475616c. Summary will update on new commits.