Skip to content

Agent chat: an edit of several files reads "Edit 2 files", not its first file; adopted tool-calls test follows #22658 - #23011

Merged
teamleaderleo merged 5 commits into
feat-cmux-nextfrom
cmux/adopted-tool-calls-test
Oct 21, 2026
Merged

teamleaderleo merged 5 commits into
feat-cmux-nextfrom
cmux/adopted-tool-calls-test

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

agent-pane-adopted-tool-calls.test.ts has been red on feat-cmux-next since at least 03:03Z. It's in the base react-apps-check failure list for run 39549244554. It covers two problems:

This is not the duplicated live status row (WorkingFor.tsx / row.doing) that activity-indicators is fixing. I told that lane this PR touches only this test and toolLabel.

Testing

CMUX_BROWSER_TESTS=1 bun test test/agent-pane-adopted-tool-calls.test.ts in webviews/ (Linux, bun 1.4.2):

  • Base 29ffea7f8e9: 0 pass, 2 fail (both time out on the missing "Edited files, ran commands" button).
  • Test commit 8ca9b496c2d46b24018116f7c4822a1e257b050c (red): 1 pass, 1 fail, Expected: "Edit 2 files", Received: "Edit CHANGELOG.md".
  • Fix (head): 2 pass.

Also run:

  • test/transcript-density.test.tsx, the other browser test that reads tool row labels: 4 pass.
  • bun test src/agent-session/acpmux: the same 28 failures with and without the fix (base, environment-dependent), so no new ones.
  • prepush-gate.py is clean.
  • scripts/web-lint.sh has one finding outside this PR: a jsx-a11y(prefer-tag-over-role) warning at webviews/src/pages/history/HistoryPage.tsx:177, red on base 29ffea7f8e9. I pushed with CMUX_WEB_LINT_SKIP_REASON naming it.

Observed / Not run

Observed: everything above. Not run: CI on this head. Other callers of toolLabel (turns.ts, the running line and find text) now show "Edit 2 files" for multi-file edits that have a title. I didn't capture that in the app.

Changelog

  • Fixed: in agent chat, an edit of several files reads "Edit 2 files" instead of naming only the first file.

Agent session: huge-blue

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes agent chat so an edit naming multiple files reads "Edit 2 files" instead of naming only the first file, and updates the adopted tool-calls test to follow #22658's open groups layout.

A title that says only its verb ("Edit", "patch") over several files still names the first file; the new tool-label-several-files.test.ts covers both cases.

Written for commit 475616c. Summary will update on new commits.

View guided diff Turn on auto-fix

teamleaderleo and others added 2 commits October 21, 2026 05:41
…-file patch row names both (red)

#22658 stopped folding an ended turn's run under one summary line, so the test no longer clicks
"Edited files, ran commands" or the already open commands group. With no diff, the patch-only
edit keeps its own row, and that row must not name only its first file. Red on base: it reads
"Edit CHANGELOG.md" for an edit of CHANGELOG.md and Cargo.toml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
…f naming the first file

A lone edit with no diff keeps its own row (#22658 lists each call under Worked for). toolLabel
put the action before the edit's first path, so a patch of CHANGELOG.md and Cargo.toml read
"Edit CHANGELOG.md". An edit naming more than one path now keeps the harness's title, "Edit 2
files"; an edit of one file still reads "Edit <its path>".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c2c-32f4-7bb3-97e5-4c17864ff52e on huge-blue

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d on huge-blue

@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 475616c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr23011 -f ref=cmux/adopted-tool-calls-test -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. This PR merged before its CI finished: fix forward on main.

CI failed on 475616ce4b (run 39552097569 attempt 1): 4 code, 1 unknown.

Job Verdict Why
web / react-apps-check (3) code a web test failed
web / react-apps-check (2) code a web test failed
web / react-apps-check (4) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs composer-mention.test.ts @ then letters lists the chat's matching files and Return writes the path: failed (job)
  • seen on other PRs composer-mention.test.ts after picking a path markdown escapes, typing on leaves the picker closed: failed (job)
  • seen on other PRs composer-mention.test.ts @proje lists other chats, then folders, then the chat folder's files: failed (job)
  • seen on other PRs composer-mention.test.ts a chat named for a long prompt does not take @app from the file: failed (job)
  • seen on other PRs composer-mention.test.ts a bare @ lists the most recent other chats: failed (job)
  • seen on other PRs composer-mention.test.ts an @ inside a word opens nothing and asks the host for nothing: failed (job)
  • seen on other PRs agent-pane-queue-steer.test.ts queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or draw...: failed (job)
  • seen on other PRs agent-pane-stream-jitter.test.ts webkit: scrolling up while a reply streams is never pulled back: failed (job)
  • seen on other PRs composer-location-strip.test.ts the chat composer at 420 px: the strip's marks line up with the prompt's edges: failed (job)
  • seen on other PRs composer-location-strip.test.ts the chat composer at 760 px: the strip's marks line up with the prompt's edges: failed (job)
  • ... 11 more in the job logs
Matched log lines
web / react-apps-check (3): (fail) @ then letters lists the chat's matching files and Return writes the path [2321.33ms]
web / react-apps-check (2): (fail) queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or drawn over [1321.25ms]
web / react-apps-check (4): (fail) no description line on any Settings page is over 60 characters, in any language [14432.14ms]
web / react-apps-check (1): (fail) ↑ and ↓ in an empty prompt step through the chat's earlier prompts [1688.72ms]

Not re-run automatically: web / react-apps-check (3), web / react-apps-check (2), web / react-apps-check (4), web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base ac7cf07; does not block
red: web / Web status; NEW: green on the base ac7cf07; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on ac7cf07 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (1); no finished base run on ac7cf07 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on ac7cf07 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (3); no finished base run on ac7cf07 to compare; do not merge until green; see lane-rules
red: web / react-apps-check (4); no finished base run on ac7cf07 to compare; do not merge until green; see lane-rules

Tour of 475616ce4b (run): no media. The tour did not run: only webview code changed (3 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

teamleaderleo and others added 2 commits October 21, 2026 05:49
… first file's name

Review of #23011: a bare "Edit" or "patch" title over two files lost its file name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c6d-a1d2-7fc2-9458-92c6bdcb7b4d&host=huge-blue
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-3zt2k created for this PR by the cmux coordinator.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant