Repository navigation
cmux-next sidebar: a click moves no row, and a move changes the order once - #22960
Conversation
…the order once Red on base: selecting a row outside a collapsed group drops the group's shown member, and a reorder nobody asked for shows with the click. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
owner: 01a15bf1-fd7b-72c2-917a-29462227f501 on cosmic-gray |
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by |
|
Bead |
… once - A collapsed group keeps drawing a member the selection leaves (revealedMembers) until it folds or opens, so a click elsewhere removes no row. - A selection that arrives with a row change nobody asked for draws the selection only; the rows wait under the pointer like any other such change. - Switching to a workspace whose row is listed skips the walk of every row. - A reorder on the daemon path shows through a pending edit, so no command echo shows a step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
…when it opens; the tests cover a full layout and the held change Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Shipped in:
|
In progress: the test commit is pushed, and the fix is next.
Leo (2026-10-20): moving between sidebar rows or clicking them causes "unnecessary multi-sidebar walks": the rows jump, then settle. The rule:
Causes found (planned fixes)
move-workspaceecho showed an intermediate order. The fix adds the same pending edit the personal path uses.Test
Tests/CmuxNextAppTests/SidebarClickMovesNoRowTests.swift:SidebarRowsshows exactly two orders, the start and the final one, across the partial echo, the final echo and the settle.Commit 89cfe6f adds the tests alone; the first two should fail on base.
Observed / Not run
prepush-gate.pyreports no new violations.Changelog
Agent session: cosmic-gray
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes sidebar rows jumping then settling on clicks and moves: a click or selection now moves no row, and a move changes the order exactly once.
revealedMembers, tracked per group) until the group folds or opens, even across a later full layout, so clicking elsewhere removes no row.SidebarClickMovesNoRowTests.swiftcovering the collapse-group click, a full layout after it, a refold forgetting the member, a click landing with a waiting reorder, and a move drawing only the start and final orders.Written for commit 4b1b954. Summary will update on new commits.