Skip to content

test(acpmux): the queue-steer test clicks Send now by its name - #22931

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/queue-steer-test-send-now
Oct 21, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
cmux/queue-steer-test-send-now

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes a base red my #22805 caused. agent-pane-queue-steer.test.ts "Send now on a queued prompt keeps its row, reading Steering, until it runs" fails on feat-cmux-next (78aaa62, 2 of 2 runs, found by scroll-jitter). Since #22805 a queued row shows Edit, Remove and Send now, so the test's row.locator(".acpmux-queued-action").first() clicked Edit, and the row never read Steering. The test now clicks the row's Send now button by its accessible name. No product code changes.

Observed / Not run

  • Observed: the click target from the code. The first .acpmux-queued-action is Edit (ComposerQueue.tsx renders Edit, Remove, Send now in that order, and queue-row-actions.test.tsx asserts that order). vp fmt --check passes on the file.
  • Not run: this Chromium/WebKit browser test. Fleet light workers have no Playwright browsers, and the PR's react-apps-check shards are blocked by the base red cmux NEXT chief inspector: regenerate the committed page (base red after #22839) #22877 fixes.

Changelog

none

Agent session: cosmic-gray

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the queue-steer test so it clicks the row's "Send now" button by its accessible name instead of the first queued action, which after #22805 is Edit. The test now reliably observes the row reading Steering. No product code changes.

Written for commit b135098. Summary will update on new commits.

View guided diff Turn on auto-fix

Since #22805 a queued row shows Edit, Remove and Send now, so the test's
`.acpmux-queued-action` first() clicked Edit and its row never read
Steering ("Send now on a queued prompt keeps its row, reading Steering",
red on feat-cmux-next 78aaa62, 2 of 2 runs, found by scroll-jitter).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15bf1-fdce-7080-9410-46e242562329

1 similar comment
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15bf1-fdce-7080-9410-46e242562329

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review b135098: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22931 -f ref=cmux/queue-steer-test-send-now -f platform=macos -f backend_mode=local

Yours to fix: agent-pane-queue-steer.test.ts (a file this PR changes). Also failing here, not on main: composer-suggested-prompt.test.tsx. Seen on other PRs too (likely flaky): agent-pane-trust-ask-corner.test.ts, agent-pane-trust-ask-corner.test.ts, composer-mention.test.ts and 23 more. This PR merged before its CI finished: fix forward on main.

CI failed on b135098639 (run 39543568723 attempt 1): 4 code, 1 unknown.

Job Verdict Why
web / react-apps-check (3) code a web test failed
web / react-apps-check (2) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check (4) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs agent-pane-trust-ask-corner.test.ts the trust bar's corner is the composer card's: failed (job)
  • seen on other PRs agent-pane-trust-ask-corner.test.ts no caption stands between the open trust question and the card: failed (job)
  • seen on other PRs composer-mention.test.ts @ then letters lists the chat's matching files and Return writes the path: failed (job)
  • seen on other PRs composer-mention.test.ts after picking a path markdown escapes, typing on leaves the picker closed: failed (job)
  • seen on other PRs composer-mention.test.ts @proje lists other chats, then folders, then the chat folder's files: failed (job)
  • seen on other PRs composer-mention.test.ts a chat named for a long prompt does not take @app from the file: failed (job)
  • seen on other PRs composer-mention.test.ts a bare @ lists the most recent other chats: failed (job)
  • seen on other PRs composer-mention.test.ts an @ inside a word opens nothing and asks the host for nothing: failed (job)
  • seen on other PRs agent-pane-adopted-tool-calls.test.ts the adopted turn's Worked for opens to its commands and edited files: failed (job)
  • seen on other PRs agent-pane-adopted-tool-calls.test.ts a patch whose files only its input names counts each file, not one: failed (job)
  • ... 18 more in the job logs
Matched log lines
web / react-apps-check (3): (fail) the trust bar's corner is the composer card's [4651.60ms]
web / react-apps-check (2): (fail) the adopted turn's Worked for opens to its commands and edited files [31101.45ms]
web / react-apps-check (1): (fail) queued prompts from the keyboard > ⌘Return sends a queued prompt now; Delete removes one [31222.11ms]
web / react-apps-check (4): (fail) queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or drawn over [1493.77ms]

Not re-run automatically: web / react-apps-check (3), web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check (4), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; NEW: green on the base 9fdc56f; do not merge until green; see lane-rules
red: web / react-apps-check; no finished base run on 9fdc56f to compare; do not merge until green; see lane-rules
red: web / react-apps-check (1); no finished base run on 9fdc56f to compare; do not merge until green; see lane-rules
red: web / react-apps-check (2); no finished base run on 9fdc56f to compare; do not merge until green; see lane-rules
red: web / react-apps-check (3); no finished base run on 9fdc56f to compare; do not merge until green; see lane-rules
red: web / react-apps-check (4); no finished base run on 9fdc56f to compare; do not merge until green; see lane-rules

Tour of b135098639 (run): no media. The tour did not run: only webview code changed (1 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo
teamleaderleo merged commit fc1206a into feat-cmux-next Oct 21, 2026
@teamleaderleo
teamleaderleo deleted the cmux/queue-steer-test-send-now branch October 21, 2026 04:23
@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 26 test failures on Blacksmith runners:

Failures

Test View Logs
test/agent-pane-adopted-tool-calls.test.ts/agent-pane-adopted-tool-calls.test View Logs
test/agent-pane-adopted-tool-calls.test.ts/agent-pane-adopted-tool-calls.test View Logs
test/agent-pane-column-edges.test.ts/agent-pane-column-edges.test View Logs
test/agent-pane-column-edges.test.ts/agent-pane-column-edges.test View Logs
test/agent-pane-queue-steer.test.ts/agent-pane-queue-steer.test View Logs
test/agent-pane-queue-steer.test.ts/agent-pane-queue-steer.test View Logs
test/agent-pane-queue.test.ts/agent-pane-queue.test View Logs
test/agent-pane-queue.test.ts/agent-pane-queue.test View Logs
test/agent-pane-soft-edges.test.ts/agent-pane-soft-edges.test View Logs
test/agent-pane-soft-edges.test.ts/agent-pane-soft-edges.test View Logs

...and 16 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant