Skip to content

test(next): relaunch-wake tests fail without their fixes #22908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 3 commits into from
Oct 21, 2026
Merged

test(next): relaunch-wake tests fail without their fixes #22908

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dae1ac1
test(next): the slow-page wake test runs a real reconnect handshake a…
teamleaderleo Oct 21, 2026
86ea90a
Merge branch 'feat-cmux-next' into cmux/relaunch-wake-tests
teamleaderleo Oct 21, 2026
32d2bd4
Merge branch 'feat-cmux-next' into cmux/relaunch-wake-tests
teamleaderleo Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/AgentPaneRelaunchWakeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ struct AgentPaneRelaunchWakeTests {
let held = AgentPaneWakeState(shell: true, shellText: "cargo test")
tabs.wakeStates["tab_slow"] = held
let page = try #require(tabs.view(for: "tab_slow"))
_ = await page.model.respond(to: AgentPaneRequest(body: ["method": "reconnect"]))
_ = await page.model.respond(to: AgentPaneRequest(body: ["method": "ready", "params": ["reconnect": true]]))
try #require(page.model.hasHandshake, "the reconnect handshake did not run")
let asked = Asked()
tabs.relaunchWake.read = { _, _ in
asked.count += 1
Expand All @@ -131,9 +132,9 @@ struct AgentPaneRelaunchWakeTests {
#expect(await tabs.relaunchWakeStates()["tab_slow"] == held, "a page that had not taken its state dropped it")
#expect(asked.count == 0, "a page that had not taken its state was asked for one")

// After its ready, a page that does not answer in time keeps the tab's kept state.
// After its ready took the state, a page that does not answer in time keeps what it was given.
_ = try await Self.ready(page)
tabs.wakeStates["tab_slow"] = held
#expect(tabs.wakeStates["tab_slow"] == nil && page.model.pendingWake == nil)
#expect(await tabs.relaunchWakeStates()["tab_slow"] == held, "a page that did not answer in time saved nothing over it")
#expect(asked.count == 1)
}
Expand Down