Repository navigation
cmux NEXT Chief: a Chief with no avatar wears the chosen pet character, not the 🫡 disc - #22776
Conversation
…et character, not the 🫡 disc The Home header, the first-run hero, the Home list row and New Message showed 🫡 on a grey disc for a Chief whose profile sets no avatar. They now show the pet character home.chiefPetMascot picks (orb by default), whole on a transparent square so the round avatar clip shows all of it and no disc. Picking another character redraws them live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Pending: CI is running on Last result: Not verified: macOS jobs did not run: compile and app tests were skipped on Written by web and size checks: green |
…ssed character Review of #22776: - The header's avatar read, with the character as its fallback, moves to HomeChiefAvatars.headerAvatar (CmuxNextHomeEngine), and the avatar file lookup and the change callback to ChiefPetSettingsRows (CmuxNextChiefPetWiring): CmuxNextApp shrinks. - ChiefPetMascot is a nonisolated value type, so it is usable off the main actor. - The header follows the character from its first read (not only from the second), and a read for a character picked before the latest one is dropped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Bead |
|
Shipped in:
|
|
Shipped in:
|
Leo: "the avatar, why is it still the circle? ... the nine avatars, we need to be able to just swap them out, just how ChatGPT does."
Change
home.chiefPetMascotpicks (orb by default, one of the Chief Dock's nine pixel characters) in the Home header, the empty conversation's hero, the Home list row and New Message's suggestions.ChiefMascot…Avatar.png): the whole character on a transparent square with room around it. The round avatar clip those views already use shows all of it, with no disc behind it. The vendored sidebar and header drawing are unchanged.HomeChiefAvatars.headerAvatar(CmuxNextHomeEngine), and the character lookup and change callback toChiefPetSettingsRows(CmuxNextChiefPetWiring), so CmuxNextApp shrinks (SW14 size cap).ChiefPetMascotis now anonisolatedvalue type.How the nine look in a round clip (generated from the new files):
Changelog
Changed: A Chief with no avatar of its own shows the chosen Chief pet character instead of 🫡 on a grey disc, and a new character shows everywhere at once.
Observed / Not run
scripts/cmux-next/prepush-gate.pyreports no new violations. I rendered the nine avatar PNGs in a round clip (the sheet above).ChiefDefaultAvatarTests(the default is orb's avatar; each character resolves to its own bundled file; an unknown id falls back to orb; the header wears the character only when the Chief has no avatar of its own). CI runs them.Agent session: cosmic-gray
🤖 Generated with Claude Code