Skip to content

cmux NEXT agent chat: a running command leads with the terminal glyph - #22774

Merged
teamleaderleo merged 11 commits into
feat-cmux-nextfrom
cmux/lawrence-feedback
Oct 21, 2026
Merged

teamleaderleo merged 11 commits into
feat-cmux-nextfrom
cmux/lawrence-feedback

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

Lawrence flagged the running-command line in cmux NEXT's agent chat (iMessage screenshot, 2026-10-20). His second item, the name in the sidebar footer's profile chip, moved to #22845 (account menu, project-picker lane), which makes the chip the avatar alone in the same files; this PR no longer touches Swift.

The running command's leading "•••" (web agent chat). The running turn's line (WorkingFor.tsx) drew WorkingMark before a command in flight: three dots in --agent-accent, which is the pane's text color, so they read as grey static dots and looked like a cropped terminal thumbnail.

  • A command in flight (tool kind execute) now leads with the TerminalSquare glyph the tool rows already use (turns.ts sets doingCommand, new AcpmuxRow field).
  • Other calls lead with their label alone. The working dots this PR first recolored are gone from base (Agent chat: no blinking dots before Thinking or Working for; the Steering caption's words are gone #23034, no blinking marks on the running line), so that part is dropped; the glyph is static, like the tool rows'.
  • "Running N commands ›" already draws a spinner (ToolGroupRow); unchanged. The pane has no per-turn token count, so no "· 26.2k tokens" readout here.

Before / after (running command)

Before After
running command before running command after

Changelog

  • Changed: In the agent chat, a running command leads with a terminal icon .

Tests

  • cd webviews && bun test test/transcript-working-line.test.tsx: red on the test commit (command glyph), 9/9 green on the fix.

Observed / Not run

  • Re-review after the Agent chat: no blinking dots before Thinking or Working for; the Steering caption's words are gone #23034 merge (conflict resolution): PASS at b9d0692.
  • First independent review subagent: PASS; its three nits (memo compares doingCommand, a stale comment, a long comment line) are fixed in the last commit.
  • Ran: the bun test above (red then green), prepush-gate.py (no new violations), scripts/web-lint.sh.
  • Gallery: before/after below are local captures of agent-pane.transcript / working-tools (gallery dev server at the merge-base and at this branch, headless Chromium); gallery-compare.sh has no route from huge-blue to the gallery host. Full bun test test/ in webviews: the only failure on head and not on base is palette ranking eval (untouched area).

Agent session: huge-blue

🤖 Generated with Claude Code

teamleaderleo and others added 3 commits October 21, 2026 01:58
…; footer profile chip drops the name

The running turn's line drew three static-looking grey dots before a command in
flight (the pane's accent is its text color). A command now leads with the
terminal glyph the tool rows use; other calls and Thinking keep the dots, which
take the theme accent (--cmux-accent) and pulse on a 1.4s cycle.

The sidebar footer's profile chip shows the avatar and the menu chevron only;
the name stays in its tooltip and menu (Lawrence: only icon).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 2a643a8: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr22774 -f ref=cmux/lawrence-feedback -f platform=macos -f backend_mode=local

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards.

CI failed on 2a643a8b49 (run 39557226672 attempt 1): 4 code, 1 unknown.

Job Verdict Why
web / react-apps-check (2) code a web test failed
web / react-apps-check (1) code a web test failed
web / react-apps-check (4) code a web test failed
web / react-apps-check (3) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • seen on other PRs agent-pane-queue-steer.test.ts queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or draw...: failed (job)
  • seen on other PRs agent-pane-stream-jitter.test.ts webkit: a queued prompt sent as the next turn moves the view up only: failed (job)
  • seen on other PRs agent-pane-stream-jitter.test.ts webkit: scrolling up while a reply streams is never pulled back: failed (job)
  • seen on other PRs chief-context-copy.test.ts chromium, Catppuccin Mocha, 300px: the context's Copy trails its label and covers no text: failed (job)
  • seen on other PRs chief-context-copy.test.ts chromium, Apple System Colors Light, 300px: the context's Copy trails its label and covers no text: failed (job)
  • seen on other PRs chief-context-copy.test.ts webkit, Catppuccin Mocha, 300px: the context's Copy trails its label and covers no text: failed (job)
  • seen on other PRs chief-context-copy.test.ts webkit, Apple System Colors Light, 300px: the context's Copy trails its label and covers no text: failed (job)
  • seen on other PRs composer-suggested-prompt.test.tsx nothing is suggested from another folder, another worktree, a merged PR, an old chat or a busy one: failed (job)
  • seen on other PRs agent-pane-ctrl-b-background.test.ts with no running call, Ctrl-B stays the composer's and asks nothing: failed (job)
  • seen on other PRs agent-pane-ctrl-b-background.test.ts a Codex chat shows no hint and keeps Ctrl-B: failed (job)
  • ... 12 more in the job logs
Matched log lines
web / react-apps-check (2): (fail) queued and steering prompts > the queue takes its own place in the stack: nothing is cut off or drawn over [1378.29ms]
web / react-apps-check (1): (fail) with no running call, Ctrl-B stays the composer's and asks nothing [1018.28ms]
web / react-apps-check (4): (fail) chromium > the wheel over a long draft stops at its ends and moves nothing else [4134.61ms]
web / react-apps-check (3): (fail) the strip or queue and the card meet square in one rim, and the queue keeps room above [6249.94ms]

Not re-run automatically: web / react-apps-check (2), web / react-apps-check (1), web / react-apps-check (4), web / react-apps-check (3), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; base red: the same failure on the base 6e097d6; does not block
red: web / react-apps-check; base red: the same failure on the base 6e097d6; does not block
red: web / react-apps-check (1); base red: the same failure on the base 6e097d6; does not block
red: web / react-apps-check (2); NEW: { "atEnd": true, - "drops": [], + "drops": [ + "3336ms: 18.5 -> 19.7", + ], } - Expected - 1 + Received + 3 at <anonymous> (/home/runner/_work/cmux/cmux/webview is not red on the base 6e097d6; do not merge until green; see lane-rules
red: web / react-apps-check (3); base red: the same failure on the base 6e097d6; does not block
red: web / react-apps-check (4); base red: the same failure on the base 6e097d6; does not block

CI fast guards failed on 2a643a8b49 (https://github.com/manaflow-ai/cmux/actions/runs/39557226672). It does not block the merge; a red guard merged into main breaks it for every open PR.
The log named no failed step; see the run.

Agents: python3 scripts/ci/guard_attribution.py fix applies the mechanical fixes locally.

Tour of 2a643a8b49 (run): no media. The tour did not run: only webview code changed (6 path(s)), which the gallery advisory run checks in Linux Chromium on the pull request (its artifact holds any captures); add the media-tour-mac label to tour it on a Mac.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Bead cx-nbisv created for this PR by the cmux coordinator.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

owner: 01a15c2b-c6e5-7540-ad96-0eb60604230e

@teamleaderleo
teamleaderleo marked this pull request as ready for review October 21, 2026 02:19
@blacksmith-sh

This comment has been minimized.

@cursor

cursor Bot commented Oct 21, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

teamleaderleo and others added 4 commits October 20, 2026 20:16
#22845 (account menu, project-picker lane) makes the chip the avatar alone and
covers Lawrence's "only icon" ask in the same files; this PR keeps only the
running-line glyph and accent dots.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2b-c6e5-7540-ad96-0eb60604230e&host=huge-blue
@teamleaderleo teamleaderleo changed the title cmux NEXT: terminal glyph and accent dots on the running line; footer profile chip is icon only cmux NEXT agent chat: a running command leads with the terminal glyph; the working dots take the theme accent Oct 21, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

cmux-next guards / defaults-snapshot is red on 19 of 20 fresh feat-cmux-next PR heads in the last 2:00:00, so it is most likely a base red, not this PR's. The base-reds lane has it; a base merge picks up the fix once it lands.

@blacksmith-sh

blacksmith-sh Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Found 24 test failures on Blacksmith runners:

Failures

Test View Logs
test/agent-pane-column-edges.test.ts/agent-pane-column-edges.test View Logs
test/agent-pane-column-edges.test.ts/agent-pane-column-edges.test View Logs
test/agent-pane-ctrl-b-background.test.ts/agent-pane-ctrl-b-background.test View Logs
test/agent-pane-ctrl-b-background.test.ts/agent-pane-ctrl-b-background.test View Logs
test/agent-pane-no-capsules.test.ts/agent-pane-no-capsules.test View Logs
test/agent-pane-no-capsules.test.ts/agent-pane-no-capsules.test View Logs
test/agent-pane-queue-steer.test.ts/agent-pane-queue-steer.test View Logs
test/agent-pane-queue-steer.test.ts/agent-pane-queue-steer.test View Logs
test/agent-pane-stream-jitter.test.ts/agent-pane-stream-jitter.test View Logs
test/agent-pane-stream-jitter.test.ts/agent-pane-stream-jitter.test View Logs

...and 14 more test failures. View all on Blacksmith

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

For the owner (desk:01a15c2b), from the activity-indicators lane: there's a duplicate on base. While a call runs, the live line .cv-worked.has-divider (WorkingFor.tsx, row.doing, from #21631) names the same call that the running tool row right below it shows, so one running call reads twice.

coord-deputy assigned me the fix as a follow-up after this PR lands, so that we don't both edit WorkingFor.tsx at once. The plan is to drop doing from the line while that call's tool row is on screen, with a test that one running tool shows one row. If you'd rather fold it into this PR, say so here and I'll leave it to you.

@teamleaderleo teamleaderleo changed the title cmux NEXT agent chat: a running command leads with the terminal glyph; the working dots take the theme accent cmux NEXT agent chat: a running command leads with the terminal glyph Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Shipped in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant