Repository navigation
webviews: new page code passes ui-rules and tooltip-rules (base red) - #22636
Conversation
…es exceptions ui-rules flagged six lines added since the rule's last green run. Each is a deliberate exception of a kind the codebase already marks with ui-allow, so each gets the note and its reason; no markup or behavior changes: - DensityCard (bc4dce8): the tiles are buttons in the ARIA radio pattern; native radios would change their keys and look. - AppearanceBar (1789a0a): role=toolbar names the floating Undo, Redo and Reset row. - NumberListEditor (1d62787): the token field's own editing keys. - EnvironmentPicker (b0fa794): the Option-Command-1-9 shortcut. - pageKey.ts (2cb4edc): a key press only marks the page key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=c1a6da4a-9c34-4cea-864c-8b045b51ac46&host=huge-blue
…ules) The rule (#20375) allows a tooltip only on a control with no text of its own or one that carries a shortcut. Removed, since the control's text names it: - MobileCard's Remove button ("Removes this phone", e29f59c). - The background-task note and summary row's "Show output" (e774d53). - The subagents prototype's timeline lane title (name: last event). Kept with a tooltip-allow reason: - Composer Stop (585b689): icon-only, and once armed it shows only the Esc key; the tooltip says to press it again. - AgentPairNote (8bd7fcd): the pause's raw error shows nowhere else. - Subagents prototype HarnessMark (an initial standing in for a mark) and the Steps toggle (carries the Option-Command-T shortcut). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=c1a6da4a-9c34-4cea-864c-8b045b51ac46&host=huge-blue
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Probably yours: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 2cd6ae1 to compare; do not merge until green; see lane-rules |
|
Found 98 test failures on Blacksmith runners: Failures
...and 88 more test failures. View all on Blacksmith: run 39508578007, run 39508578345
|
|
Shipped in:
|
…e again (react-apps-check red) react-apps-check is red on every feat-cmux-next push since #22741 and #22667 landed together, and since #22636: - #22741 draws the ↵ steer control only for an agent that reports acpmux `steering`; the composer-row and turn-cycle gallery fixtures never set it, so composer-row-rhythm and composer-turn-cycle wait 30 s for .acpmux-steer-now and time the file out. Both fixtures are Claude Code chats, which steer. - With ↵ drawn in #22667's plain footer, Stop follows it and both add an inset: steer→Stop 16 px against Stop→mic 10 px. ↵ drops its trailing inset when Stop follows it, so the three draw one gap apart. - #22636 removed the Background task note's "Show output" tooltip (tooltip-rules); the test still read it. The click test stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2c-330d-7e83-8d27-d0125af4e8a9&host=huge-blue
…e again (react-apps-check red) (#22833) react-apps-check is red on every feat-cmux-next push since #22741 and #22667 landed together, and since #22636: - #22741 draws the ↵ steer control only for an agent that reports acpmux `steering`; the composer-row and turn-cycle gallery fixtures never set it, so composer-row-rhythm and composer-turn-cycle wait 30 s for .acpmux-steer-now and time the file out. Both fixtures are Claude Code chats, which steer. - With ↵ drawn in #22667's plain footer, Stop follows it and both add an inset: steer→Stop 16 px against Stop→mic 10 px. ↵ drops its trailing inset when Stop follows it, so the three draw one gap apart. - #22636 removed the Background task note's "Show output" tooltip (tooltip-rules); the test still read it. The click test stays. Agent-Session: https://cmux.com/deeplink/agent?harness=claude&session=01a15c2c-330d-7e83-8d27-d0125af4e8a9&host=huge-blue Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ui-rules("migrated page code has no raw roles, tab indexes, key handlers or portals") andtooltip-rules("no element whose text shows on screen also has a tooltip") are red onfeat-cmux-nextfor lines added since they last passed.ui-rules (6 lines). Each is a deliberate exception of a kind the code already marks with
ui-allow:(WidthField, FloatingChat, imeKeys), so each gets the note and its reason. No markup or behavior changes.DensityCard(bc4dce8): the tiles are buttons in the ARIA radio pattern; native radios would change their keys and look.AppearanceBar(1789a0a):role="toolbar"names the floating Undo, Redo and Reset row.NumberListEditor(1d62787): the token field's own editing keys.EnvironmentPicker(b0fa794): the ⌥⌘1–9 shortcut.pageKey.ts(2cb4edc): a key press only marks the page key.tooltip-rules (8 lines). The rule (#20375) allows a tooltip only on a control with no text of its own, or one that carries a shortcut.
tooltip-allow:reason: Composer Stop (585b689), which is icon-only and, once armed, shows only the Esc key; AgentPairNote's raw error (8bd7fcd), which shows nowhere else; the prototype's HarnessMark (an initial standing in for a mark) and its Steps toggle (carries ⌥⌘T).Verification (Linux, bun 1.3.14, at feat-cmux-next 2cd6ae1)
Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the red
ui-rulesandtooltip-ruleschecks onfeat-cmux-nextwithout changing markup or behavior.For
ui-rules, six deliberate exceptions now carryui-allow:comments with reasons, matching the pattern already used in the codebase: button tiles in an ARIA radio pattern,AppearanceBar's toolbar role,NumberListEditor's field-local editing keys,EnvironmentPicker's ⌥⌘1–9 shortcut, and apageKeykey press that only marks the page key.For
tooltip-rules, removes tooltips that duplicated visible text (the Remove phone button, both "Show output" links, and the subagents timeline lane) and marks withtooltip-allow:the four justified ones: the icon-only Composer Stop,AgentPairNote's raw error (visible nowhere else), theHarnessMarkinitial, and the Steps toggle that carries ⌥⌘T.Written for commit 34f2317. Summary will update on new commits.