Switch release builds to macOS Tahoe runner - #2233
Conversation
Use warp-macos-26-arm64-6x for release builds to match nightly. Also add a dry-run artifact upload path for workflow_dispatch so the release pipeline can be tested without creating a real release.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the release workflow: switched the macOS runner label and added a conditional "Upload build artifacts (dry-run)" step for non-tag workflow_dispatch events; the existing release upload now only runs on tag pushes with uploads enabled. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub_Actions as "GitHub Actions\n(release workflow)"
participant Runner as "macOS Runner\n(warp-macos-26-arm64-6x)"
participant Artifact_Store as "Actions Artifact\nService"
participant GitHub_Release as "GitHub Release"
Developer->>GitHub_Actions: trigger (workflow_dispatch or push)
GitHub_Actions->>Runner: start job on warp-macos-26-arm64-6x
Runner->>GitHub_Actions: build artifacts
alt event == workflow_dispatch AND skip_upload != 'true'
GitHub_Actions->>Artifact_Store: upload artifacts (dry-run)
else event == push AND ref is tag AND skip_upload != 'true'
GitHub_Actions->>Artifact_Store: upload artifacts
GitHub_Actions->>GitHub_Release: publish release asset
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Greptile SummaryThis PR makes two targeted improvements to the release workflow: it upgrades the runner from Confidence Score: 5/5Safe to merge — changes are minimal, logic is correct, and a successful dry-run has already been verified. Both changes are small and well-reasoned. The runner bump is a one-liner. The dry-run/release upload conditions are mutually exclusive and correctly compose with the existing guard outputs. The linked action run confirms the new runner and dry-run path work end-to-end. No security or data-loss risk introduced. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Trigger] --> B{Event type?}
B -->|push: refs/tags/v*| C[Tag push]
B -->|workflow_dispatch| D[Manual dispatch]
C --> E[guard_release_assets]
D --> E
E -->|skip_all == 'true'| F[Skip all build steps]
E -->|skip_all != 'true'| G[Build / Sign / Notarize / Attest]
G -->|skip_upload == 'true'| F
G -->|skip_upload != 'true' AND not a tag| H[Upload dry-run artifact\nactions/upload-artifact]
G -->|skip_upload != 'true' AND is a tag| I[Upload release asset\nsoftprops/action-gh-release]
H --> J[Cleanup keychain]
I --> J
F --> J
Reviews (1): Last reviewed commit: "Switch release builds to macOS Tahoe run..." | Re-trigger Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release.yml:
- Around line 332-343: The two step conditions using startsWith(github.ref,
'refs/tags/') (the dry-run upload artifact step and the "Upload release asset"
step) must also check github.event_name so a manual workflow_dispatch on a tag
doesn't act like a tag push; update the dry-run step's if (currently:
steps.guard_release_assets.outputs.skip_upload != 'true' &&
!startsWith(github.ref, 'refs/tags/')) to explicitly allow workflow_dispatch
(e.g. github.event_name == 'workflow_dispatch') or non-tag pushes, and change
the Upload release asset step's if (currently:
steps.guard_release_assets.outputs.skip_upload != 'true' &&
startsWith(github.ref, 'refs/tags/')) to require github.event_name == 'push' &&
startsWith(github.ref, 'refs/tags/'); reference the existing conditions and
steps.guard_release_assets.outputs.skip_upload when making these changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c80b718b-142e-4fa7-8f55-a96767460884
📒 Files selected for processing (1)
.github/workflows/release.yml
Prevents workflow_dispatch triggered on a tag ref from accidentally uploading real release assets.
* Switch release builds to macOS Tahoe runner Use warp-macos-26-arm64-6x for release builds to match nightly. Also add a dry-run artifact upload path for workflow_dispatch so the release pipeline can be tested without creating a real release. * Gate release upload on event_name, not just ref prefix Prevents workflow_dispatch triggered on a tag ref from accidentally uploading real release assets. --------- Co-authored-by: Lawrence Chen <lawrencecchen@users.noreply.github.com>
This branch was successfully deployed
1 participant
Summary
warp-macos-15-arm64-6x(Sequoia) towarp-macos-26-arm64-6x(Tahoe) to match nightlyworkflow_dispatchso the release pipeline can be tested without creating a real releaseTesting
Summary by cubic
Switch release builds from
warp-macos-15-arm64-6x(Sequoia) towarp-macos-26-arm64-6x(Tahoe) to match nightly and keep environments consistent. Add a dry-run path forworkflow_dispatchthat uploads artifacts viaactions/upload-artifact; GitHub Release uploads viasoftprops/action-gh-releasenow run only for push events on tag refs to prevent accidental releases.Written for commit a67a3d1. Summary will update on new commits.
Summary by CodeRabbit
Note: No user-facing changes; updates apply to release automation only.