Repository navigation
Fix nightly SSH remote daemon checksum mismatch #2225
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4146,7 +4146,29 @@ final class WorkspaceRemoteSessionController { | |
| .appendingPathComponent("cmuxd-remote", isDirectory: false) | ||
| } | ||
|
|
||
| /// Fetch the live manifest JSON from the release, returning nil on any failure. | ||
| private static func fetchRemoteManifestLocked(releaseURL: String, version: String) -> WorkspaceRemoteDaemonManifest? { | ||
| guard let manifestURL = URL(string: "\(releaseURL)/cmuxd-remote-manifest.json") else { return nil } | ||
|
Comment on lines
+4149
to
+4151
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
rg -n -C3 'releaseURL|checksumsURL|downloadURL|cmuxd-remote-manifest\.json|releases/(tag|download)' \
-g '!**/.build/**' \
-g '!**/DerivedData/**' \
-g '!**/node_modules/**'Repository: manaflow-ai/cmux Length of output: 29894 Derive the live-manifest URL from a confirmed asset URL. The manifest builder correctly sets - guard let manifestURL = URL(string: "\(releaseURL)/cmuxd-remote-manifest.json") else { return nil }
+ guard let assetURL = URL(string: releaseURL) else { return nil }
+ let manifestURL = assetURL.deletingLastPathComponent()
+ .appendingPathComponent("cmuxd-remote-manifest.json")At the call site, pass - let downloadedURL = try downloadRemoteDaemonBinaryLocked(entry: entry, version: manifest.appVersion, releaseURL: manifest.releaseURL)
+ let downloadedURL = try downloadRemoteDaemonBinaryLocked(
+ entry: entry,
+ version: manifest.appVersion,
+ releaseURL: manifest.checksumsURL
+ )Also applies to: 4171, 4218–4225, 4265 🤖 Prompt for AI Agents
Contributor
Author
There was a problem hiding this comment. Not a real issue. There was a problem hiding this comment.
✏️ Learnings added
🧠 Learnings used |
||
| let request = NSMutableURLRequest(url: manifestURL) | ||
| request.timeoutInterval = 15 | ||
| request.setValue("cmux/\(version)", forHTTPHeaderField: "User-Agent") | ||
| let session = URLSession(configuration: .ephemeral) | ||
| let semaphore = DispatchSemaphore(value: 0) | ||
| var resultData: Data? | ||
| session.dataTask(with: request as URLRequest) { data, response, error in | ||
| defer { semaphore.signal() } | ||
| guard error == nil, | ||
| let httpResponse = response as? HTTPURLResponse, | ||
| (200...299).contains(httpResponse.statusCode) else { return } | ||
| resultData = data | ||
| }.resume() | ||
| _ = semaphore.wait(timeout: .now() + 20.0) | ||
| session.finishTasksAndInvalidate() | ||
| guard let data = resultData else { return nil } | ||
| return try? JSONDecoder().decode(WorkspaceRemoteDaemonManifest.self, from: data) | ||
| } | ||
|
|
||
| private func downloadRemoteDaemonBinaryLocked(entry: WorkspaceRemoteDaemonManifest.Entry, version: String, releaseURL: String? = nil) throws -> URL { | ||
| guard let url = URL(string: entry.downloadURL) else { | ||
| throw NSError(domain: "cmux.remote.daemon", code: 25, userInfo: [ | ||
| NSLocalizedDescriptionKey: "remote daemon manifest has an invalid download URL", | ||
|
|
@@ -4193,10 +4215,21 @@ final class WorkspaceRemoteSessionController { | |
| } | ||
|
|
||
| let downloadedSHA = try Self.sha256Hex(forFile: downloadedURL) | ||
| if downloadedSHA != entry.sha256.lowercased() { | ||
| // The embedded manifest's checksum doesn't match the downloaded binary. | ||
| // This can happen when a newer nightly overwrites the shared release | ||
| // asset after this build's manifest was embedded. As a fallback, fetch | ||
| // the live manifest from the release and verify against that. | ||
| if let releaseURL, | ||
| let liveManifest = Self.fetchRemoteManifestLocked(releaseURL: releaseURL, version: version), | ||
| let liveEntry = liveManifest.entry(goOS: entry.goOS, goArch: entry.goArch), | ||
| downloadedSHA == liveEntry.sha256.lowercased() { | ||
| debugLog("remote.download.checksum-fallback: embedded manifest checksum stale, live manifest matched for \(entry.assetName)") | ||
| } else { | ||
| throw NSError(domain: "cmux.remote.daemon", code: 28, userInfo: [ | ||
| NSLocalizedDescriptionKey: "remote daemon checksum mismatch for \(entry.assetName)", | ||
| ]) | ||
| } | ||
| } | ||
|
|
||
| let tempURL = cacheURL.deletingLastPathComponent() | ||
|
|
@@ -4229,7 +4262,7 @@ final class WorkspaceRemoteSessionController { | |
| } | ||
| try? FileManager.default.removeItem(at: cacheURL) | ||
| } | ||
| let downloadedURL = try downloadRemoteDaemonBinaryLocked(entry: entry, version: manifest.appVersion, releaseURL: manifest.releaseURL) | ||
| debugLog("remote.build.downloaded path=\(downloadedURL.path)") | ||
| return downloadedURL | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downloadURLpoints to versioned assetsThe unsuffixed
cmuxd-remote-manifest.jsonis a verbatim copy of the suffixed manifest, so everydownloadURLinside it references the versioned asset name (e.g.cmuxd-remote-darwin-arm64-${NIGHTLY_BUILD}), not the genericcmuxd-remote-darwin-arm64.The Swift fallback in
fetchRemoteManifestLockedis unaffected — it only reads thesha256field from the live manifest, neverdownloadURL. However, any external tooling or users who fetchcmuxd-remote-manifest.jsonand follow itsdownloadURLfields to find the "latest" binary will be silently redirected to a versioned filename on every build. This may be intentional, but it's worth documenting in the comment on line 338 so future maintainers don't try to "fix" it.