Skip to content

fix(sidebar): use dedicated setting for port link browser preference #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 1 commit into from
Mar 27, 2026
Merged

fix(sidebar): use dedicated setting for port link browser preference #2219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
339 changes: 339 additions & 0 deletions Resources/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44906,6 +44906,345 @@
}
}
},
"settings.app.openSidebarPortLinks": {
"extractionState": "manual",
"localizations": {
"en": {
"stringUnit": {
"state": "translated",
"value": "Open Sidebar Port Links in cmux Browser"
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": "サイドバーのポートリンクをcmuxブラウザで開く"
}
},
"zh-Hans": {
"stringUnit": {
"state": "translated",
"value": "在 cmux 浏览器中打开侧边栏端口链接"
}
},
"zh-Hant": {
"stringUnit": {
"state": "translated",
"value": "在 cmux 瀏覽器中開啟側邊欄連接埠連結"
}
},
"ko": {
"stringUnit": {
"state": "translated",
"value": "사이드바 포트 링크를 cmux 브라우저에서 열기"
}
},
"de": {
"stringUnit": {
"state": "translated",
"value": "Seitenleisten-Port-Links im cmux-Browser öffnen"
}
},
"es": {
"stringUnit": {
"state": "translated",
"value": "Abrir enlaces de puerto de la barra lateral en el navegador de cmux"
}
},
"fr": {
"stringUnit": {
"state": "translated",
"value": "Ouvrir les liens de port de la barre latérale dans le navigateur cmux"
}
},
"it": {
"stringUnit": {
"state": "translated",
"value": "Apri link delle porte della barra laterale nel browser cmux"
}
},
"da": {
"stringUnit": {
"state": "translated",
"value": "Åbn sidebjælkens portlinks i cmux-browser"
}
},
"pl": {
"stringUnit": {
"state": "translated",
"value": "Otwieraj linki portów z paska bocznego w przeglądarce cmux"
}
},
"ru": {
"stringUnit": {
"state": "translated",
"value": "Открывать ссылки портов боковой панели в браузере cmux"
}
},
"bs": {
"stringUnit": {
"state": "translated",
"value": "Otvori port linkove iz bočne trake u cmux pregledniku"
}
},
"ar": {
"stringUnit": {
"state": "translated",
"value": "فتح روابط المنافذ في متصفح cmux"
}
},
"nb": {
"stringUnit": {
"state": "translated",
"value": "Åpne sidepanel-portlenker i cmux-nettleser"
}
},
"pt-BR": {
"stringUnit": {
"state": "translated",
"value": "Abrir Links de Porta da Barra Lateral no Navegador do cmux"
}
},
"th": {
"stringUnit": {
"state": "translated",
"value": "เปิดลิงก์พอร์ตในแถบด้านข้างด้วยเบราว์เซอร์ cmux"
}
},
"tr": {
"stringUnit": {
"state": "translated",
"value": "Kenar Çubuğu Port Bağlantılarını cmux Tarayıcısında Aç"
}
}
}
},
"settings.app.openSidebarPortLinks.subtitleOff": {
"extractionState": "manual",
"localizations": {
"en": {
"stringUnit": {
"state": "translated",
"value": "Port clicks open in your default browser."
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": "ポートをクリックするとデフォルトブラウザで開きます。"
}
},
"zh-Hans": {
"stringUnit": {
"state": "translated",
"value": "端口点击在默认浏览器中打开。"
}
},
"zh-Hant": {
"stringUnit": {
"state": "translated",
"value": "連接埠點擊會在您的預設瀏覽器中開啟。"
}
},
"ko": {
"stringUnit": {
"state": "translated",
"value": "포트를 클릭하면 기본 브라우저에서 열립니다."
}
},
"de": {
"stringUnit": {
"state": "translated",
"value": "Port-Klicks öffnen in Ihrem Standardbrowser."
}
},
"es": {
"stringUnit": {
"state": "translated",
"value": "Los clics en puertos abren en tu navegador predeterminado."
}
},
"fr": {
"stringUnit": {
"state": "translated",
"value": "Les clics de port ouvrent dans votre navigateur par défaut."
}
},
"it": {
"stringUnit": {
"state": "translated",
"value": "I clic sulle porte aprono nel browser predefinito."
}
},
"da": {
"stringUnit": {
"state": "translated",
"value": "Portklik åbner i din standardbrowser."
}
},
"pl": {
"stringUnit": {
"state": "translated",
"value": "Kliknięcia portów otwierają w domyślnej przeglądarce."
}
},
"ru": {
"stringUnit": {
"state": "translated",
"value": "Ссылки портов открываются в браузере по умолчанию."
}
},
"bs": {
"stringUnit": {
"state": "translated",
"value": "Klikovi na portove se otvaraju u podrazumijevanom pregledniku."
}
},
"ar": {
"stringUnit": {
"state": "translated",
"value": "نقرات المنافذ تفتح في متصفحك الافتراضي."
}
},
"nb": {
"stringUnit": {
"state": "translated",
"value": "Portklikk åpner i standard nettleser."
}
},
"pt-BR": {
"stringUnit": {
"state": "translated",
"value": "Cliques em portas abrem no seu navegador padrão."
}
},
"th": {
"stringUnit": {
"state": "translated",
"value": "คลิกพอร์ตจะเปิดในเบราว์เซอร์เริ่มต้นของคุณ"
}
},
"tr": {
"stringUnit": {
"state": "translated",
"value": "Port tıklamaları varsayılan tarayıcınızda açılır."
}
}
}
},
"settings.app.openSidebarPortLinks.subtitleOn": {
"extractionState": "manual",
"localizations": {
"en": {
"stringUnit": {
"state": "translated",
"value": "Port clicks open inside cmux browser."
}
},
"ja": {
"stringUnit": {
"state": "translated",
"value": "ポートをクリックするとcmuxブラウザ内で開きます。"
}
},
"zh-Hans": {
"stringUnit": {
"state": "translated",
"value": "端口点击在 cmux 浏览器中打开。"
}
},
"zh-Hant": {
"stringUnit": {
"state": "translated",
"value": "連接埠點擊會在 cmux 瀏覽器中開啟。"
}
},
"ko": {
"stringUnit": {
"state": "translated",
"value": "포트를 클릭하면 cmux 브라우저에서 열립니다."
}
},
"de": {
"stringUnit": {
"state": "translated",
"value": "Port-Klicks öffnen im cmux-Browser."
}
},
"es": {
"stringUnit": {
"state": "translated",
"value": "Los clics en puertos abren dentro del navegador de cmux."
}
},
"fr": {
"stringUnit": {
"state": "translated",
"value": "Les clics de port ouvrent dans le navigateur cmux."
}
},
"it": {
"stringUnit": {
"state": "translated",
"value": "I clic sulle porte aprono nel browser cmux."
}
},
"da": {
"stringUnit": {
"state": "translated",
"value": "Portklik åbner i cmux-browseren."
}
},
"pl": {
"stringUnit": {
"state": "translated",
"value": "Kliknięcia portów otwierają w przeglądarce cmux."
}
},
"ru": {
"stringUnit": {
"state": "translated",
"value": "Ссылки портов открываются во встроенном браузере cmux."
}
},
"bs": {
"stringUnit": {
"state": "translated",
"value": "Klikovi na portove se otvaraju unutar cmux preglednika."
}
},
"ar": {
"stringUnit": {
"state": "translated",
"value": "نقرات المنافذ تفتح داخل متصفح cmux."
}
},
"nb": {
"stringUnit": {
"state": "translated",
"value": "Portklikk åpner i cmux-nettleseren."
}
},
"pt-BR": {
"stringUnit": {
"state": "translated",
"value": "Cliques em portas abrem dentro do navegador do cmux."
}
},
"th": {
"stringUnit": {
"state": "translated",
"value": "คลิกพอร์ตจะเปิดในเบราว์เซอร์ cmux"
}
},
"tr": {
"stringUnit": {
"state": "translated",
"value": "Port tıklamaları cmux tarayıcısında açılır."
}
}
}
},
"settings.app.hideAllSidebarDetails": {
"extractionState": "manual",
"localizations": {
Expand Down
4 changes: 3 additions & 1 deletion Sources/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11015,6 +11015,8 @@ private struct TabItemView: View, Equatable {
@AppStorage("sidebarShowPullRequest") private var sidebarShowPullRequest = true
@AppStorage(BrowserLinkOpenSettings.openSidebarPullRequestLinksInCmuxBrowserKey)
private var openSidebarPullRequestLinksInCmuxBrowser = BrowserLinkOpenSettings.defaultOpenSidebarPullRequestLinksInCmuxBrowser
@AppStorage(BrowserLinkOpenSettings.openSidebarPortLinksInCmuxBrowserKey)
private var openSidebarPortLinksInCmuxBrowser = BrowserLinkOpenSettings.defaultOpenSidebarPortLinksInCmuxBrowser
@AppStorage("sidebarShowSSH") private var sidebarShowSSH = true
@AppStorage("sidebarShowPorts") private var sidebarShowPorts = true
@AppStorage("sidebarShowLog") private var sidebarShowLog = true
Expand Down Expand Up @@ -12220,7 +12222,7 @@ private struct TabItemView: View, Equatable {
private func openPortLink(_ port: Int) {
guard let url = URL(string: "http://localhost:\(port)") else { return }
updateSelection()
if openSidebarPullRequestLinksInCmuxBrowser {
if openSidebarPortLinksInCmuxBrowser {
if tabManager.openBrowser(
inWorkspace: tab.id,
url: url,
Expand Down
10 changes: 10 additions & 0 deletions Sources/Panels/BrowserPanel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,9 @@ enum BrowserLinkOpenSettings {
static let openSidebarPullRequestLinksInCmuxBrowserKey = "browserOpenSidebarPullRequestLinksInCmuxBrowser"
static let defaultOpenSidebarPullRequestLinksInCmuxBrowser: Bool = true

static let openSidebarPortLinksInCmuxBrowserKey = "browserOpenSidebarPortLinksInCmuxBrowser"
static let defaultOpenSidebarPortLinksInCmuxBrowser: Bool = true

static let interceptTerminalOpenCommandInCmuxBrowserKey = "browserInterceptTerminalOpenCommandInCmuxBrowser"
static let defaultInterceptTerminalOpenCommandInCmuxBrowser: Bool = true

Expand All @@ -549,6 +552,13 @@ enum BrowserLinkOpenSettings {
return defaults.bool(forKey: openSidebarPullRequestLinksInCmuxBrowserKey)
}

static func openSidebarPortLinksInCmuxBrowser(defaults: UserDefaults = .standard) -> Bool {
if defaults.object(forKey: openSidebarPortLinksInCmuxBrowserKey) == nil {
return defaultOpenSidebarPortLinksInCmuxBrowser
}
return defaults.bool(forKey: openSidebarPortLinksInCmuxBrowserKey)
Comment on lines +556 to +559

@cubic-dev-ai cubic-dev-ai Bot Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Migrate the new port-link preference from the old PR-link setting when the new key is absent, otherwise existing users get port links forced back to the default.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At Sources/Panels/BrowserPanel.swift, line 556:

<comment>Migrate the new port-link preference from the old PR-link setting when the new key is absent, otherwise existing users get port links forced back to the default.</comment>

<file context>
@@ -549,6 +552,13 @@ enum BrowserLinkOpenSettings {
     }
 
+    static func openSidebarPortLinksInCmuxBrowser(defaults: UserDefaults = .standard) -> Bool {
+        if defaults.object(forKey: openSidebarPortLinksInCmuxBrowserKey) == nil {
+            return defaultOpenSidebarPortLinksInCmuxBrowser
+        }
</file context>
Suggested change
if defaults.object(forKey: openSidebarPortLinksInCmuxBrowserKey) == nil {
return defaultOpenSidebarPortLinksInCmuxBrowser
}
return defaults.bool(forKey: openSidebarPortLinksInCmuxBrowserKey)
if defaults.object(forKey: openSidebarPortLinksInCmuxBrowserKey) != nil {
return defaults.bool(forKey: openSidebarPortLinksInCmuxBrowserKey)
}
if defaults.object(forKey: openSidebarPullRequestLinksInCmuxBrowserKey) != nil {
return defaults.bool(forKey: openSidebarPullRequestLinksInCmuxBrowserKey)
}
return defaultOpenSidebarPortLinksInCmuxBrowser
Fix with Cubic

}

static func interceptTerminalOpenCommandInCmuxBrowser(defaults: UserDefaults = .standard) -> Bool {
if defaults.object(forKey: interceptTerminalOpenCommandInCmuxBrowserKey) != nil {
return defaults.bool(forKey: interceptTerminalOpenCommandInCmuxBrowserKey)
Expand Down
Loading
Loading