Repository navigation
ci(cmux-tui): hosted verification gate lists every job result, then fails - #22164
Conversation
…d job before failing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… fails once Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
|
Bead |
[Medium impact] The PR appears safe to merge; it reports all selected results without weakening the verification gate. SummaryThe hosted verification gate now prints every selected job’s result before exiting. It still fails when any required job is unsuccessful.
Acknowledged by Reviews (1) · Last reviewed commit: "ci(cmux-tui): hosted verification gate l..." · Reviewed by Greptile |
|
Review (correctness first, subagent), head The
Verdict: MERGE |
|
Shipped in:
|
What
The cmux-tui
focused hosted verificationgate (Require selected verification jobs) stopped at the first red job. A redlint (linux)(today a base clippy red inghostty-vtandcmux-tui-core) hid whether the filtered Rust tests passed, so every./scripts/verify-cmux-tui-hosted.sh --filterrun needed a job-log API read to find the test result.Now the step checks every selected job, prints one line per job (
Rust tests: successor::error::lint finished with result 'failure'), and fails once at the end. Which jobs are required doesn't change.Numbers
--filterruns (39319904870, 39319904556, 39319904858, 39319906857, 39321361796) ended with onlylint finished with result 'failure'in the gate. Finding thattest (linux)passed took one extra jobs API read and one log download per run (about 2 REST calls and a 2-6k line log each).Tests
tests/test_tui_focused_filter_guard.py::test_hosted_verification_gate_reports_every_selected_job_before_failingruns the real step script with a red lint and macOS job and green tests. It was committed first (ba59c8c) and failed on base (only the lint line printed); it passes on the fix.test_macos_job_runs_the_focused_filter,test_lint_is_one_required_job_and_os_matrix_only_runs_behavior_tests) already fail on basea827da19e2f; this PR doesn't touch them.Risk
High by path (
cmux-tui.yml). The change only collects failures before exiting; the set of required jobs and the exit status for any red stay the same.Not UI: CI workflow step only.
Review and runtime evidence
Review: SHIP at 41f1e6b (independent correctness-first reviewer subagent; it ran the step script 14 ways under
bash --noprofile --norc -eo pipefailand found no way for a red, cancelled, skipped or empty result to pass)Runtime test: tests/test_tui_focused_filter_guard.py::test_hosted_verification_gate_reports_every_selected_job_before_failing,
python -m pytest -q tests/test_tui_focused_filter_guard.pyat 41f1e6b (fails at ba59c8c, passes at 41f1e6b)Review follow-up (not in this PR):
ci-guards.ymlrunspython3 tests/test_tui_focused_filter_guard.py, and the file has no__main__runner, so CI never calls itstest_*functions. Two of them already fail on base (above). That belongs in its own change.🤖 Generated with Claude Code