Repository navigation
ci(web): run the webview tests in four shards instead of two - #22146
teamleaderleo wants to merge 1 commit into
Conversation
Each react-apps-check shard spends nearly all of its test step on its Vite dev server files, which run two at a time on the 8 vCPU runner. With two shards, shard 2 spent 1,037 of its 1,058 s there (job 117948581151) and its other 136 files took 20 s. Four shards give each one 28 to 34 dev server files instead of 58 to 64. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Unclear: CI failed on
Not re-run automatically: Written by red: web / Web status; do not merge until green; see lane-rules
Agents: |
|
Found 1 test failure on Blacksmith runners: Failure
|
[Medium impact] The PR appears safe to merge. SummaryExpands the webview test matrix from two shards to four.
Reviews (1) · Last reviewed commit: "ci(web): run the webview tests in four s..." · Reviewed by Greptile |
|
Bead |
|
Superseded by #22237 (merged): react-apps-check already runs four shards on feat-cmux-next, on the 32 vCPU runner after the twelve-wide trial. Nothing left to land here. |
The webview test step sets how long
react-apps-checktakes, and nearly all of that step goes to the Vite dev server files.scripts/ci/run-webviews-tests.shruns thoseCMUX_WEB_TEST_DEV_JOBSat a time, which is 2 on the 8 vCPU runner.Measured on job 117948581151,
react-apps-check (2)at two shards:With four shards, each gets 28 to 34 dev server files instead of 58 to 64 (round robin over the git-index list, same split rule). The test step on the critical path should drop to about half, roughly 550 s, and the whole job from about 19.5 min to about 11 min. The per-shard fixed cost (about 110 s for setup, the bundle build and the engine install) now runs four times instead of twice on free Blacksmith runners.
Only the matrix changed. The aggregate
react-apps-checkgate, the per-file isolation, the warmers and the PR-scoped check on shard 1 are unchanged.Observed / Not run
git ls-fileswith the script's own dev-server pattern.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Runs the webview tests in four shards instead of two, roughly halving the
react-apps-checkcritical path.Nearly all of a shard's test step goes to its Vite dev server files, which run two at a time on the 8 vCPU runner: shard 2 in job 117948581151 spent 1,037 of its 1,058 s there while its other 136 files finished in 20 s. Four shards give each 28–34 dev server files instead of 58–64, so the test step should drop to about 550 s and the whole job from ~19.5 to ~11 min. The tradeoff is that per-shard setup, bundle build, and engine install now run four times instead of twice.
Only the workflow matrix changed; the aggregate gate, per-file isolation, warmers, and PR-scoped check on shard 1 are unchanged.
Written for commit 4272c69. Summary will update on new commits.