Repository navigation
Composer: a subtler, glassy focus ring #22114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With
data-cmux-see-throughanddata-borders="none", keyboard focus still brightens the composer's top edge. The border setting clears--acpmux-card-ringand--acpmux-composer-edge-focus, but this new rule changes a separate shadow layer. Excludedata-borders="none"from this rule so focusing the card respects the user's border setting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this as is on purpose. borders none doesn't clear the glass card's top-lit rim at rest either; it's the glass highlight, not a border. With borders none the focus ring is already transparent, so over art this brightening is the only visible keyboard focus cue. Dropping it would leave a focused composer identical to an idle one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That context makes sense. Since
--acpmux-composer-rimis the glass highlight and remains present at rest,data-borders="none"clearing only--acpmux-card-ringand the focus tone is intentional. Removing this override would make keyboard focus indistinguishable from idle over art, so the brightened top rim is a valid remaining focus cue rather than a border violation. I’m withdrawing this finding.